From: Stephen Hemminger <stephen@networkplumber.org>
To: Lorenzo Colitti <lorenzo@google.com>
Cc: Subash Abhinov Kasiviswanathan <subashab@codeaurora.org>,
netdev@vger.kernel.org, David Ahern <dsahern@gmail.com>,
Steffen Klassert <steffen.klassert@secunet.com>
Subject: Re: [PATCH iproute2-next v2] ip-xfrm: Add support for OUTPUT_MARK
Date: Tue, 12 Jun 2018 21:24:01 -0700 [thread overview]
Message-ID: <20180612212401.3383c5e4@xeon-e3> (raw)
In-Reply-To: <CAKD1Yr119qtuabrPL=MbVGeUgRykTeqCmjvCb1buAQU2yZCKjw@mail.gmail.com>
On Wed, 13 Jun 2018 12:14:53 +0900
Lorenzo Colitti <lorenzo@google.com> wrote:
> On Wed, Jun 13, 2018 at 3:48 AM Subash Abhinov Kasiviswanathan
> <subashab@codeaurora.org> wrote:
> >
> > src 192.168.1.1 dst 192.168.1.2
> > proto esp spi 0x00004321 reqid 0 mode tunnel
> > replay-window 0 flag af-unspec
> > mark 0x10000/0x3ffff
> > output-mark 0x20000
>
> Nit: I don't know what guarantees we provide (if any) that the output
> format of "ip xfrm state" does not change except to add new lines at
> the end. Personally, I feel that an app or script that depends on
> "auth-trunc" (or anything else, really) being on the line immediately
> after "mark" is brittle and should be fixed. This is particularly true
> since in general between the mark and the encryption there might be an
> auth-trunc line, or an auth line, or neither. As such, adding this
> line here seems OK to me.
Scripts should use json mode. If it ever gets added to xfrm output (hint).
next prev parent reply other threads:[~2018-06-13 4:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-12 18:48 [PATCH iproute2-next v2] ip-xfrm: Add support for OUTPUT_MARK Subash Abhinov Kasiviswanathan
2018-06-13 3:14 ` Lorenzo Colitti
2018-06-13 4:24 ` Stephen Hemminger [this message]
2018-06-14 3:39 ` David Ahern
2018-06-14 5:09 ` Subash Abhinov Kasiviswanathan
2018-06-14 16:29 ` David Ahern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180612212401.3383c5e4@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=dsahern@gmail.com \
--cc=lorenzo@google.com \
--cc=netdev@vger.kernel.org \
--cc=steffen.klassert@secunet.com \
--cc=subashab@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.