All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tiwei Bie <tiwei.bie@intel.com>
To: Marvin Liu <yong.liu@intel.com>
Cc: maxime.coquelin@redhat.com, zhihong.wang@intel.com, dev@dpdk.org
Subject: Re: [PATCH 3/7] net/virtio-user: add mgr_rxbuf and in_order vdev parameters
Date: Wed, 13 Jun 2018 14:37:23 +0800	[thread overview]
Message-ID: <20180613063723.GA27860@debian> (raw)
In-Reply-To: <20180608090724.20855-4-yong.liu@intel.com>

On Fri, Jun 08, 2018 at 05:07:20PM +0800, Marvin Liu wrote:
[...]
> @@ -419,6 +420,12 @@ virtio_user_dev_init(struct virtio_user_dev *dev, char *path, int queues,
>  		dev->device_features = VIRTIO_USER_SUPPORTED_FEATURES;
>  	}
>  
> +	if (!mrg_rxbuf)
> +		dev->device_features &= ~(1ull << VIRTIO_NET_F_MRG_RXBUF);
> +
> +	if (!in_order)
> +		dev->device_features &= ~(1ull << VIRTIO_F_IN_ORDER);

You also need to handle the server mode case.
In virtio_user_server_reconnect(),
dev->device_features will be overwritten.

Thanks

  reply	other threads:[~2018-06-13  6:37 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-08  9:07 [PATCH 0/7] support VIRTIO_F_IN_ORDER feature Marvin Liu
2018-06-08  2:11 ` Liu, Yong
2018-06-08  9:07 ` [PATCH 1/7] vhost: announce VIRTIO_F_IN_ORDER support Marvin Liu
2018-06-13  6:18   ` Tiwei Bie
2018-06-08  9:07 ` [PATCH 2/7] net/virtio: add VIRTIO_F_IN_ORDER definition Marvin Liu
2018-06-08  9:07 ` [PATCH 3/7] net/virtio-user: add mgr_rxbuf and in_order vdev parameters Marvin Liu
2018-06-13  6:37   ` Tiwei Bie [this message]
2018-06-08  9:07 ` [PATCH 4/7] net/virtio: free IN_ORDER descriptors Marvin Liu
2018-06-08  9:07 ` [PATCH 5/7] net/virtio: support IN_ORDER Rx and Tx Marvin Liu
2018-06-20  7:41   ` Tiwei Bie
2018-06-22  8:05     ` Liu, Yong
2018-06-08  9:07 ` [PATCH 6/7] net/virtio: add IN_ORDER Rx/Tx into selection Marvin Liu
2018-06-20  7:44   ` Tiwei Bie
2018-06-20 16:13     ` Liu, Yong
2018-06-08  9:07 ` [PATCH 7/7] net/virtio: annouce VIRTIO_F_IN_ORDER support Marvin Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180613063723.GA27860@debian \
    --to=tiwei.bie@intel.com \
    --cc=dev@dpdk.org \
    --cc=maxime.coquelin@redhat.com \
    --cc=yong.liu@intel.com \
    --cc=zhihong.wang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.