From: hch@lst.de (Christoph Hellwig)
Subject: [PATCH 06/10] nvme: add ANA support
Date: Wed, 13 Jun 2018 09:38:59 +0200 [thread overview]
Message-ID: <20180613073859.GA22633@lst.de> (raw)
In-Reply-To: <20180612104544.4fd45421@pentland.suse.de>
On Tue, Jun 12, 2018@10:45:44AM +0200, Hannes Reinecke wrote:
> > + le32_to_cpu(desc->grpid),
> > + nvme_ana_state_names[desc->state]);
> > +
> > + if (!nr_nsids)
> > + return 0;
> > +
> This will cause any 'change' state during runtime never to be evaluated
> as we're setting the RGO bit, and consequently 'nnsids' is zero:
During runtime RGO should not be set, but during initialization we
do set it indeed. So I've moved the check up to fix this.
next prev parent reply other threads:[~2018-06-13 7:38 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-11 14:11 draft ANA support v4 Christoph Hellwig
2018-06-11 14:11 ` [PATCH 01/10] nvme: don't rely on the changed namespace list log Christoph Hellwig
2018-06-12 6:02 ` Hannes Reinecke
2018-06-11 14:11 ` [PATCH 02/10] nvme.h: add support for the log specific field Christoph Hellwig
2018-06-11 14:11 ` [PATCH 03/10] nvme.h: add ANA definitions Christoph Hellwig
2018-06-11 14:11 ` [PATCH 04/10] nvme: simplify the API for getting log pages Christoph Hellwig
2018-06-11 14:11 ` [PATCH 05/10] nvme: remove nvme_req_needs_failover Christoph Hellwig
2018-06-11 14:11 ` [PATCH 06/10] nvme: add ANA support Christoph Hellwig
2018-06-12 8:45 ` Hannes Reinecke
2018-06-13 7:38 ` Christoph Hellwig [this message]
2018-06-11 14:11 ` [PATCH 07/10] nvmet: keep a port pointer in nvmet_ctrl Christoph Hellwig
2018-06-12 6:02 ` Hannes Reinecke
2018-06-11 14:11 ` [PATCH 08/10] nvmet: track and limit the number of namespaces per subsystem Christoph Hellwig
2018-06-11 14:11 ` [PATCH 09/10] nvmet: add minimal ANA support Christoph Hellwig
2018-06-11 14:11 ` [PATCH 10/10] nvmet: support configuring ANA groups Christoph Hellwig
2018-06-12 6:08 ` Hannes Reinecke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180613073859.GA22633@lst.de \
--to=hch@lst.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.