From: David Disseldorp <ddiss@suse.de>
To: target-devel@vger.kernel.org
Subject: Re: [PATCH] lib/percpu_ida.c: don't do alloc from per-CPU list if there is none
Date: Wed, 13 Jun 2018 09:43:44 +0000 [thread overview]
Message-ID: <20180613114344.7900693c@suse.de> (raw)
In-Reply-To: <20180613075830.c3zeva52fuj6fxxv@linutronix.de>
On Wed, 13 Jun 2018 09:58:30 +0200, Sebastian Andrzej Siewior wrote:
> In commit 804209d8a009 ("lib/percpu_ida.c: use _irqsave() instead of
> local_irq_save() + spin_lock") I inlined alloc_local_tag() and mixed up
> the >= check from percpu_ida_alloc() with the one in alloc_local_tag().
>
> Don't alloc from per-CPU freelist if ->nr_free is zero.
>
> Fixes: 804209d8a009 ("lib/percpu_ida.c: use _irqsave() instead of local_irq_save() + spin_lock")
> Reported-by: David Disseldorp <ddiss@suse.de>
> Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
> ---
>
> David, could please check if this works for you?
Works for me. Thanks for the quick fix, Sebastian.
Cheers, David
prev parent reply other threads:[~2018-06-13 9:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-13 7:58 [PATCH] lib/percpu_ida.c: don't do alloc from per-CPU list if there is none Sebastian Andrzej Siewior
2018-06-13 9:43 ` David Disseldorp [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180613114344.7900693c@suse.de \
--to=ddiss@suse.de \
--cc=target-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.