From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.kernel.org ([198.145.29.99]:42640 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934619AbeFMQnL (ORCPT ); Wed, 13 Jun 2018 12:43:11 -0400 Date: Wed, 13 Jun 2018 18:42:48 +0200 From: Greg KH To: Nate Clark Cc: stable@vger.kernel.org Subject: Re: Backport bonding patches to fix active-passive in 4.9 Message-ID: <20180613164248.GA19257@kroah.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: stable-owner@vger.kernel.org List-ID: On Wed, Jun 13, 2018 at 12:28:38PM -0400, Nate Clark wrote: > Hi, > > On the latest 4.9 stable active-passive bonding does not always > failover to the passive slave when carrier is lost on the active > slave. It seems that the issue stems from the backport of > c4adfc822bf5d8e97660b6114b5a8892530ce8cb, bonding: make speed, duplex > setting consistent with link state. There were subsequent patches > which resolved issues with the change to bond_update_speed_duplex > which were not backported. The three commits which seem to resolve the > issue are b5bf0f5b16b9c316c34df9f31d4be8729eb86845, > 3f3c278c94dd994fe0d9f21679ae19b9c0a55292 and > ad729bc9acfb7c47112964b4877ef5404578ed13. There are other commits in > mainline which also revolve around > c4adfc822bf5d8e97660b6114b5a8892530ce8cb but are not necessary to > resolving the active-passive failover problems. > > Would it be possible to queue up the three commits for backporting to > 4.9 stable: > b5bf0f5b16b9c316c34df9f31d4be8729eb86845 bonding: correctly update > link status during mii-commit > 3f3c278c94dd994fe0d9f21679ae19b9c0a55292 bonding: fix active-backup transition > ad729bc9acfb7c47112964b4877ef5404578ed13 bonding: require speed/duplex > only for 802.3ad, alb and tlb > > All of those commits apply cleanly to 4.9.107. All look reasonable, now queued up, thanks. greg k-h