All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Imre Deak <imre.deak@intel.com>
Cc: Vandita Kulkarni <vandita.kulkarni@intel.com>,
	intel-gfx@lists.freedesktop.org,
	Paulo Zanoni <paulo.r.zanoni@intel.com>
Subject: Re: [PATCH 5/5] drm/i915/ddi: Removed unused var from hsw_write_infoframe()
Date: Wed, 13 Jun 2018 20:51:48 +0300	[thread overview]
Message-ID: <20180613175148.GQ23723@intel.com> (raw)
In-Reply-To: <20180613170710.15080-6-imre.deak@intel.com>

On Wed, Jun 13, 2018 at 08:07:10PM +0300, Imre Deak wrote:
> Cc: Vandita Kulkarni <vandita.kulkarni@intel.com>
> Cc: Paulo Zanoni <paulo.r.zanoni@intel.com>
> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Signed-off-by: Imre Deak <imre.deak@intel.com>

Looks like I forgot to remove it in ffc85daba535 ("drm/i915: 
Fix AVI/HDMI/SPD infoframes on HSW+")

Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

> ---
>  drivers/gpu/drm/i915/intel_hdmi.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/intel_hdmi.c b/drivers/gpu/drm/i915/intel_hdmi.c
> index 29d586f5cedb..bd928e83dfc7 100644
> --- a/drivers/gpu/drm/i915/intel_hdmi.c
> +++ b/drivers/gpu/drm/i915/intel_hdmi.c
> @@ -390,14 +390,11 @@ static void hsw_write_infoframe(struct drm_encoder *encoder,
>  	struct drm_i915_private *dev_priv = to_i915(dev);
>  	enum transcoder cpu_transcoder = crtc_state->cpu_transcoder;
>  	i915_reg_t ctl_reg = HSW_TVIDEO_DIP_CTL(cpu_transcoder);
> -	i915_reg_t data_reg;
>  	int data_size = type == DP_SDP_VSC ?
>  		VIDEO_DIP_VSC_DATA_SIZE : VIDEO_DIP_DATA_SIZE;
>  	int i;
>  	u32 val = I915_READ(ctl_reg);
>  
> -	data_reg = hsw_dip_data_reg(dev_priv, cpu_transcoder, type, 0);
> -
>  	val &= ~hsw_infoframe_enable(type);
>  	I915_WRITE(ctl_reg, val);
>  
> -- 
> 2.13.2

-- 
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2018-06-13 17:51 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-13 17:07 [PATCH 0/5] drm/i915/icl: Fix HDMI infoframe setting Imre Deak
2018-06-13 17:07 ` [PATCH 1/5] drm/i915/ddi: s/crtc->config/old_crtc_state in haswell_crtc_disable() Imre Deak
2018-06-13 17:43   ` Ville Syrjälä
2018-06-13 17:07 ` [PATCH 2/5] drm/i915/ddi: Push pipe clock enabling to encoders Imre Deak
2018-06-13 17:27   ` [PATCH v2 " Imre Deak
2018-06-13 17:46     ` Ville Syrjälä
2018-06-13 17:07 ` [PATCH 3/5] drm/i915/ddi: Check transcoder instead of port when setting HDMI infoframe Imre Deak
2018-06-13 17:47   ` Ville Syrjälä
2018-06-13 17:07 ` [PATCH 4/5] drm/i915/ddi: Set HDMI infoframes with pipe clocks enabled Imre Deak
2018-06-13 17:49   ` Ville Syrjälä
2018-06-13 17:07 ` [PATCH 5/5] drm/i915/ddi: Removed unused var from hsw_write_infoframe() Imre Deak
2018-06-13 17:51   ` Ville Syrjälä [this message]
2018-06-13 17:13 ` ✗ Fi.CI.BAT: failure for drm/i915/icl: Fix HDMI infoframe setting Patchwork
2018-06-13 18:02 ` ✓ Fi.CI.BAT: success for drm/i915/icl: Fix HDMI infoframe setting (rev2) Patchwork
2018-06-13 22:03 ` ✓ Fi.CI.IGT: " Patchwork
2018-06-14 17:32   ` Imre Deak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180613175148.GQ23723@intel.com \
    --to=ville.syrjala@linux.intel.com \
    --cc=imre.deak@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=paulo.r.zanoni@intel.com \
    --cc=vandita.kulkarni@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.