All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Cc: Vito Caputo <vcaputo@pengaru.com>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: Allow DBLSCAN user modes with eDP/LVDS/DSI
Date: Wed, 13 Jun 2018 21:11:37 +0300	[thread overview]
Message-ID: <20180613181137.GS23723@intel.com> (raw)
In-Reply-To: <ac51ae62-eb08-c206-4d91-32fdc4d45455@linux.intel.com>

On Wed, Jun 13, 2018 at 04:48:29PM +0200, Maarten Lankhorst wrote:
> Op 24-05-18 om 14:54 schreef Ville Syrjala:
> > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> >
> > When encountering a connector with the scaling mode property both
> > intel and modesetting ddxs sometimes add tons of DBLSCAN modes
> > to the output's mode list. The idea presumably being that since the
> > output will be going through the panel fitter anyway we can pretend
> > to use any kind of mode.
> >
> > Sadly that means we can't reject user modes with the DBLSCAN flag
> > until we know whether we're going to be using the panel's native
> > mode or the user mode directly. Doing otherwise means X clients using
> > xf86vidmode/xrandr will get a protocol error (and often self
> > terminate as a result) when the kernel refuses to use the requested
> > mode with the DBLSCAN flag.
> >
> > To undo the regression we'll move the DBLSCAN checks into the
> > connector->mode_valid() and encoder->compute_config() hooks.
> >
> > Cc: Vito Caputo <vcaputo@pengaru.com>
> > Reported-by: Vito Caputo <vcaputo@pengaru.com>
> > Fixes: e995ca0b8139 ("drm/i915: Provide a device level .mode_valid() hook")
> > References: https://lkml.org/lkml/2018/5/21/715
> > Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > ---
<snip> 
> 
> Reviewed-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>

Thanks. Pushed to dinq with
Cc: stable@vger.kernel.org
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=106804
Tested-by: Arkadiusz Miskiewicz <arekm@maven.pl>

-- 
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

      reply	other threads:[~2018-06-13 18:11 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-24 12:54 [PATCH] drm/i915: Allow DBLSCAN user modes with eDP/LVDS/DSI Ville Syrjala
2018-05-24 14:14 ` ✓ Fi.CI.BAT: success for " Patchwork
2018-05-24 16:30 ` ✗ Fi.CI.IGT: failure " Patchwork
2018-06-13 17:56   ` Ville Syrjälä
2018-06-13 14:48 ` [PATCH] " Maarten Lankhorst
2018-06-13 18:11   ` Ville Syrjälä [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180613181137.GS23723@intel.com \
    --to=ville.syrjala@linux.intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=vcaputo@pengaru.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.