From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,T_DKIMWL_WL_HIGH autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by aws-us-west-2-korg-lkml-1.web.codeaurora.org (Postfix) with ESMTP id 4A929C004E4 for ; Wed, 13 Jun 2018 18:22:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id F3174208D7 for ; Wed, 13 Jun 2018 18:22:10 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="vP/sAfkm" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F3174208D7 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935587AbeFMSWC (ORCPT ); Wed, 13 Jun 2018 14:22:02 -0400 Received: from mail.kernel.org ([198.145.29.99]:42678 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S935352AbeFMSWA (ORCPT ); Wed, 13 Jun 2018 14:22:00 -0400 Received: from localhost (LFbn-1-12247-202.w90-92.abo.wanadoo.fr [90.92.61.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 8C657208CD; Wed, 13 Jun 2018 18:21:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1528914120; bh=aZFQvNucKirq2N1GHGfoIMpyx+roDfTtj1tcoVu7BXs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=vP/sAfkmZmu4wDYOUIOS2uwmfz5ULKbnykHT3nySmhoPp1XfLSRHi7m7ZrSRXXQRi 7G/CQu/+tAr+C2JJYAIfaC4vwyhW9+URHA0CFQY+xNsTQi/eOuoZ6TdJ4LmoWIgheu ypsw6U/e+HnCrNceb4pE21Af4Bps3QDltyURlBY0= Date: Wed, 13 Jun 2018 20:21:37 +0200 From: Greg Kroah-Hartman To: Nadav Amit Cc: Xavier Deguillard , linux-kernel@vger.kernel.org, Arnd Bergmann Subject: Re: [PATCH 3/7] vmw_balloon: fix inflation of 64-bit GFNs Message-ID: <20180613182137.GC29631@kroah.com> References: <20180613110359.109033-1-namit@vmware.com> <20180613110359.109033-4-namit@vmware.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180613110359.109033-4-namit@vmware.com> User-Agent: Mutt/1.10.0 (2018-05-17) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jun 13, 2018 at 04:03:55AM -0700, Nadav Amit wrote: > When balloon batching is not supported by the hypervisor, the guest > frame number (GFN) must fit in 32-bit. However, due to a bug, this check > was mistakenly ignored. In practice, when total RAM is greater than > 16TB, the balloon does not work currently, making this bug unlikely to > happen. > > Fixes: ef0f8f112984 ("VMware balloon: partially inline > vmballoon_reserve_page.") > Why have a bugfix as the 3rd patch of the series? Please put it first, so that it can get into Linus's tree sooner. Also, no need to line-wrap this, and drop the blank line. And finally, does this need to go to the stable kernels? If so, please add the correct line for that. thanks, greg k-h