All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Adrian Hunter <adrian.hunter@intel.com>
Cc: Jiri Olsa <jolsa@redhat.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] perf intel-pt: Fix packet decoding of CYC packets
Date: Wed, 13 Jun 2018 17:02:36 -0300	[thread overview]
Message-ID: <20180613200236.GG2686@kernel.org> (raw)
In-Reply-To: <1528371002-8862-1-git-send-email-adrian.hunter@intel.com>

Em Thu, Jun 07, 2018 at 02:30:02PM +0300, Adrian Hunter escreveu:
> Use a 64-bit type so that the cycle count is not limited to 32-bits.
> 
> Signed-off-by: Adrian Hunter <adrian.hunter@intel.com>
> Cc: stable@vger.kernel.org

Thanks, applied.

- Arnaldo

> ---
>  tools/perf/util/intel-pt-decoder/intel-pt-pkt-decoder.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/perf/util/intel-pt-decoder/intel-pt-pkt-decoder.c b/tools/perf/util/intel-pt-decoder/intel-pt-pkt-decoder.c
> index ba4c9dd18643..d426761a549d 100644
> --- a/tools/perf/util/intel-pt-decoder/intel-pt-pkt-decoder.c
> +++ b/tools/perf/util/intel-pt-decoder/intel-pt-pkt-decoder.c
> @@ -366,7 +366,7 @@ static int intel_pt_get_cyc(unsigned int byte, const unsigned char *buf,
>  		if (len < offs)
>  			return INTEL_PT_NEED_MORE_BYTES;
>  		byte = buf[offs++];
> -		payload |= (byte >> 1) << shift;
> +		payload |= ((uint64_t)byte >> 1) << shift;
>  	}
>  
>  	packet->type = INTEL_PT_CYC;
> -- 
> 1.9.1

  reply	other threads:[~2018-06-13 20:02 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-07 11:30 [PATCH] perf intel-pt: Fix packet decoding of CYC packets Adrian Hunter
2018-06-13 20:02 ` Arnaldo Carvalho de Melo [this message]
2018-06-26  6:54 ` [tip:perf/urgent] " tip-bot for Adrian Hunter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180613200236.GG2686@kernel.org \
    --to=acme@kernel.org \
    --cc=adrian.hunter@intel.com \
    --cc=jolsa@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.