From: Eduardo Habkost <ehabkost@redhat.com>
To: Junyan He <junyan.he@gmx.com>
Cc: Igor Mammedov <imammedo@redhat.com>,
Haozhong Zhang <haozhong.zhang@intel.com>,
"xiaoguangrong.eric@gmail.com" <xiaoguangrong.eric@gmail.com>,
"crosthwaite.peter@gmail.com" <crosthwaite.peter@gmail.com>,
"mst@redhat.com" <mst@redhat.com>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
"dgilbert@redhat.com" <dgilbert@redhat.com>,
"quintela@redhat.com" <quintela@redhat.com>,
Junyan He <junyan.he@intel.com>,
"stefanha@redhat.com" <stefanha@redhat.com>,
"pbonzini@redhat.com" <pbonzini@redhat.com>,
"rth@twiddle.net" <rth@twiddle.net>
Subject: Re: [Qemu-devel] [PATCH V6 0/7] nvdimm: guarantee persistence of QEMU writes to persistent memory
Date: Wed, 13 Jun 2018 17:05:34 -0300 [thread overview]
Message-ID: <20180613200534.GL7451@localhost.localdomain> (raw)
In-Reply-To: <HK2PR06MB0531F10A69CBFC1D41402F19EB7F0@HK2PR06MB0531.apcprd06.prod.outlook.com>
On Tue, Jun 12, 2018 at 01:38:08PM +0000, Junyan He wrote:
> He have pmem_persist and pmem_memcpy_persist stub functions.
>
> If no libpmem and user really specify pmem=on, we just do nothing or just memcpy.
>
> Real persistent memory always require libpmem support its load/save.
>
> If pmem=on and without libpmem, we can think that user want to imitate
>
> pmem=on while the HW environment is without real persistent memory existing.
>
> It may help debug on some machine without real pmem.
What exactly it would help debug? Is there any difference
between testing the code with pmem=off and pmem=on if libptest is
unavailable?
I would prefer to simply not let the user set pmem=on if libptest
is not available.
--
Eduardo
prev parent reply other threads:[~2018-06-13 20:05 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-01 8:10 [Qemu-devel] [PATCH V6 0/7] nvdimm: guarantee persistence of QEMU writes to persistent memory junyan.he
2018-06-01 8:10 ` [Qemu-devel] [PATCH V6 1/7] memory, exec: Expose all memory block related flags junyan.he
2018-06-05 11:38 ` Stefan Hajnoczi
2018-06-01 8:10 ` [Qemu-devel] [PATCH V6 2/7] memory, exec: switch file ram allocation functions to 'flags' parameters junyan.he
2018-06-05 11:40 ` Stefan Hajnoczi
2018-06-11 15:53 ` Igor Mammedov
2018-06-01 8:10 ` [Qemu-devel] [PATCH V6 3/7] hostmem-file: add the 'pmem' option junyan.he
2018-06-05 11:44 ` Stefan Hajnoczi
2018-06-11 16:02 ` Igor Mammedov
2018-06-01 8:10 ` [Qemu-devel] [PATCH V6 4/7] configure: add libpmem support junyan.he
2018-06-05 11:41 ` Stefan Hajnoczi
2018-06-01 8:10 ` [Qemu-devel] [PATCH V6 5/7] mem/nvdimm: ensure write persistence to PMEM in label emulation junyan.he
2018-06-05 11:44 ` Stefan Hajnoczi
2018-06-01 8:10 ` [Qemu-devel] [PATCH V6 6/7] migration/ram: Add check and info message to nvdimm post copy junyan.he
2018-06-05 11:44 ` Stefan Hajnoczi
2018-06-01 8:10 ` [Qemu-devel] [PATCH V6 7/7] migration/ram: ensure write persistence on loading all data to PMEM junyan.he
2018-06-05 11:44 ` Stefan Hajnoczi
2018-06-07 10:42 ` Dr. David Alan Gilbert
2018-06-01 8:27 ` [Qemu-devel] [PATCH V6 0/7] nvdimm: guarantee persistence of QEMU writes to persistent memory no-reply
2018-06-07 13:50 ` Stefan Hajnoczi
2018-06-01 8:33 ` no-reply
2018-06-12 12:06 ` Igor Mammedov
2018-06-12 13:38 ` Junyan He
2018-06-12 14:55 ` Igor Mammedov
2018-06-12 15:27 ` Junyan He
2018-06-12 15:43 ` Junyan He
2018-06-13 15:58 ` Igor Mammedov
2018-06-13 20:05 ` Eduardo Habkost [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180613200534.GL7451@localhost.localdomain \
--to=ehabkost@redhat.com \
--cc=crosthwaite.peter@gmail.com \
--cc=dgilbert@redhat.com \
--cc=haozhong.zhang@intel.com \
--cc=imammedo@redhat.com \
--cc=junyan.he@gmx.com \
--cc=junyan.he@intel.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=rth@twiddle.net \
--cc=stefanha@redhat.com \
--cc=xiaoguangrong.eric@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.