From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [v2] Fixed a checkpatch error From: Greg Kroah-Hartman Message-Id: <20180614064229.GA12429@kroah.com> Date: Thu, 14 Jun 2018 08:42:29 +0200 To: Parth Y Shah Cc: balbi@kernel.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org List-ID: T24gVGh1LCBKdW4gMTQsIDIwMTggYXQgMTI6MDI6NDZQTSArMDUzMCwgUGFydGggWSBTaGFoIHdy b3RlOgo+IEVSUk9SOiBjb2RlIGluZGVudCBzaG91bGQgdXNlIHRhYnMgd2hlcmUgcG9zc2libGUK PiAKPiBIZXJlLCBzcGFjZXMgYXJlIHJlcGxhY2VkIGJ5IGEgdGFiIGluIDIgbGluZXMuCj4gCj4g U2lnbmVkLW9mZi1ieTogUGFydGggWSBTaGFoIDxzcGFydGgxMjkyQGdtYWlsLmNvbT4KCllvdXIg c3ViamVjdCBsaW5lIG5lZWRzIHdvcmssIHBsZWFzZSBzZWUgaG93IG90aGVyIHN1YmplY3QgbGlu ZXMgYXJlCmNvbXBvc2VkIGZvciB0aGlzIHN1YnN5c3RlbS4KCkFsc28gbm90ZSwgcGxlYXNlIGRv IG5vdCB1c2UgYW55dGhpbmcgYnV0IHRoZSBkcml2ZXJzL3N0YWdpbmcvIGFyZWEgb2YKdGhlIGtl cm5lbCBmb3IgYmVnaW5uaW5nICJJJ20gZ29pbmcgdG8gZG8gY2hlY2twYXRjaCBjbGVhbnVwcyIg dHlwZSBvZgoibGVhcm5pbmcgdG8gZ2V0IGNoYW5nZXMgaW50byB0aGUga2VybmVsIiB3b3JrLiAg VGhhdCBpcyBhIGdyZWF0IHBsYWNlCnRvIHN0YXJ0IHdpdGggdGhpcywgbm90IGluIG90aGVyIHN1 YnN5c3RlbXMgd2hlcmUgeW91IG1pZ2h0IGhhdmUKcmV2aWV3ZXJzIHdobyBkbyBub3QgY2FyZSBz byBtdWNoIGFib3V0IHdoaXRlc3BhY2UgY2xlYW51cHMgbGlrZSB0aGlzLgoKU28gcGxlYXNlIGxl YXJuIHRoZSBwcm9jZXNzIHRoZXJlLCBhbmQgd2hlbiB5b3UgaGF2ZSBpdCBhbGwgd29ya2luZwp3 ZWxsLCB0aGVuIHlvdSBjb3VsZCBtb3ZlIG9uIHRvIG90aGVyIHN1YnN5c3RlbXMgYW5kIGFyZWFz IG9mIHRoZQprZXJuZWwsIGxpa2UgdGhpcyBvbmUsIGlmIHlvdSB3YW50IHRvLgoKdGhhbmtzLAoK Z3JlZyBrLWgKLS0tClRvIHVuc3Vic2NyaWJlIGZyb20gdGhpcyBsaXN0OiBzZW5kIHRoZSBsaW5l ICJ1bnN1YnNjcmliZSBsaW51eC11c2IiIGluCnRoZSBib2R5IG9mIGEgbWVzc2FnZSB0byBtYWpv cmRvbW9Admdlci5rZXJuZWwub3JnCk1vcmUgbWFqb3Jkb21vIGluZm8gYXQgIGh0dHA6Ly92Z2Vy Lmtlcm5lbC5vcmcvbWFqb3Jkb21vLWluZm8uaHRtbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,T_DKIMWL_WL_HIGH autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by aws-us-west-2-korg-lkml-1.web.codeaurora.org (Postfix) with ESMTP id D169BC07D5C for ; Thu, 14 Jun 2018 06:42:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 85352208CB for ; Thu, 14 Jun 2018 06:42:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="vGa4vBoA" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 85352208CB Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753011AbeFNGmz (ORCPT ); Thu, 14 Jun 2018 02:42:55 -0400 Received: from mail.kernel.org ([198.145.29.99]:50094 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752765AbeFNGmy (ORCPT ); Thu, 14 Jun 2018 02:42:54 -0400 Received: from localhost (LFbn-1-12247-202.w90-92.abo.wanadoo.fr [90.92.61.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 371D0208CB; Thu, 14 Jun 2018 06:42:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1528958573; bh=952a7zewhQwc3UX+Vh5vvahSfthqdp4bW7St1GDj0uA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=vGa4vBoA9I1YVQ0GFk5jX3Tj/Jqdbtyba/pcrHsMKaf9LCiGJNJvTZhcjfQHbkGgH 2hxf2/Hcj2AQvfC9iP22pkpsFJZ0L2xL43DOZBJRENcuIVWkgWa0KQW1xHu6DhhQeJ WlgeQSlNbApZb4GT80+FxGWRiApt+7K4qvzO7qmY= Date: Thu, 14 Jun 2018 08:42:29 +0200 From: Greg KH To: Parth Y Shah Cc: balbi@kernel.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] Fixed a checkpatch error Message-ID: <20180614064229.GA12429@kroah.com> References: <1528957966-24707-1-git-send-email-sparth1292@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1528957966-24707-1-git-send-email-sparth1292@gmail.com> User-Agent: Mutt/1.10.0 (2018-05-17) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jun 14, 2018 at 12:02:46PM +0530, Parth Y Shah wrote: > ERROR: code indent should use tabs where possible > > Here, spaces are replaced by a tab in 2 lines. > > Signed-off-by: Parth Y Shah Your subject line needs work, please see how other subject lines are composed for this subsystem. Also note, please do not use anything but the drivers/staging/ area of the kernel for beginning "I'm going to do checkpatch cleanups" type of "learning to get changes into the kernel" work. That is a great place to start with this, not in other subsystems where you might have reviewers who do not care so much about whitespace cleanups like this. So please learn the process there, and when you have it all working well, then you could move on to other subsystems and areas of the kernel, like this one, if you want to. thanks, greg k-h