From: hch@lst.de (Christoph Hellwig)
Subject: [PATCH 1/4] nvme-fabrics: refactor queue ready check
Date: Thu, 14 Jun 2018 14:19:15 +0200 [thread overview]
Message-ID: <20180614121915.GA27209@lst.de> (raw)
In-Reply-To: <f3264852-771e-864c-a57d-cb33a55ca768@broadcom.com>
On Wed, Jun 13, 2018@08:54:25AM -0700, James Smart wrote:
> When I finally finished with the review on your last patch:
> [PATCH 4/4] nvme-fabrics: reverse polarity in __nvmf_check_ready
>
> I think you had addressed this issue so the patch below isn't necessary.
Even with patch 4 we'd still allow kernel-generated connect commands
in non-new, non-connecting states. We should not generally send them,
so I think the series as-is should be ok, but if touch all this code
we might as well handle that case as well.
next prev parent reply other threads:[~2018-06-14 12:19 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-11 15:46 queue ready fixes and cleanups Christoph Hellwig
2018-06-11 15:46 ` [PATCH 1/4] nvme-fabrics: refactor queue ready check Christoph Hellwig
2018-06-12 8:23 ` Johannes Thumshirn
2018-06-12 21:45 ` James Smart
2018-06-13 8:16 ` Christoph Hellwig
2018-06-13 15:54 ` James Smart
2018-06-14 12:19 ` Christoph Hellwig [this message]
2018-06-13 19:48 ` James Smart
2018-06-11 15:46 ` [PATCH 2/4] nvme-fabrics: handle queue ready fast path inline Christoph Hellwig
2018-06-12 8:24 ` Johannes Thumshirn
2018-06-12 21:47 ` James Smart
2018-06-11 15:46 ` [PATCH 3/4] nvme-fabrics: handle the admin-only case properly in nvmf_check_ready Christoph Hellwig
2018-06-12 8:25 ` Johannes Thumshirn
2018-06-12 21:48 ` James Smart
2018-06-13 7:59 ` Christoph Hellwig
2018-06-11 15:46 ` [PATCH 4/4] nvme-fabrics: reverse polarity in __nvmf_check_ready Christoph Hellwig
2018-06-12 8:26 ` Johannes Thumshirn
2018-06-12 11:08 ` Hannes Reinecke
2018-06-12 22:22 ` James Smart
2018-06-12 22:05 ` James Smart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180614121915.GA27209@lst.de \
--to=hch@lst.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.