From: Kalle Valo <kvalo@codeaurora.org>
To: Brian Norris <briannorris@chromium.org>
Cc: Kalle Valo <kvalo@qca.qualcomm.com>,
ath10k@lists.infradead.org, linux-wireless@vger.kernel.org,
Govind Singh <govinds@codeaurora.org>,
<linux-kernel@vger.kernel.org>,
Brian Norris <briannorris@chromium.org>
Subject: Re: [1/4] ath10k: snoc: use correct bus-specific pointer in RX retry
Date: Thu, 14 Jun 2018 15:16:47 +0000 (UTC) [thread overview]
Message-ID: <20180614151647.26CB36022C@smtp.codeaurora.org> (raw)
In-Reply-To: <20180611210946.241341-1-briannorris@chromium.org>
Brian Norris <briannorris@chromium.org> wrote:
> We're 'ath10k_snoc', not 'ath10k_pci'. This probably means we're
> accessing junk data in ath10k_snoc_rx_replenish_retry(), unless
> 'ath10k_snoc' and 'ath10k_pci' happen to have very similar struct
> layouts.
>
> Noticed by inspection.
>
> Fixes: d915105231ca ("ath10k: add hif rx methods for wcn3990")
> Signed-off-by: Brian Norris <briannorris@chromium.org>
> Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
4 patches applied to ath-next branch of ath.git, thanks.
426a0f0b5a2f ath10k: snoc: use correct bus-specific pointer in RX retry
8ac5fe8e3d11 ath10k: snoc: stop including pci.h
13e6cc0bd4ef ath10k: snoc: drop unused WCN3990_CE_ATTR_FLAGS
c9f3e7fa8bcb ath10k: snoc: sort include files
--
https://patchwork.kernel.org/patch/10458863/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
prev parent reply other threads:[~2018-06-14 15:16 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-11 21:09 [PATCH 1/4] ath10k: snoc: use correct bus-specific pointer in RX retry Brian Norris
2018-06-11 21:09 ` Brian Norris
2018-06-11 21:09 ` [PATCH 2/4] ath10k: snoc: stop including pci.h Brian Norris
2018-06-11 21:09 ` Brian Norris
2018-06-11 21:09 ` [PATCH 3/4] ath10k: snoc: drop unused WCN3990_CE_ATTR_FLAGS Brian Norris
2018-06-11 21:09 ` Brian Norris
2018-06-11 21:09 ` [PATCH 4/4] ath10k: snoc: sort include files Brian Norris
2018-06-11 21:09 ` Brian Norris
2018-06-12 11:22 ` [PATCH 1/4] ath10k: snoc: use correct bus-specific pointer in RX retry Kalle Valo
2018-06-12 11:22 ` Kalle Valo
2018-06-14 15:16 ` [1/4] " Kalle Valo
2018-06-14 15:16 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180614151647.26CB36022C@smtp.codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=ath10k@lists.infradead.org \
--cc=briannorris@chromium.org \
--cc=govinds@codeaurora.org \
--cc=kvalo@qca.qualcomm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.