From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rodrigo Vivi Subject: Re: [PATCH v4 2/5] drm/i915/psr: Begin to handle PSR/PSR2 errors set by sink Date: Thu, 14 Jun 2018 14:09:34 -0700 Message-ID: <20180614210934.GW8374@intel.com> References: <20180614203433.5602-1-jose.souza@intel.com> <20180614203433.5602-2-jose.souza@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by gabe.freedesktop.org (Postfix) with ESMTPS id B45516E8FA for ; Thu, 14 Jun 2018 21:09:36 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20180614203433.5602-2-jose.souza@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: =?iso-8859-1?Q?Jos=E9?= Roberto de Souza Cc: intel-gfx@lists.freedesktop.org, Dhinakaran Pandiyan List-Id: intel-gfx@lists.freedesktop.org T24gVGh1LCBKdW4gMTQsIDIwMTggYXQgMDE6MzQ6MzBQTSAtMDcwMCwgSm9zw6kgUm9iZXJ0byBk ZSBTb3V6YSB3cm90ZToKPiBlRFAgc3BlYyBzdGF0ZXMgdGhhdCBzaW5rIGRldmljZSB3aWxsIGRv IGEgc2hvcnQgcHVsc2UgaW4gSFBECj4gbGluZSB3aGVuIHRoZXJlIGlzIGEgUFNSL1BTUjIgZXJy b3IgdGhhdCBuZWVkcyB0byBiZSBoYW5kbGVkIGJ5Cj4gc291cmNlLCB0aGlzIGlzIGhhbmRsaW5n IHRoZSBmaXJzdCBhbmQgbW9zdCBzaW1wbGVzIGVycm9yOgo+IERQX1BTUl9TSU5LX0lOVEVSTkFM X0VSUk9SLgo+IAo+IEhlcmUgdGFraW5nIHRoZSBzYWZlc3QgYXBwcm9hY2ggYW5kIGRpc2FibGlu ZyBQU1IoYXQgbGVhc3QgdW50aWwKPiB0aGUgbmV4dCBtb2Rlc2V0KSwgdG8gYXZvaWQgbXVsdGlw bGUgcmVuZGVyaW5nIGlzc3VlcyBkdWUgdG8KPiBiYWQgcGFubmVscy4KPiAKPiB2NDoKPiBVc2lu ZyBDQU5fUFNSIGluc3RlYWQgb2YgSEFTX1BTUiBpbiBpbnRlbF9wc3Jfc2hvcnRfcHVsc2UKPiAK PiB2MzoKPiBkaXNhYmxpbmcgUFNSIGluc3RlYWQgb2YgZXhpdGluZyBvbiBlcnJvcgo+IAo+IENj OiBEaGluYWthcmFuIFBhbmRpeWFuIDxkaGluYWthcmFuLnBhbmRpeWFuQGludGVsLmNvbT4KPiBD YzogUm9kcmlnbyBWaXZpIDxyb2RyaWdvLnZpdmlAaW50ZWwuY29tPgo+IFNpZ25lZC1vZmYtYnk6 IEpvc8OpIFJvYmVydG8gZGUgU291emEgPGpvc2Uuc291emFAaW50ZWwuY29tPgo+IC0tLQo+ICBk cml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcC5jICB8ICAyICsrCj4gIGRyaXZlcnMvZ3B1L2Ry bS9pOTE1L2ludGVsX2Rydi5oIHwgIDEgKwo+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9w c3IuYyB8IDYwICsrKysrKysrKysrKysrKysrKysrKysrKysrLS0tLS0tCj4gIDMgZmlsZXMgY2hh bmdlZCwgNTIgaW5zZXJ0aW9ucygrKSwgMTEgZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAtLWdpdCBh L2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RwLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9p bnRlbF9kcC5jCj4gaW5kZXggNjc4NzViMDBjOGRmLi4xOTU4NTUyM2U0Y2UgMTAwNjQ0Cj4gLS0t IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHAuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2Ry bS9pOTE1L2ludGVsX2RwLmMKPiBAQCAtNDQ3NCw2ICs0NDc0LDggQEAgaW50ZWxfZHBfc2hvcnRf cHVsc2Uoc3RydWN0IGludGVsX2RwICppbnRlbF9kcCkKPiAgCWlmIChpbnRlbF9kcF9uZWVkc19s aW5rX3JldHJhaW4oaW50ZWxfZHApKQo+ICAJCXJldHVybiBmYWxzZTsKPiAgCj4gKwlpbnRlbF9w c3Jfc2hvcnRfcHVsc2UoaW50ZWxfZHApOwo+ICsKPiAgCWlmIChpbnRlbF9kcC0+Y29tcGxpYW5j ZS50ZXN0X3R5cGUgPT0gRFBfVEVTVF9MSU5LX1RSQUlOSU5HKSB7Cj4gIAkJRFJNX0RFQlVHX0tN UygiTGluayBUcmFpbmluZyBDb21wbGlhbmNlIFRlc3QgcmVxdWVzdGVkXG4iKTsKPiAgCQkvKiBT ZW5kIGEgSG90cGx1ZyBVZXZlbnQgdG8gdXNlcnNwYWNlIHRvIHN0YXJ0IG1vZGVzZXQgKi8KPiBk aWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHJ2LmggYi9kcml2ZXJzL2dw dS9kcm0vaTkxNS9pbnRlbF9kcnYuaAo+IGluZGV4IDg4NDAxMDg3NDlhNS4uYmI2ZmZkYjI4MmZk IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rydi5oCj4gKysrIGIv ZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHJ2LmgKPiBAQCAtMTkyNiw2ICsxOTI2LDcgQEAg dm9pZCBpbnRlbF9wc3JfY29tcHV0ZV9jb25maWcoc3RydWN0IGludGVsX2RwICppbnRlbF9kcCwK PiAgCQkJICAgICAgc3RydWN0IGludGVsX2NydGNfc3RhdGUgKmNydGNfc3RhdGUpOwo+ICB2b2lk IGludGVsX3Bzcl9pcnFfY29udHJvbChzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYs IGJvb2wgZGVidWcpOwo+ICB2b2lkIGludGVsX3Bzcl9pcnFfaGFuZGxlcihzdHJ1Y3QgZHJtX2k5 MTVfcHJpdmF0ZSAqZGV2X3ByaXYsIHUzMiBwc3JfaWlyKTsKPiArdm9pZCBpbnRlbF9wc3Jfc2hv cnRfcHVsc2Uoc3RydWN0IGludGVsX2RwICppbnRlbF9kcCk7Cj4gIAo+ICAvKiBpbnRlbF9ydW50 aW1lX3BtLmMgKi8KPiAgaW50IGludGVsX3Bvd2VyX2RvbWFpbnNfaW5pdChzdHJ1Y3QgZHJtX2k5 MTVfcHJpdmF0ZSAqKTsKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxf cHNyLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9wc3IuYwo+IGluZGV4IGJjNmQ1NGY2 NzdkYy4uYWY1ZmNmZDk4YTUzIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2lu dGVsX3Bzci5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcHNyLmMKPiBAQCAt NzIwLDYgKzcyMCwyMyBAQCBzdGF0aWMgdm9pZCBoc3dfcHNyX2Rpc2FibGUoc3RydWN0IGludGVs X2RwICppbnRlbF9kcCkKPiAgCXBzcl9hdXhfaW9fcG93ZXJfcHV0KGludGVsX2RwKTsKPiAgfQo+ ICAKPiArc3RhdGljIHZvaWQgcHNyX2Rpc2FibGUoc3RydWN0IGludGVsX2RwICppbnRlbF9kcCkK CndoYXQgYWJvdXQgaW50ZWxfcHNyX2Rpc2FibGVfdW5sb2NrZWQoKT8KCj4gK3sKPiArCXN0cnVj dCBpbnRlbF9kaWdpdGFsX3BvcnQgKmludGVsX2RpZ19wb3J0ID0gZHBfdG9fZGlnX3BvcnQoaW50 ZWxfZHApOwo+ICsJc3RydWN0IGRybV9kZXZpY2UgKmRldiA9IGludGVsX2RpZ19wb3J0LT5iYXNl LmJhc2UuZGV2Owo+ICsJc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2ID0gdG9faTkx NShkZXYpOwoKYXNzZXJ0IGl0IGlzIGxvY2tlZCBoZXJlLi4uCgo+ICsKPiArCWlmICghZGV2X3By aXYtPnBzci5lbmFibGVkKQo+ICsJCXJldHVybjsKPiArCj4gKwlkZXZfcHJpdi0+cHNyLmRpc2Fi bGVfc291cmNlKGludGVsX2RwKTsKPiArCj4gKwkvKiBEaXNhYmxlIFBTUiBvbiBTaW5rICovCj4g Kwlkcm1fZHBfZHBjZF93cml0ZWIoJmludGVsX2RwLT5hdXgsIERQX1BTUl9FTl9DRkcsIDApOwo+ ICsKPiArCWRldl9wcml2LT5wc3IuZW5hYmxlZCA9IE5VTEw7Cj4gK30KPiArCj4gIC8qKgo+ICAg KiBpbnRlbF9wc3JfZGlzYWJsZSAtIERpc2FibGUgUFNSCj4gICAqIEBpbnRlbF9kcDogSW50ZWwg RFAKPiBAQCAtNzQxLDE3ICs3NTgsNyBAQCB2b2lkIGludGVsX3Bzcl9kaXNhYmxlKHN0cnVjdCBp bnRlbF9kcCAqaW50ZWxfZHAsCj4gIAkJcmV0dXJuOwo+ICAKPiAgCW11dGV4X2xvY2soJmRldl9w cml2LT5wc3IubG9jayk7Cj4gLQlpZiAoIWRldl9wcml2LT5wc3IuZW5hYmxlZCkgewo+IC0JCW11 dGV4X3VubG9jaygmZGV2X3ByaXYtPnBzci5sb2NrKTsKPiAtCQlyZXR1cm47Cj4gLQl9Cj4gLQo+ IC0JZGV2X3ByaXYtPnBzci5kaXNhYmxlX3NvdXJjZShpbnRlbF9kcCk7Cj4gLQo+IC0JLyogRGlz YWJsZSBQU1Igb24gU2luayAqLwo+IC0JZHJtX2RwX2RwY2Rfd3JpdGViKCZpbnRlbF9kcC0+YXV4 LCBEUF9QU1JfRU5fQ0ZHLCAwKTsKPiAtCj4gLQlkZXZfcHJpdi0+cHNyLmVuYWJsZWQgPSBOVUxM Owo+ICsJcHNyX2Rpc2FibGUoaW50ZWxfZHApOwo+ICAJbXV0ZXhfdW5sb2NrKCZkZXZfcHJpdi0+ cHNyLmxvY2spOwo+ICB9Cj4gIAo+IEBAIC05OTIsMyArOTk5LDM0IEBAIHZvaWQgaW50ZWxfcHNy X2luaXQoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2KQo+ICAJZGV2X3ByaXYtPnBz ci5zZXR1cF92c2MgPSBoc3dfcHNyX3NldHVwX3ZzYzsKPiAgCj4gIH0KPiArCj4gK3ZvaWQgaW50 ZWxfcHNyX3Nob3J0X3B1bHNlKHN0cnVjdCBpbnRlbF9kcCAqaW50ZWxfZHApCj4gK3sKPiArCXN0 cnVjdCBpbnRlbF9kaWdpdGFsX3BvcnQgKmludGVsX2RpZ19wb3J0ID0gZHBfdG9fZGlnX3BvcnQo aW50ZWxfZHApOwo+ICsJc3RydWN0IGRybV9kZXZpY2UgKmRldiA9IGludGVsX2RpZ19wb3J0LT5i YXNlLmJhc2UuZGV2Owo+ICsJc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2ID0gdG9f aTkxNShkZXYpOwo+ICsJc3RydWN0IGk5MTVfcHNyICpwc3IgPSAmZGV2X3ByaXYtPnBzcjsKPiAr CXVpbnQ4X3QgdmFsOwo+ICsKPiArCWlmICghQ0FOX1BTUihkZXZfcHJpdikgfHwgIWludGVsX2Rw X2lzX2VkcChpbnRlbF9kcCkpCj4gKwkJcmV0dXJuOwo+ICsKPiArCW11dGV4X2xvY2soJnBzci0+ bG9jayk7Cj4gKwo+ICsJaWYgKHBzci0+ZW5hYmxlZCAhPSBpbnRlbF9kcCkKPiArCQlnb3RvIGV4 aXQ7Cj4gKwo+ICsJaWYgKGRybV9kcF9kcGNkX3JlYWRiKCZpbnRlbF9kcC0+YXV4LCBEUF9QU1Jf U1RBVFVTLCAmdmFsKSAhPSAxKSB7Cj4gKwkJRFJNX0VSUk9SKCJQU1JfU1RBVFVTIGRwY2QgcmVh ZCBmYWlsZWRcbiIpOwo+ICsJCWdvdG8gZXhpdDsKPiArCX0KPiArCj4gKwlpZiAoKHZhbCAmIERQ X1BTUl9TSU5LX1NUQVRFX01BU0spID09IERQX1BTUl9TSU5LX0lOVEVSTkFMX0VSUk9SKSB7Cj4g KwkJRFJNX0RFQlVHX0tNUygiUFNSIHNpbmsgaW50ZXJuYWwgZXJyb3IsIGRpc2FibGluZyBQU1Jc biIpOwo+ICsJCXBzcl9kaXNhYmxlKGludGVsX2RwKTsKPiArCX0KPiArCj4gKwkvKiBUT0RPOiBo YW5kbGUgb3RoZXIgUFNSL1BTUjIgZXJyb3JzICovCj4gK2V4aXQ6Cj4gKwltdXRleF91bmxvY2so JnBzci0+bG9jayk7Cj4gK30KPiAtLSAKPiAyLjE3LjEKPiAKX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1n ZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21h aWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==