From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rodrigo Vivi Subject: Re: [PATCH v4 2/5] drm/i915/psr: Begin to handle PSR/PSR2 errors set by sink Date: Thu, 14 Jun 2018 16:59:09 -0700 Message-ID: <20180614235909.GD8374@intel.com> References: <20180614203433.5602-1-jose.souza@intel.com> <20180614203433.5602-2-jose.souza@intel.com> <20180614210934.GW8374@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTPS id 9CCD46E933 for ; Thu, 14 Jun 2018 23:59:11 +0000 (UTC) Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: "Souza, Jose" Cc: "intel-gfx@lists.freedesktop.org" , "Pandiyan, Dhinakaran" List-Id: intel-gfx@lists.freedesktop.org T24gVGh1LCBKdW4gMTQsIDIwMTggYXQgMDQ6NDY6NDhQTSAtMDcwMCwgU291emEsIEpvc2Ugd3Jv dGU6Cj4gT24gVGh1LCAyMDE4LTA2LTE0IGF0IDE0OjA5IC0wNzAwLCBSb2RyaWdvIFZpdmkgd3Jv dGU6Cj4gPiBPbiBUaHUsIEp1biAxNCwgMjAxOCBhdCAwMTozNDozMFBNIC0wNzAwLCBKb3PDqSBS b2JlcnRvIGRlIFNvdXphCj4gPiB3cm90ZToKPiA+ID4gZURQIHNwZWMgc3RhdGVzIHRoYXQgc2lu ayBkZXZpY2Ugd2lsbCBkbyBhIHNob3J0IHB1bHNlIGluIEhQRAo+ID4gPiBsaW5lIHdoZW4gdGhl cmUgaXMgYSBQU1IvUFNSMiBlcnJvciB0aGF0IG5lZWRzIHRvIGJlIGhhbmRsZWQgYnkKPiA+ID4g c291cmNlLCB0aGlzIGlzIGhhbmRsaW5nIHRoZSBmaXJzdCBhbmQgbW9zdCBzaW1wbGVzIGVycm9y Ogo+ID4gPiBEUF9QU1JfU0lOS19JTlRFUk5BTF9FUlJPUi4KPiA+ID4gCj4gPiA+IEhlcmUgdGFr aW5nIHRoZSBzYWZlc3QgYXBwcm9hY2ggYW5kIGRpc2FibGluZyBQU1IoYXQgbGVhc3QgdW50aWwK PiA+ID4gdGhlIG5leHQgbW9kZXNldCksIHRvIGF2b2lkIG11bHRpcGxlIHJlbmRlcmluZyBpc3N1 ZXMgZHVlIHRvCj4gPiA+IGJhZCBwYW5uZWxzLgo+ID4gPiAKPiA+ID4gdjQ6Cj4gPiA+IFVzaW5n IENBTl9QU1IgaW5zdGVhZCBvZiBIQVNfUFNSIGluIGludGVsX3Bzcl9zaG9ydF9wdWxzZQo+ID4g PiAKPiA+ID4gdjM6Cj4gPiA+IGRpc2FibGluZyBQU1IgaW5zdGVhZCBvZiBleGl0aW5nIG9uIGVy cm9yCj4gPiA+IAo+ID4gPiBDYzogRGhpbmFrYXJhbiBQYW5kaXlhbiA8ZGhpbmFrYXJhbi5wYW5k aXlhbkBpbnRlbC5jb20+Cj4gPiA+IENjOiBSb2RyaWdvIFZpdmkgPHJvZHJpZ28udml2aUBpbnRl bC5jb20+Cj4gPiA+IFNpZ25lZC1vZmYtYnk6IEpvc8OpIFJvYmVydG8gZGUgU291emEgPGpvc2Uu c291emFAaW50ZWwuY29tPgo+ID4gPiAtLS0KPiA+ID4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2lu dGVsX2RwLmMgIHwgIDIgKysKPiA+ID4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rydi5o IHwgIDEgKwo+ID4gPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcHNyLmMgfCA2MCArKysr KysrKysrKysrKysrKysrKysrKysrKwo+ID4gPiAtLS0tLS0KPiA+ID4gIDMgZmlsZXMgY2hhbmdl ZCwgNTIgaW5zZXJ0aW9ucygrKSwgMTEgZGVsZXRpb25zKC0pCj4gPiA+IAo+ID4gPiBkaWZmIC0t Z2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHAuYwo+ID4gPiBiL2RyaXZlcnMvZ3B1 L2RybS9pOTE1L2ludGVsX2RwLmMKPiA+ID4gaW5kZXggNjc4NzViMDBjOGRmLi4xOTU4NTUyM2U0 Y2UgMTAwNjQ0Cj4gPiA+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RwLmMKPiA+ ID4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHAuYwo+ID4gPiBAQCAtNDQ3NCw2 ICs0NDc0LDggQEAgaW50ZWxfZHBfc2hvcnRfcHVsc2Uoc3RydWN0IGludGVsX2RwCj4gPiA+ICpp bnRlbF9kcCkKPiA+ID4gIAlpZiAoaW50ZWxfZHBfbmVlZHNfbGlua19yZXRyYWluKGludGVsX2Rw KSkKPiA+ID4gIAkJcmV0dXJuIGZhbHNlOwo+ID4gPiAgCj4gPiA+ICsJaW50ZWxfcHNyX3Nob3J0 X3B1bHNlKGludGVsX2RwKTsKPiA+ID4gKwo+ID4gPiAgCWlmIChpbnRlbF9kcC0+Y29tcGxpYW5j ZS50ZXN0X3R5cGUgPT0KPiA+ID4gRFBfVEVTVF9MSU5LX1RSQUlOSU5HKSB7Cj4gPiA+ICAJCURS TV9ERUJVR19LTVMoIkxpbmsgVHJhaW5pbmcgQ29tcGxpYW5jZSBUZXN0Cj4gPiA+IHJlcXVlc3Rl ZFxuIik7Cj4gPiA+ICAJCS8qIFNlbmQgYSBIb3RwbHVnIFVldmVudCB0byB1c2Vyc3BhY2UgdG8g c3RhcnQKPiA+ID4gbW9kZXNldCAqLwo+ID4gPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJt L2k5MTUvaW50ZWxfZHJ2LmgKPiA+ID4gYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcnYu aAo+ID4gPiBpbmRleCA4ODQwMTA4NzQ5YTUuLmJiNmZmZGIyODJmZCAxMDA2NDQKPiA+ID4gLS0t IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHJ2LmgKPiA+ID4gKysrIGIvZHJpdmVycy9n cHUvZHJtL2k5MTUvaW50ZWxfZHJ2LmgKPiA+ID4gQEAgLTE5MjYsNiArMTkyNiw3IEBAIHZvaWQg aW50ZWxfcHNyX2NvbXB1dGVfY29uZmlnKHN0cnVjdCBpbnRlbF9kcAo+ID4gPiAqaW50ZWxfZHAs Cj4gPiA+ICAJCQkgICAgICBzdHJ1Y3QgaW50ZWxfY3J0Y19zdGF0ZQo+ID4gPiAqY3J0Y19zdGF0 ZSk7Cj4gPiA+ICB2b2lkIGludGVsX3Bzcl9pcnFfY29udHJvbChzdHJ1Y3QgZHJtX2k5MTVfcHJp dmF0ZSAqZGV2X3ByaXYsIGJvb2wKPiA+ID4gZGVidWcpOwo+ID4gPiAgdm9pZCBpbnRlbF9wc3Jf aXJxX2hhbmRsZXIoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2LCB1MzIKPiA+ID4g cHNyX2lpcik7Cj4gPiA+ICt2b2lkIGludGVsX3Bzcl9zaG9ydF9wdWxzZShzdHJ1Y3QgaW50ZWxf ZHAgKmludGVsX2RwKTsKPiA+ID4gIAo+ID4gPiAgLyogaW50ZWxfcnVudGltZV9wbS5jICovCj4g PiA+ICBpbnQgaW50ZWxfcG93ZXJfZG9tYWluc19pbml0KHN0cnVjdCBkcm1faTkxNV9wcml2YXRl ICopOwo+ID4gPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcHNyLmMK PiA+ID4gYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9wc3IuYwo+ID4gPiBpbmRleCBiYzZk NTRmNjc3ZGMuLmFmNWZjZmQ5OGE1MyAxMDA2NDQKPiA+ID4gLS0tIGEvZHJpdmVycy9ncHUvZHJt L2k5MTUvaW50ZWxfcHNyLmMKPiA+ID4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxf cHNyLmMKPiA+ID4gQEAgLTcyMCw2ICs3MjAsMjMgQEAgc3RhdGljIHZvaWQgaHN3X3Bzcl9kaXNh YmxlKHN0cnVjdCBpbnRlbF9kcAo+ID4gPiAqaW50ZWxfZHApCj4gPiA+ICAJcHNyX2F1eF9pb19w b3dlcl9wdXQoaW50ZWxfZHApOwo+ID4gPiAgfQo+ID4gPiAgCj4gPiA+ICtzdGF0aWMgdm9pZCBw c3JfZGlzYWJsZShzdHJ1Y3QgaW50ZWxfZHAgKmludGVsX2RwKQo+ID4gCj4gPiB3aGF0IGFib3V0 IGludGVsX3Bzcl9kaXNhYmxlX3VubG9ja2VkKCk/Cj4gCj4gdW5sb2NrZWQ/IHNob3VsZG4ndCBi ZSBsb2NrZWQ/CgpkYW0uLi4gZWl0aGVyIHdheSBzZWVtcyBhbWJpZ3VvdXMuLi4KCm1heWJlIGp1 c3QgX19pbnRlbF9wc3JfZGlzYWJsZSgpID8KCj4gSSdtIG9rYXkgaW4gYWRkaW5nIHRoZSBzdWZm aXggYnV0IGl0IHdpbGwgYmUgZGlmZmVyZW50IHRoYW4gdGhlIG90aGVyCj4gZnVuY3Rpb25zIGlu IHRoaXMgZmlsZS4KCndpdGhvdXQgImludGVsXyIgeW91IGFyZSB3aXRoIHByZWZpeCBkaWZmZXJl bnQgdGhhbiB0aGUgb3RoZXIgZnVuY3Rpb25zCmluIHRoaXMgZmlsZSBhbnl3YXlzLi4uCgo+IAo+ ID4gCj4gPiA+ICt7Cj4gPiA+ICsJc3RydWN0IGludGVsX2RpZ2l0YWxfcG9ydCAqaW50ZWxfZGln X3BvcnQgPQo+ID4gPiBkcF90b19kaWdfcG9ydChpbnRlbF9kcCk7Cj4gPiA+ICsJc3RydWN0IGRy bV9kZXZpY2UgKmRldiA9IGludGVsX2RpZ19wb3J0LT5iYXNlLmJhc2UuZGV2Owo+ID4gPiArCXN0 cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiA9IHRvX2k5MTUoZGV2KTsKPiA+IAo+ID4g YXNzZXJ0IGl0IGlzIGxvY2tlZCBoZXJlLi4uCj4gCj4gRG9uZQo+IAo+ID4gCj4gPiA+ICsKPiA+ ID4gKwlpZiAoIWRldl9wcml2LT5wc3IuZW5hYmxlZCkKPiA+ID4gKwkJcmV0dXJuOwo+ID4gPiAr Cj4gPiA+ICsJZGV2X3ByaXYtPnBzci5kaXNhYmxlX3NvdXJjZShpbnRlbF9kcCk7Cj4gPiA+ICsK PiA+ID4gKwkvKiBEaXNhYmxlIFBTUiBvbiBTaW5rICovCj4gPiA+ICsJZHJtX2RwX2RwY2Rfd3Jp dGViKCZpbnRlbF9kcC0+YXV4LCBEUF9QU1JfRU5fQ0ZHLCAwKTsKPiA+ID4gKwo+ID4gPiArCWRl dl9wcml2LT5wc3IuZW5hYmxlZCA9IE5VTEw7Cj4gPiA+ICt9Cj4gPiA+ICsKPiA+ID4gIC8qKgo+ ID4gPiAgICogaW50ZWxfcHNyX2Rpc2FibGUgLSBEaXNhYmxlIFBTUgo+ID4gPiAgICogQGludGVs X2RwOiBJbnRlbCBEUAo+ID4gPiBAQCAtNzQxLDE3ICs3NTgsNyBAQCB2b2lkIGludGVsX3Bzcl9k aXNhYmxlKHN0cnVjdCBpbnRlbF9kcAo+ID4gPiAqaW50ZWxfZHAsCj4gPiA+ICAJCXJldHVybjsK PiA+ID4gIAo+ID4gPiAgCW11dGV4X2xvY2soJmRldl9wcml2LT5wc3IubG9jayk7Cj4gPiA+IC0J aWYgKCFkZXZfcHJpdi0+cHNyLmVuYWJsZWQpIHsKPiA+ID4gLQkJbXV0ZXhfdW5sb2NrKCZkZXZf cHJpdi0+cHNyLmxvY2spOwo+ID4gPiAtCQlyZXR1cm47Cj4gPiA+IC0JfQo+ID4gPiAtCj4gPiA+ IC0JZGV2X3ByaXYtPnBzci5kaXNhYmxlX3NvdXJjZShpbnRlbF9kcCk7Cj4gPiA+IC0KPiA+ID4g LQkvKiBEaXNhYmxlIFBTUiBvbiBTaW5rICovCj4gPiA+IC0JZHJtX2RwX2RwY2Rfd3JpdGViKCZp bnRlbF9kcC0+YXV4LCBEUF9QU1JfRU5fQ0ZHLCAwKTsKPiA+ID4gLQo+ID4gPiAtCWRldl9wcml2 LT5wc3IuZW5hYmxlZCA9IE5VTEw7Cj4gPiA+ICsJcHNyX2Rpc2FibGUoaW50ZWxfZHApOwo+ID4g PiAgCW11dGV4X3VubG9jaygmZGV2X3ByaXYtPnBzci5sb2NrKTsKPiA+ID4gIH0KPiA+ID4gIAo+ ID4gPiBAQCAtOTkyLDMgKzk5OSwzNCBAQCB2b2lkIGludGVsX3Bzcl9pbml0KHN0cnVjdCBkcm1f aTkxNV9wcml2YXRlCj4gPiA+ICpkZXZfcHJpdikKPiA+ID4gIAlkZXZfcHJpdi0+cHNyLnNldHVw X3ZzYyA9IGhzd19wc3Jfc2V0dXBfdnNjOwo+ID4gPiAgCj4gPiA+ICB9Cj4gPiA+ICsKPiA+ID4g K3ZvaWQgaW50ZWxfcHNyX3Nob3J0X3B1bHNlKHN0cnVjdCBpbnRlbF9kcCAqaW50ZWxfZHApCj4g PiA+ICt7Cj4gPiA+ICsJc3RydWN0IGludGVsX2RpZ2l0YWxfcG9ydCAqaW50ZWxfZGlnX3BvcnQg PQo+ID4gPiBkcF90b19kaWdfcG9ydChpbnRlbF9kcCk7Cj4gPiA+ICsJc3RydWN0IGRybV9kZXZp Y2UgKmRldiA9IGludGVsX2RpZ19wb3J0LT5iYXNlLmJhc2UuZGV2Owo+ID4gPiArCXN0cnVjdCBk cm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiA9IHRvX2k5MTUoZGV2KTsKPiA+ID4gKwlzdHJ1Y3Qg aTkxNV9wc3IgKnBzciA9ICZkZXZfcHJpdi0+cHNyOwo+ID4gPiArCXVpbnQ4X3QgdmFsOwo+ID4g PiArCj4gPiA+ICsJaWYgKCFDQU5fUFNSKGRldl9wcml2KSB8fCAhaW50ZWxfZHBfaXNfZWRwKGlu dGVsX2RwKSkKPiA+ID4gKwkJcmV0dXJuOwo+ID4gPiArCj4gPiA+ICsJbXV0ZXhfbG9jaygmcHNy LT5sb2NrKTsKPiA+ID4gKwo+ID4gPiArCWlmIChwc3ItPmVuYWJsZWQgIT0gaW50ZWxfZHApCj4g PiA+ICsJCWdvdG8gZXhpdDsKPiA+ID4gKwo+ID4gPiArCWlmIChkcm1fZHBfZHBjZF9yZWFkYigm aW50ZWxfZHAtPmF1eCwgRFBfUFNSX1NUQVRVUywgJnZhbCkKPiA+ID4gIT0gMSkgewo+ID4gPiAr CQlEUk1fRVJST1IoIlBTUl9TVEFUVVMgZHBjZCByZWFkIGZhaWxlZFxuIik7Cj4gPiA+ICsJCWdv dG8gZXhpdDsKPiA+ID4gKwl9Cj4gPiA+ICsKPiA+ID4gKwlpZiAoKHZhbCAmIERQX1BTUl9TSU5L X1NUQVRFX01BU0spID09Cj4gPiA+IERQX1BTUl9TSU5LX0lOVEVSTkFMX0VSUk9SKSB7Cj4gPiA+ ICsJCURSTV9ERUJVR19LTVMoIlBTUiBzaW5rIGludGVybmFsIGVycm9yLCBkaXNhYmxpbmcKPiA+ ID4gUFNSXG4iKTsKPiA+ID4gKwkJcHNyX2Rpc2FibGUoaW50ZWxfZHApOwo+ID4gPiArCX0KPiA+ ID4gKwo+ID4gPiArCS8qIFRPRE86IGhhbmRsZSBvdGhlciBQU1IvUFNSMiBlcnJvcnMgKi8KPiA+ ID4gK2V4aXQ6Cj4gPiA+ICsJbXV0ZXhfdW5sb2NrKCZwc3ItPmxvY2spOwo+ID4gPiArfQo+ID4g PiAtLSAKPiA+ID4gMi4xNy4xCj4gPiA+IApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5m cmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0 aW5mby9pbnRlbC1nZngK