Re: [PATCH v2 5/5] staging: use BIT_ULL for NL80211_STA_INFO_* attribute types

[Greg KH <greg@kroah.com>]

On Thu, Jun 14, 2018 at 01:09:34PM +0200, Johannes Berg wrote:
> On Thu, 2018-06-14 at 13:13 +0300, Omer Efrat wrote:
> > Since 'filled' member in station_info changed to u64, BIT_ULL macro
> > should be used with NL80211_STA_INFO_* attribute types instead of BIT.
> > 
> > The BIT macro uses unsigned long type which some architectures handle as 32bit
> > and this results in compilation warnings such as:
> > 
> > net/mac80211/sta_info.c:2223:2: warning: left shift count >= width of type
> >   sinfo->filled |= BIT(NL80211_STA_INFO_TID_STATS);
> >   ^
> 
> Same here, I don't think this patch is really needed, but I'll leave it
> up to Greg.
> 
> Greg, FWIW, only a few values are >=31 to need this, including the one
> pointed out in the commit message, but none in this code are affected.

Thanks for the warning, I'll take this just to keep things "clean".

greg k-h