From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Lindgren Subject: Re: [PATCH v2] regulator: core: Enable voltage balancing Date: Fri, 15 Jun 2018 04:29:16 -0700 Message-ID: <20180615112916.GK112168@atomide.com> References: <20180605044554.GC5738@atomide.com> <1528886026-9457-1-git-send-email-m.purski@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1528886026-9457-1-git-send-email-m.purski@samsung.com> Sender: linux-kernel-owner@vger.kernel.org To: Maciej Purski Cc: Mark Brown , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org, Carlos Hernandez , Marek Szyprowski List-Id: linux-omap@vger.kernel.org Hi, * Maciej Purski [180613 10:39]: > Call regulator_balance_voltage() instead of set_voltage_rdev() > in set_voltage_unlocked() and in enabling and disabling functions, > but only if the regulator is coupled. > > Signed-off-by: Maciej Purski > > --- > Changes in v2: > - fix compile errors > - make debug messages more informative Thanks for updating it. This series still hangs after loading modules on beagleboard-x15: [ 26.679749] smps12: regulator_set_voltage: 3381 [ 26.684529] smps12: regulator_set_voltage_unlocked: 3045 [ 26.695616] smps12: _regulator_do_set_voltage: 2912 [ 26.701275] smps12: regulator_set_voltage: 3381 [ 26.706002] smps12: regulator_set_voltage_unlocked: 3045 [ 26.712349] smps12: _regulator_do_set_voltage: 2912 [ 26.719329] abb_mpu: regulator_set_voltage: 3381 [ 26.724105] abb_mpu: regulator_set_voltage_unlocked: 3045 So it seems to be the abb_mpu where it hangs? Regards, Tony From mboxrd@z Thu Jan 1 00:00:00 1970 From: tony@atomide.com (Tony Lindgren) Date: Fri, 15 Jun 2018 04:29:16 -0700 Subject: [PATCH v2] regulator: core: Enable voltage balancing In-Reply-To: <1528886026-9457-1-git-send-email-m.purski@samsung.com> References: <20180605044554.GC5738@atomide.com> <1528886026-9457-1-git-send-email-m.purski@samsung.com> Message-ID: <20180615112916.GK112168@atomide.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi, * Maciej Purski [180613 10:39]: > Call regulator_balance_voltage() instead of set_voltage_rdev() > in set_voltage_unlocked() and in enabling and disabling functions, > but only if the regulator is coupled. > > Signed-off-by: Maciej Purski > > --- > Changes in v2: > - fix compile errors > - make debug messages more informative Thanks for updating it. This series still hangs after loading modules on beagleboard-x15: [ 26.679749] smps12: regulator_set_voltage: 3381 [ 26.684529] smps12: regulator_set_voltage_unlocked: 3045 [ 26.695616] smps12: _regulator_do_set_voltage: 2912 [ 26.701275] smps12: regulator_set_voltage: 3381 [ 26.706002] smps12: regulator_set_voltage_unlocked: 3045 [ 26.712349] smps12: _regulator_do_set_voltage: 2912 [ 26.719329] abb_mpu: regulator_set_voltage: 3381 [ 26.724105] abb_mpu: regulator_set_voltage_unlocked: 3045 So it seems to be the abb_mpu where it hangs? Regards, Tony