From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: virtio-dev-return-4392-cohuck=redhat.com@lists.oasis-open.org Sender: List-Post: List-Help: List-Unsubscribe: List-Subscribe: Received: from lists.oasis-open.org (oasis-open.org [66.179.20.138]) by lists.oasis-open.org (Postfix) with ESMTP id EC5DD5818CAD for ; Fri, 15 Jun 2018 04:30:08 -0700 (PDT) Date: Fri, 15 Jun 2018 14:29:43 +0300 From: "Michael S. Tsirkin" Message-ID: <20180615142610-mutt-send-email-mst@kernel.org> References: <1529037793-35521-1-git-send-email-wei.w.wang@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1529037793-35521-1-git-send-email-wei.w.wang@intel.com> Subject: [virtio-dev] Re: [PATCH v33 0/4] Virtio-balloon: support free page reporting To: Wei Wang Cc: virtio-dev@lists.oasis-open.org, linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, kvm@vger.kernel.org, linux-mm@kvack.org, mhocko@kernel.org, akpm@linux-foundation.org, torvalds@linux-foundation.org, pbonzini@redhat.com, liliang.opensource@gmail.com, yang.zhang.wz@gmail.com, quan.xu0@gmail.com, nilal@redhat.com, riel@redhat.com, peterx@redhat.com List-ID: On Fri, Jun 15, 2018 at 12:43:09PM +0800, Wei Wang wrote: > - remove the cmd id related interface. Now host can just send a free > page hint command to the guest (via the host_cmd config register) > to start the reporting. Here we go again. And what if reporting was already started previously? I don't think it's a good idea to tweak the host/guest interface yet again. -- MST --------------------------------------------------------------------- To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Michael S. Tsirkin" Subject: Re: [PATCH v33 0/4] Virtio-balloon: support free page reporting Date: Fri, 15 Jun 2018 14:29:43 +0300 Message-ID: <20180615142610-mutt-send-email-mst@kernel.org> References: <1529037793-35521-1-git-send-email-wei.w.wang@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: virtio-dev@lists.oasis-open.org, linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, kvm@vger.kernel.org, linux-mm@kvack.org, mhocko@kernel.org, akpm@linux-foundation.org, torvalds@linux-foundation.org, pbonzini@redhat.com, liliang.opensource@gmail.com, yang.zhang.wz@gmail.com, quan.xu0@gmail.com, nilal@redhat.com, riel@redhat.com, peterx@redhat.com To: Wei Wang Return-path: Content-Disposition: inline In-Reply-To: <1529037793-35521-1-git-send-email-wei.w.wang@intel.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: kvm.vger.kernel.org On Fri, Jun 15, 2018 at 12:43:09PM +0800, Wei Wang wrote: > - remove the cmd id related interface. Now host can just send a free > page hint command to the guest (via the host_cmd config register) > to start the reporting. Here we go again. And what if reporting was already started previously? I don't think it's a good idea to tweak the host/guest interface yet again. -- MST