All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Christoph Hellwig <hch@lst.de>
Cc: Ian Abbott <abbotti@mev.co.uk>,
	H Hartley Sweeten <hsweeten@visionengravers.com>,
	linux-kernel@vger.kernel.org
Subject: Re: can we drop the comedi serial2002 drivers from staging?
Date: Sat, 16 Jun 2018 11:37:40 +0200	[thread overview]
Message-ID: <20180616093740.GA9816@kroah.com> (raw)
In-Reply-To: <20180616090645.GA3997@lst.de>

On Sat, Jun 16, 2018 at 11:06:45AM +0200, Christoph Hellwig wrote:
> As far as I can tell there has been no targeted work on the driver
> since merging it at all, and since 2014 even the comedi-wide
> cleanups stopped, laving just drive by tree wide changes since.
> 
> At the same time the driver badly abuses the tty layer and is one
> of only two major abusers of the poll code for in-kernel waits.

Yeah, it's an ugly driver.  It should be rewritten to use the new serdev
api instead of trying to open a tty device node from within the kernel.

I don't object to dropping it.  Ian and Hartley, do you know of any
users of this driver anymore?

thanks,

greg k-h

  reply	other threads:[~2018-06-16  9:38 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-16  9:06 can we drop the comedi serial2002 drivers from staging? Christoph Hellwig
2018-06-16  9:37 ` Greg Kroah-Hartman [this message]
2018-06-18  9:35   ` Ian Abbott
2018-08-01 17:59 ` Greg Kroah-Hartman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180616093740.GA9816@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=abbotti@mev.co.uk \
    --cc=hch@lst.de \
    --cc=hsweeten@visionengravers.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.