From: Nishad Kamdar <nishadkamdar@gmail.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Aditya Shankar <aditya.shankar@microchip.com>,
Ganesh Krishna <ganesh.krishna@microchip.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
devel@driverdev.osuosl.org, linux-wireless@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: wilc1000: Fix type of argument in ieee80211_is_action()
Date: Sun, 17 Jun 2018 13:57:01 +0530 [thread overview]
Message-ID: <20180617082700.GA2594@nishad> (raw)
In-Reply-To: <20180612131413.qlv3wes43obfbmhe@mwanda>
On Tue, Jun 12, 2018 at 04:14:13PM +0300, Dan Carpenter wrote:
> On Sun, Jun 10, 2018 at 12:40:17PM +0530, Nishad Kamdar wrote:
> > Type used is unsigned char but expected is restricted __le16.
> > Warning reported by sparse. Part of eudyptula challenge.
> >
>
> The code is buggy, but this fix just papers over it. We discussed this
> code earlier.
>
> https://lkml.org/lkml/2018/6/5/304
>
> regards,
> dan carpenter
>
Ok, I will look at the discussion. Thanks for the review.
regards,
nishad kamdar
prev parent reply other threads:[~2018-06-17 8:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-10 7:10 [PATCH] staging: wilc1000: Fix type of argument in ieee80211_is_action() Nishad Kamdar
2018-06-12 13:14 ` Dan Carpenter
2018-06-17 8:27 ` Nishad Kamdar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180617082700.GA2594@nishad \
--to=nishadkamdar@gmail.com \
--cc=aditya.shankar@microchip.com \
--cc=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=ganesh.krishna@microchip.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.