From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2 1/3] shadowsocks-libev: Drop the useless hash.
Date: Sun, 17 Jun 2018 15:35:02 +0200 [thread overview]
Message-ID: <20180617153502.295dea02@windsurf> (raw)
In-Reply-To: <20180611181823.2722-1-xuminready@gmail.com>
Hello,
On Mon, 11 Jun 2018 11:18:21 -0700, Min Xu wrote:
> Signed-off-by: Min Xu <xuminready@gmail.com>
> ---
> package/shadowsocks-libev/shadowsocks-libev.hash | 1 -
> 1 file changed, 1 deletion(-)
I've applied, but there are a few minor things that could have been
done better (yes, even for such a simple patch):
1. Use a small letter to start the commit title, i.e:
shadowsocks-libev: drop the useless patch
2. Remove the final dot in the commit title
3. Add a commit log that explains *why* you're doing this change. I've
added the following commit log:
In commit f8d44394777fb9b45befaee3333d974dfe5e745d
("shadowsocks-libev: new package"), when this package was
introduced, the hash for a license file that isn't available in
upstream's tarball was added to the license file. Obviously, this
hash serves no purpose, so drop it.
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
prev parent reply other threads:[~2018-06-17 13:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-11 18:18 [Buildroot] [PATCH v2 1/3] shadowsocks-libev: Drop the useless hash Min Xu
2018-06-11 18:18 ` [Buildroot] [PATCH v2 2/3] shadowsocks-libev: Adding the pthreads dependency Min Xu
2018-06-17 13:43 ` Thomas Petazzoni
2018-06-18 7:13 ` xu min
2018-06-11 18:18 ` [Buildroot] [PATCH v2 3/3] shadowsocks-libev: Adding the __sync related dependency Min Xu
2018-06-17 13:35 ` Thomas Petazzoni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180617153502.295dea02@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.