All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] package/hidapi: select glibc gconv libs copy
Date: Sun, 17 Jun 2018 20:39:15 +0200	[thread overview]
Message-ID: <20180617203915.70bb1e42@windsurf> (raw)
In-Reply-To: <20180617180709.y3czlfck7hh53biz@tarshish>

Hello,

On Sun, 17 Jun 2018 21:07:09 +0300, Baruch Siach wrote:

> > diff --git a/package/hidapi/Config.in b/package/hidapi/Config.in
> > index f6a31ba..d02ec23 100644
> > --- a/package/hidapi/Config.in
> > +++ b/package/hidapi/Config.in
> > @@ -5,6 +5,7 @@ config BR2_PACKAGE_HIDAPI
> >  	select BR2_PACKAGE_LIBUSB
> >  	select BR2_PACKAGE_LIBGUDEV
> >  	select BR2_PACKAGE_LIBICONV if !BR2_ENABLE_LOCALE
> > +	select BR2_TOOLCHAIN_GLIBC_GCONV_LIBS_COPY if BR2_TOOLCHAIN_USES_GLIBC # runtime UTF conversion support  
> 
> This does not work for external toolchains.

Why ?

The TOOLCHAIN_GLIBC_COPY_GCONV_LIBS hook is called for both internal
and external toolchains, and the BR2_TOOLCHAIN_GLIBC_GCONV_LIBS_COPY
option exists for both internal and external toolchains.

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com

  parent reply	other threads:[~2018-06-17 18:39 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-17 17:51 [Buildroot] [PATCH 1/1] package/hidapi: select glibc gconv libs copy Dan Walkes
2018-06-17 18:07 ` Baruch Siach
2018-06-17 18:32   ` Dan Walkes
2018-06-17 18:39   ` Thomas Petazzoni [this message]
2018-06-26 21:34 ` Thomas Petazzoni
2018-07-19  9:41 ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180617203915.70bb1e42@windsurf \
    --to=thomas.petazzoni@bootlin.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.