From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Guenter Roeck <linux@roeck-us.net>
Cc: Benjamin Gilbert <benjamin.gilbert@coreos.com>, stable@vger.kernel.org
Subject: Re: TCP receive windows broken in 4.14.48
Date: Mon, 18 Jun 2018 06:47:33 +0200 [thread overview]
Message-ID: <20180618044733.GA28706@kroah.com> (raw)
In-Reply-To: <20180614212029.GA27119@roeck-us.net>
On Thu, Jun 14, 2018 at 02:20:29PM -0700, Guenter Roeck wrote:
> On Thu, Jun 14, 2018 at 05:09:21PM -0400, Benjamin Gilbert wrote:
> > Hi,
> >
> > 4.14.48 can cause abnormally small TCP receive windows when the sender is
> > faster than the receiver; see https://github.com/coreos/bugs/issues/2457 for
> > details. Reverting "tcp: avoid integer overflows in tcp_rcv_space_adjust()"
> > fixes it. Backporting 02db55718d53 ("tcp: do not overshoot window_clamp in
> > tcp_rcv_space_adjust()"), which is its parent commit upstream, also fixes
> > it.
> >
> 02db55718d53 applies cleanly, so I would suggest we go along that route
> instead of a revert.
>
> Greg - given that the problematic commit is in all stable releases, it would
> probably make sense to apply 02db55718d53 to pre-4.14 kernels as well. It
> does apply clean to all kernels all the way back to 3.18.y.
Now done, thanks.
greg k-h
next prev parent reply other threads:[~2018-06-18 4:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-14 21:09 TCP receive windows broken in 4.14.48 Benjamin Gilbert
2018-06-14 21:20 ` Guenter Roeck
2018-06-18 4:47 ` Greg Kroah-Hartman [this message]
2018-06-18 5:20 ` Greg Kroah-Hartman
2018-06-18 5:39 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180618044733.GA28706@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=benjamin.gilbert@coreos.com \
--cc=linux@roeck-us.net \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.