From: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
To: Maninder Singh <maninder1.s@samsung.com>, pmladek@suse.com
Cc: sergey.senozhatsky@gmail.com, rostedt@goodmis.org,
linux-kernel@vger.kernel.org, a.sahrawat@samsung.com,
pankaj.m@samsung.com, v.narang@samsung.com,
Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
Subject: Re: [PATCH v2] printk: make sure to print log on console.
Date: Mon, 18 Jun 2018 15:23:06 +0900 [thread overview]
Message-ID: <20180618062306.GA29683@jagdpanzerIV> (raw)
In-Reply-To: <20180618061550.GA27996@jagdpanzerIV>
On (06/18/18 15:15), Sergey Senozhatsky wrote:
>
> On (06/01/18 14:26), Maninder Singh wrote:
> >
> > Signed-off-by: Vaneet Narang <v.narang@samsung.com>
> > Signed-off-by: Maninder Singh <maninder1.s@samsung.com>
>
> Reviewed-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
OK, we probably need v3 after all.
I think this
- if (suppress_message_printing(msg->level)) {
+ if (msg->flags & LOG_NOCONS) {
must be changed to
- if (suppress_message_printing(msg->level)) {
+ if (!ignore_loglevel && (msg->flags & LOG_NOCONS)) {
`ignore_loglevel' is a module param and can change any time via
/sys/module/printk/parameters/ignore_loglevel
we need to respect its value.
-ss
next prev parent reply other threads:[~2018-06-18 6:23 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20180601090029epcas5p3cc93d4bfbebb3199f0a2684058da7e26@epcas5p3.samsung.com>
2018-06-01 8:56 ` [PATCH v2] printk: make sure to print log on console Maninder Singh
2018-06-08 8:39 ` Petr Mladek
2018-06-18 6:14 ` Sergey Senozhatsky
2018-06-18 6:15 ` Sergey Senozhatsky
2018-06-18 6:23 ` Sergey Senozhatsky [this message]
2018-06-19 9:32 ` Petr Mladek
2018-06-19 9:49 ` Sergey Senozhatsky
2018-06-19 10:52 ` Petr Mladek
2018-06-20 1:55 ` Sergey Senozhatsky
2018-06-25 14:27 ` Petr Mladek
2018-06-19 13:26 ` Steven Rostedt
2018-06-20 10:52 ` Sergey Senozhatsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180618062306.GA29683@jagdpanzerIV \
--to=sergey.senozhatsky.work@gmail.com \
--cc=a.sahrawat@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maninder1.s@samsung.com \
--cc=pankaj.m@samsung.com \
--cc=pmladek@suse.com \
--cc=rostedt@goodmis.org \
--cc=sergey.senozhatsky@gmail.com \
--cc=v.narang@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.