From: Tony Lindgren <tony@atomide.com>
To: Pavel Machek <pavel@ucw.cz>
Cc: kernel list <linux-kernel@vger.kernel.org>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
linux-omap@vger.kernel.org, sre@kernel.org, nekit1000@gmail.com,
mpartap@gmx.net, merlijn@wizzup.org
Subject: Re: Charge counter on droid 4
Date: Sun, 17 Jun 2018 23:58:27 -0700 [thread overview]
Message-ID: <20180618065827.GN112168@atomide.com> (raw)
In-Reply-To: <20180615083156.GA32102@amd>
* Pavel Machek <pavel@ucw.cz> [180615 08:34]:
> On Fri 2018-06-15 10:00:14, Pavel Machek wrote:
> > Hi!
> >
> > Droid 4 has non-removable battery, yet the charge counter is reset to
> > near zero on each boot of linux.
Not sure if we actively do anything to reset it. I'm guessing
it's the Motorola bootloader that resets everything on boot.
> > Unfortunately, that makes charge counter pretty much useless on d4, as
> > the "battery full" and "battery empty" limits will be different during
> > each boot.
>From what I've seen also the stock kernel starts only with
voltage based estimate initially after a reboot?
> Hmm, and could we refrain from providing "power" values?
>
> I was thinking great, we have hardware that does proper power
> measuerement for us. No.... it is driver providing synthetic
> values. As userland has enough information to do that itself, I
> believe we should not do this in kernel.
Hmm I don't follow you, why would we want to remove these as
they implement a standard sysfs interface?
I use the sysfs interface all the time to monitor the power
consumption and the output seems to match what I was seeing
with my power supply.
Note that we also have the IIO raw data also available if that
might help.
Regards,
Tony
WARNING: multiple messages have this Message-ID (diff)
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: Charge counter on droid 4
Date: Sun, 17 Jun 2018 23:58:27 -0700 [thread overview]
Message-ID: <20180618065827.GN112168@atomide.com> (raw)
In-Reply-To: <20180615083156.GA32102@amd>
* Pavel Machek <pavel@ucw.cz> [180615 08:34]:
> On Fri 2018-06-15 10:00:14, Pavel Machek wrote:
> > Hi!
> >
> > Droid 4 has non-removable battery, yet the charge counter is reset to
> > near zero on each boot of linux.
Not sure if we actively do anything to reset it. I'm guessing
it's the Motorola bootloader that resets everything on boot.
> > Unfortunately, that makes charge counter pretty much useless on d4, as
> > the "battery full" and "battery empty" limits will be different during
> > each boot.
>From what I've seen also the stock kernel starts only with
voltage based estimate initially after a reboot?
> Hmm, and could we refrain from providing "power" values?
>
> I was thinking great, we have hardware that does proper power
> measuerement for us. No.... it is driver providing synthetic
> values. As userland has enough information to do that itself, I
> believe we should not do this in kernel.
Hmm I don't follow you, why would we want to remove these as
they implement a standard sysfs interface?
I use the sysfs interface all the time to monitor the power
consumption and the output seems to match what I was seeing
with my power supply.
Note that we also have the IIO raw data also available if that
might help.
Regards,
Tony
WARNING: multiple messages have this Message-ID (diff)
From: Tony Lindgren <tony@atomide.com>
To: Pavel Machek <pavel@ucw.cz>
Cc: kernel list <linux-kernel@vger.kernel.org>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
linux-omap@vger.kernel.org, sre@kernel.org, nekit1000@gmail.com,
mpartap@gmx.net, merlijn@wizzup.org
Subject: Re: Charge counter on droid 4
Date: Sun, 17 Jun 2018 23:58:27 -0700 [thread overview]
Message-ID: <20180618065827.GN112168@atomide.com> (raw)
In-Reply-To: <20180615083156.GA32102@amd>
* Pavel Machek <pavel@ucw.cz> [180615 08:34]:
> On Fri 2018-06-15 10:00:14, Pavel Machek wrote:
> > Hi!
> >
> > Droid 4 has non-removable battery, yet the charge counter is reset to
> > near zero on each boot of linux.
Not sure if we actively do anything to reset it. I'm guessing
it's the Motorola bootloader that resets everything on boot.
> > Unfortunately, that makes charge counter pretty much useless on d4, as
> > the "battery full" and "battery empty" limits will be different during
> > each boot.
From what I've seen also the stock kernel starts only with
voltage based estimate initially after a reboot?
> Hmm, and could we refrain from providing "power" values?
>
> I was thinking great, we have hardware that does proper power
> measuerement for us. No.... it is driver providing synthetic
> values. As userland has enough information to do that itself, I
> believe we should not do this in kernel.
Hmm I don't follow you, why would we want to remove these as
they implement a standard sysfs interface?
I use the sysfs interface all the time to monitor the power
consumption and the output seems to match what I was seeing
with my power supply.
Note that we also have the IIO raw data also available if that
might help.
Regards,
Tony
next prev parent reply other threads:[~2018-06-18 6:58 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-15 8:00 Charge counter on droid 4 Pavel Machek
2018-06-15 8:00 ` Pavel Machek
2018-06-15 8:31 ` Pavel Machek
2018-06-15 8:31 ` Pavel Machek
2018-06-18 6:58 ` Tony Lindgren [this message]
2018-06-18 6:58 ` Tony Lindgren
2018-06-18 6:58 ` Tony Lindgren
2018-06-18 7:40 ` Pavel Machek
2018-06-18 7:40 ` Pavel Machek
2018-06-18 8:28 ` Tony Lindgren
2018-06-18 8:28 ` Tony Lindgren
2018-06-18 8:28 ` Tony Lindgren
2018-06-18 9:34 ` Pavel Machek
2018-06-18 9:34 ` Pavel Machek
2018-06-18 11:48 ` Tony Lindgren
2018-06-18 11:48 ` Tony Lindgren
2018-07-04 19:56 ` Pavel Machek
2018-07-04 19:56 ` Pavel Machek
2018-07-05 8:26 ` Tony Lindgren
2018-07-05 8:26 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180618065827.GN112168@atomide.com \
--to=tony@atomide.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=merlijn@wizzup.org \
--cc=mpartap@gmx.net \
--cc=nekit1000@gmail.com \
--cc=pavel@ucw.cz \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.