From: Tony Lindgren <tony@atomide.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: "H. Nikolaus Schaller" <hns@goldelico.com>,
"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
Linus Walleij <linus.walleij@linaro.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
kernel@pyra-handheld.com,
Discussions about the Letux Kernel <letux-kernel@openphoenux.org>
Subject: Re: [Letux-kernel] BUG: drivers/pinctrl/core: races in pinctrl_groups and deferred probing
Date: Mon, 18 Jun 2018 02:14:33 -0700 [thread overview]
Message-ID: <20180618091433.GP112168@atomide.com> (raw)
In-Reply-To: <CAHp75Vf7-xcsoSJ--9nJYbxpwSfDv201UwnxJHoFbwtD187SPw@mail.gmail.com>
* Andy Shevchenko <andy.shevchenko@gmail.com> [180618 08:25]:
> On Sat, Jun 16, 2018 at 2:08 PM H. Nikolaus Schaller <hns@goldelico.com> wrote:
> > But it looks as if we still have duplicate assignments by deferred probing, i.e. some cleanup is
> > missing (or is this intended behaviour?).
>
> > But I think the fundamental problem is that the same driver assigns multiple slots if
> > probing is deferred.
>
> Indeed.
>
> I think there is a simple way to clean up pinctrl stuff on failed probe. See
> https://elixir.bootlin.com/linux/v4.18-rc1/source/drivers/base/dd.c#L416
>
> We only bind pins, and do not perform any actions when failure happens later on.
Yup seems like a good approach. I'll take a look if we can just
check if the function or group name already exists and return
the existing selector in that case.
Regards,
Tony
next prev parent reply other threads:[~2018-06-18 9:14 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-13 12:39 BUG: drivers/pinctrl/core: races in pinctrl_groups and deferred probing H. Nikolaus Schaller
2018-06-14 12:01 ` Tony Lindgren
2018-06-14 12:12 ` H. Nikolaus Schaller
2018-06-15 6:58 ` Tony Lindgren
2018-06-15 11:13 ` Tony Lindgren
2018-06-15 11:18 ` H. Nikolaus Schaller
2018-06-16 11:07 ` [Letux-kernel] " H. Nikolaus Schaller
2018-06-18 6:46 ` Tony Lindgren
2018-06-18 8:22 ` Andy Shevchenko
2018-06-18 9:14 ` Tony Lindgren [this message]
2018-06-18 9:29 ` H. Nikolaus Schaller
2018-06-18 9:54 ` Tony Lindgren
2018-06-18 9:59 ` H. Nikolaus Schaller
[not found] ` <CA+Ot1OxNj30KgHWJHXgWbnXYkNXTNvd_t-b6+uG3u=z8+pZf2Q@mail.gmail.com>
2018-06-18 11:51 ` Tony Lindgren
2018-06-18 16:43 ` H. Nikolaus Schaller
2018-06-18 18:17 ` Tony Lindgren
2018-06-18 18:30 ` H. Nikolaus Schaller
2018-06-19 4:34 ` Tony Lindgren
2018-06-19 4:51 ` H. Nikolaus Schaller
2018-06-19 6:11 ` Tony Lindgren
2018-06-19 6:39 ` H. Nikolaus Schaller
2018-06-19 7:15 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180618091433.GP112168@atomide.com \
--to=tony@atomide.com \
--cc=andy.shevchenko@gmail.com \
--cc=hns@goldelico.com \
--cc=kernel@pyra-handheld.com \
--cc=letux-kernel@openphoenux.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.