From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] usb: sunxi: ohci: make ohci_t the first member in private data
Date: Mon, 18 Jun 2018 12:59:03 -0400 [thread overview]
Message-ID: <20180618165903.GF4609@bill-the-cat.ec.rr.com> (raw)
In-Reply-To: <CAD6G_RS3ktB6-Dn=qtLdHvphBB60HM8yfLespMmT8n=8+8OGyg@mail.gmail.com>
On Mon, Jun 18, 2018 at 11:45:23AM +0530, Jagan Teki wrote:
> On Mon, Jun 18, 2018 at 6:44 AM, Marek Vasut <marex@denx.de> wrote:
> > On 06/17/2018 06:13 PM, Vasily Khoruzhick wrote:
> >> ohci-hcd casts priv_data pointer to (ohci_t *), thus it must be
> >> the first member in private data struct.
> >>
> >> Fixes 831cc98b1 ("usb: sunxi: Simplify ccm reg base code")
> >>
> >> Signed-off-by: Vasily Khoruzhick <anarsoul@gmail.com>
> >
> > Sigh, I really wonder how (or if at all!) the original series was
> > tested. And then I get flak for scrutinizing patches, right ...
>
> APAIK, I did basic sanity with possible tests.
>
> But one thing for sure is, you should have to wait for sometime to
> apply this patch. Applying fast (that to during weekend) making
> reviewers or maintainers not giving enough room to work.
It is a custodian's job to pick up what they see as obviously correct
and/or important fixes ASAP. While things are working in your test
cases, there are clearly other hardware combinations that are not
working and that this corrects.
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20180618/4164b6c5/attachment.sig>
prev parent reply other threads:[~2018-06-18 16:59 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-17 16:13 [U-Boot] [PATCH] usb: sunxi: ohci: make ohci_t the first member in private data Vasily Khoruzhick
2018-06-18 1:14 ` Marek Vasut
2018-06-18 6:15 ` Jagan Teki
2018-06-18 7:19 ` Marek Vasut
2018-06-18 7:39 ` Jagan Teki
2018-06-18 15:36 ` Vasily Khoruzhick
2018-06-18 16:59 ` Tom Rini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180618165903.GF4609@bill-the-cat.ec.rr.com \
--to=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.