From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id E073F210D1F18 for ; Mon, 18 Jun 2018 18:56:22 -0700 (PDT) Date: Mon, 18 Jun 2018 19:56:21 -0600 From: Ross Zwisler Subject: Re: [PATCH] tools/testing/nvdimm: advertise a write cache for nfit_test Message-ID: <20180619015621.GA28069@linux.intel.com> References: <20180618231702.16503-1-vishal.l.verma@intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20180618231702.16503-1-vishal.l.verma@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-nvdimm-bounces@lists.01.org Sender: "Linux-nvdimm" To: Vishal Verma Cc: linux-nvdimm@lists.01.org List-ID: On Mon, Jun 18, 2018 at 05:17:02PM -0600, Vishal Verma wrote: > Commit 546eb0317cfa "libnvdimm, pmem: Do not flush power-fail protected CPU caches" > fixed the write_cache detection to correctly show the lack of a write > cache based on the platform capabilities described in the ACPI NFIT. The > nfit_test unit tests expected a write cache to be present, so change the > nfit test namespaces to only advertise a persistence domain limited to > the memory controller. This allows the kernel to show a write_cache > attribute, and the test behaviour remains unchanged. > > Cc: Ross Zwisler > Cc: Dan Williams > Signed-off-by: Vishal Verma Sure, this makes sense to me. Thanks for the fix. Reviewed-by: Ross Zwisler _______________________________________________ Linux-nvdimm mailing list Linux-nvdimm@lists.01.org https://lists.01.org/mailman/listinfo/linux-nvdimm