From: hch@lst.de (Christoph Hellwig)
Subject: [PATCH 1/1] nvme-rdma: fix error flow during controller reset
Date: Tue, 19 Jun 2018 07:15:04 +0200 [thread overview]
Message-ID: <20180619051504.GA22076@lst.de> (raw)
In-Reply-To: <1529247426-13303-1-git-send-email-maxg@mellanox.com>
> ret = nvme_rdma_configure_io_queues(ctrl, false);
> if (ret)
> - goto out_fail;
> + goto destroy_admin;
> }
>
> changed = nvme_change_ctrl_state(&ctrl->ctrl, NVME_CTRL_LIVE);
> @@ -1795,6 +1795,8 @@ static void nvme_rdma_reset_ctrl_work(struct work_struct *work)
>
> return;
>
> +destroy_admin:
> + nvme_rdma_destroy_admin_queue(ctrl, false);
> out_fail:
> ++ctrl->ctrl.nr_reconnects;
> nvme_rdma_reconnect_or_remove(ctrl);
What about:
nvme_rdma_reconnect_or_remove
-> nvme_delete_ctrl
-> nvme_rdma_delete_ctrl
-> nvme_rdma_shutdown_ctrl
-> nvme_rdma_destroy_admin_queue
?
next prev parent reply other threads:[~2018-06-19 5:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-17 14:57 [PATCH 1/1] nvme-rdma: fix error flow during controller reset Max Gurtovoy
2018-06-19 5:15 ` Christoph Hellwig [this message]
2018-06-19 9:49 ` Max Gurtovoy
2018-06-19 16:40 ` Sagi Grimberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180619051504.GA22076@lst.de \
--to=hch@lst.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.