From mboxrd@z Thu Jan 1 00:00:00 1970 From: hch@lst.de (Christoph Hellwig) Date: Tue, 19 Jun 2018 07:41:57 +0200 Subject: [PATCH] nvme: Fix error flow at nvme_rdma_configure_admin_queue() In-Reply-To: References: <1528979864-3109-1-git-send-email-israelr@mellanox.com> <20180615080154.GA19525@lst.de> Message-ID: <20180619054157.GC23184@lst.de> On Sun, Jun 17, 2018@01:52:55PM +0300, Max Gurtovoy wrote: >> back instead and have a different double free protection. E.g. >> in nvme_rdma_free_qe just check if qe->data is set first, >> and the NULL it out when freeing. >> > > I guess we can but this is not enough since we'll need to move the call to > nvme_rdma_free_qe to be after stopping the queue. I actually think that > making it symetrical is the right way to go (we also have a flag > NVME_RDMA_Q_ALLOCATED that helps here) but I guess reverting Sagi's commit > + some fix will work too. Yes, it should be symetrical either way. What is the story with NVME_RDMA_Q_ALLOCATED?