All of lore.kernel.org
 help / color / mirror / Atom feed
From: Matthias Kaehlcke <mka@chromium.org>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Nick Desaulniers <ndesaulniers@google.com>,
	joe@perches.com, rkrcmar@redhat.com,
	Thomas Gleixner <tglx@linutronix.de>,
	hpa@zytor.com, x86@kernel.org, kvm@vger.kernel.org,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] kvm: x86: mmu: Add cast to negated bitmasks in update_permission_bitmask()
Date: Tue, 19 Jun 2018 11:38:47 -0700	[thread overview]
Message-ID: <20180619183847.GC169030@google.com> (raw)
In-Reply-To: <a1c2d331-ea79-b2de-af32-1f914bea2fda@redhat.com>

On Tue, Jun 19, 2018 at 07:13:41PM +0200, Paolo Bonzini wrote:
> On 19/06/2018 19:08, Nick Desaulniers wrote:
> >> This one really makes the code uglier though, so I'm not really inclined
> >> to applying the patch.
> > Note that of the three variables (w, u, x), only u is used later on.
> > What about declaring them as negated with the cast, that way there's
> > no cast in a ternary?
> 
> I still find it inferior, but I guess it's at least acceptable.  I
> prefer not_{x,w,u} though. :)

Thanks Nick and Paolo for the suggestions, I'll sent an updated
version soon.

  reply	other threads:[~2018-06-19 18:38 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-15 17:47 [PATCH] kvm: x86: mmu: Add cast to negated bitmasks in update_permission_bitmask() Matthias Kaehlcke
2018-06-15 18:04 ` Nick Desaulniers
2018-06-15 18:18   ` Joe Perches
2018-06-15 18:29     ` Matthias Kaehlcke
2018-06-15 18:40       ` Joe Perches
2018-06-15 18:45         ` Nick Desaulniers
2018-06-19 15:19           ` Paolo Bonzini
2018-06-19 17:08             ` Nick Desaulniers
2018-06-19 17:13               ` Paolo Bonzini
2018-06-19 18:38                 ` Matthias Kaehlcke [this message]
2018-06-19 17:23               ` Joe Perches
2018-06-19 17:35                 ` Paolo Bonzini
2018-06-19 18:07                   ` Joe Perches
2018-06-19 18:36                     ` Matthias Kaehlcke
2018-06-19 19:11                       ` Joe Perches
2018-06-19 21:10                         ` Matthias Kaehlcke
2018-06-19 21:55                           ` Joe Perches
2018-06-19 23:45                             ` Matthias Kaehlcke
2018-06-20  0:18                               ` Joe Perches
2018-06-20  1:36                                 ` Matthias Kaehlcke
2018-06-20  8:02                               ` Paolo Bonzini
2018-06-20 23:00                                 ` Matthias Kaehlcke
2018-06-16  3:39 ` kbuild test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180619183847.GC169030@google.com \
    --to=mka@chromium.org \
    --cc=hpa@zytor.com \
    --cc=joe@perches.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ndesaulniers@google.com \
    --cc=pbonzini@redhat.com \
    --cc=rkrcmar@redhat.com \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.