From: keith.busch@linux.intel.com (Keith Busch)
Subject: NVME-CLI : Fabrics property-get and 64 bit property (CAP)
Date: Tue, 19 Jun 2018 13:48:02 -0600 [thread overview]
Message-ID: <20180619194802.GF19922@localhost.localdomain> (raw)
In-Reply-To: <CAPrnrPBKcYUsuQ6krkcjB6BOzLcPz47vje4qjic5Xw9PQN3pTQ@mail.gmail.com>
On Tue, Jun 19, 2018@10:02:17PM +0300, Eyal BenDavid wrote:
> Are the result field in struct nvme_admin_passthru and struct
> nvme_completion the same?
> I mean does ioctl copy the result field from completion to
> admin_passthru structure?
Yeah, those two are reporting the same thing. bytes 0-3 of the CQE.
The ioctl uapi was developed when the CQE bytes 4-7 were reserved in the
specification (they still are in the base spec), so those bytes were not
reported. If this is something we need to support, I think the only way
is to introduce a version-2 of the ioctl that copies the 8-byte status
for fabrics.
next prev parent reply other threads:[~2018-06-19 19:48 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-19 16:23 NVME-CLI : Fabrics property-get and 64 bit property (CAP) Eyal BenDavid
2018-06-19 17:54 ` Daniel Verkamp
2018-06-19 19:02 ` Eyal BenDavid
2018-06-19 19:48 ` Keith Busch [this message]
2018-06-19 20:00 ` Eyal BenDavid
2018-06-19 20:25 ` Keith Busch
2018-06-19 20:55 ` Eyal BenDavid
2018-06-19 21:33 ` Eyal BenDavid
2018-06-20 16:20 ` Eyal BenDavid
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180619194802.GF19922@localhost.localdomain \
--to=keith.busch@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.