All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: kvm@vger.kernel.org, Marcelo Tosatti <mtosatti@redhat.com>,
	qemu-devel@nongnu.org, Eduardo Habkost <ehabkost@redhat.com>,
	Richard Henderson <rth@twiddle.net>
Subject: Re: [PATCH v3 1/2] kvm: support -dedicated cpu-pm=on|off
Date: Tue, 19 Jun 2018 23:43:50 +0300	[thread overview]
Message-ID: <20180619233509-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <b59883c6-1dc0-4e81-439c-587c8f2d3e83@redhat.com>

On Tue, Jun 19, 2018 at 05:17:45PM +0200, Paolo Bonzini wrote:
> On 16/06/2018 00:29, Michael S. Tsirkin wrote:
> >  
> > +static QemuOptsList qemu_dedicated_opts = {
> > +    .name = "dedicated",
> > +    .head = QTAILQ_HEAD_INITIALIZER(qemu_dedicated_opts.head),
> > +    .desc = {
> > +        {
> > +            .name = "mem-lock",
> > +            .type = QEMU_OPT_BOOL,
> > +        },
> > +        {
> > +            .name = "cpu-pm",
> > +            .type = QEMU_OPT_BOOL,
> > +        },
> > +        { /* end of list */ }
> > +    },
> > +};
> > +
> 
> Let the bikeshedding begin!
> 
> 1) Should we deprecate -realtime?

Can be a patch on top, by whoever cares.

> 2) Maybe -hostresource?
> 
> Paolo

Is ability to cause high latency for other threads really a resource?

The issues in question:
1. a malicious guest can cause high latency for others sharing the host cpu.
2. to host scheduler cpu looks busier than it really is.

All are avoided if you use a dedicated host cpu, and 2 will
help scheduler get closer to giving you one.


-- 
MST

WARNING: multiple messages have this Message-ID (diff)
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel@nongnu.org, Richard Henderson <rth@twiddle.net>,
	Eduardo Habkost <ehabkost@redhat.com>,
	Marcelo Tosatti <mtosatti@redhat.com>,
	kvm@vger.kernel.org
Subject: Re: [Qemu-devel] [PATCH v3 1/2] kvm: support -dedicated cpu-pm=on|off
Date: Tue, 19 Jun 2018 23:43:50 +0300	[thread overview]
Message-ID: <20180619233509-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <b59883c6-1dc0-4e81-439c-587c8f2d3e83@redhat.com>

On Tue, Jun 19, 2018 at 05:17:45PM +0200, Paolo Bonzini wrote:
> On 16/06/2018 00:29, Michael S. Tsirkin wrote:
> >  
> > +static QemuOptsList qemu_dedicated_opts = {
> > +    .name = "dedicated",
> > +    .head = QTAILQ_HEAD_INITIALIZER(qemu_dedicated_opts.head),
> > +    .desc = {
> > +        {
> > +            .name = "mem-lock",
> > +            .type = QEMU_OPT_BOOL,
> > +        },
> > +        {
> > +            .name = "cpu-pm",
> > +            .type = QEMU_OPT_BOOL,
> > +        },
> > +        { /* end of list */ }
> > +    },
> > +};
> > +
> 
> Let the bikeshedding begin!
> 
> 1) Should we deprecate -realtime?

Can be a patch on top, by whoever cares.

> 2) Maybe -hostresource?
> 
> Paolo

Is ability to cause high latency for other threads really a resource?

The issues in question:
1. a malicious guest can cause high latency for others sharing the host cpu.
2. to host scheduler cpu looks busier than it really is.

All are avoided if you use a dedicated host cpu, and 2 will
help scheduler get closer to giving you one.


-- 
MST

  reply	other threads:[~2018-06-19 20:43 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-15 22:29 [PATCH v3 0/2] kvm: limited x86 CPU power management Michael S. Tsirkin
2018-06-15 22:29 ` [Qemu-devel] " Michael S. Tsirkin
2018-06-15 22:29 ` [PATCH v3 1/2] kvm: support -dedicated cpu-pm=on|off Michael S. Tsirkin
2018-06-15 22:29   ` [Qemu-devel] " Michael S. Tsirkin
2018-06-19 15:17   ` Paolo Bonzini
2018-06-19 15:17     ` [Qemu-devel] " Paolo Bonzini
2018-06-19 20:43     ` Michael S. Tsirkin [this message]
2018-06-19 20:43       ` Michael S. Tsirkin
2018-06-20 14:20       ` Paolo Bonzini
2018-06-20 14:20         ` [Qemu-devel] " Paolo Bonzini
2018-06-20 14:29         ` Michael S. Tsirkin
2018-06-20 14:29           ` [Qemu-devel] " Michael S. Tsirkin
2018-06-20 14:45           ` Paolo Bonzini
2018-06-20 14:45             ` [Qemu-devel] " Paolo Bonzini
2018-06-19 22:07     ` Eric Blake
2018-06-19 22:07       ` [Qemu-devel] " Eric Blake
2018-06-20  0:06       ` Michael S. Tsirkin
2018-06-20  0:06         ` [Qemu-devel] " Michael S. Tsirkin
2018-06-20  0:46         ` Wanpeng Li
2018-06-20  0:46           ` [Qemu-devel] " Wanpeng Li
2018-06-20  2:41           ` Michael S. Tsirkin
2018-06-20  2:41             ` [Qemu-devel] " Michael S. Tsirkin
2018-07-05  5:52             ` Wanpeng Li
2018-07-05  5:52               ` [Qemu-devel] " Wanpeng Li
2018-06-15 22:29 ` [PATCH v3 2/2] i386/cpu: make -cpu host support monitor/mwait Michael S. Tsirkin
2018-06-15 22:29   ` [Qemu-devel] " Michael S. Tsirkin
2018-06-16  0:05 ` [PATCH v3 0/2] kvm: limited x86 CPU power management no-reply
2018-06-16  0:05   ` [Qemu-devel] " no-reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180619233509-mutt-send-email-mst@kernel.org \
    --to=mst@redhat.com \
    --cc=ehabkost@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=mtosatti@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=rth@twiddle.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.