From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Lunn Subject: Re: [PATCH v2] mdio-mux-gpio: Remove VLA usage Date: Wed, 20 Jun 2018 08:32:48 +0200 Message-ID: <20180620063248.GA9303@lunn.ch> References: <20180530204830.GA24884@beast> <20180530205712.GB16286@lunn.ch> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Kees Cook Cc: Linus Walleij , Pramod Kumar , Florian Fainelli , "David S. Miller" , linux-gpio@vger.kernel.org, LKML List-Id: linux-gpio@vger.kernel.org On Tue, Jun 19, 2018 at 09:44:27PM -0700, Kees Cook wrote: > On Wed, May 30, 2018 at 1:57 PM, Andrew Lunn wrote: > > On Wed, May 30, 2018 at 01:48:30PM -0700, Kees Cook wrote: > >> In the quest to remove all stack VLA usage from the kernel[1], this > >> moves the allocation into struct mdio_mux_gpio_state during probe. > >> > >> [1] https://lkml.kernel.org/r/CA+55aFzCG-zNmZwX4A2FQpadafLfEzK6CC=qPXydAacU1RqZWA@mail.gmail.com > >> > >> Signed-off-by: Kees Cook > >> --- > >> v2: allocate array as part of structure (Andrew Lunn) > > > > Hi Kees > > > > This looks much better, thanks. > > > > Reviewed-by: Andrew Lunn > > Thanks! Who can take this patch? Linus? David Miller. Does it cleanly apply to net-next? Andrew