All of lore.kernel.org
 help / color / mirror / Atom feed
From: hch@lst.de (Christoph Hellwig)
Subject: [PATCH V4] nvmet: add buffered I/O support for file backed ns
Date: Wed, 20 Jun 2018 10:21:21 +0200	[thread overview]
Message-ID: <20180620082121.GA3033@lst.de> (raw)
In-Reply-To: <20180620040141.9553-1-chaitanya.kulkarni@wdc.com>

> +		ns->file_wq = alloc_workqueue("nvmet-file",
> +				WQ_UNBOUND_MAX_ACTIVE | WQ_MEM_RECLAIM, 0);

The WQ_UNBOUND_MAX_ACTIVE here looks bogus, as far as I can tell it
isn't a flag for alloc_workqueue but needs to be passed as the last
argument.

I've removed it for now, and applied the patch with a few minor cleanups
to the nvme-4.19 branch.

  reply	other threads:[~2018-06-20  8:21 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-20  4:01 [PATCH V4] nvmet: add buffered I/O support for file backed ns Chaitanya Kulkarni
2018-06-20  8:21 ` Christoph Hellwig [this message]
2018-06-20 17:44 ` Sagi Grimberg
2018-06-20 21:44   ` Chaitanya Kulkarni
2018-06-21  6:51     ` Sagi Grimberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180620082121.GA3033@lst.de \
    --to=hch@lst.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.