From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH 1/3] lib: Add SAFE_CHROOT(path) macro
Date: Wed, 20 Jun 2018 12:04:47 +0200 [thread overview]
Message-ID: <20180620100447.GB21435@rei> (raw)
In-Reply-To: <20180620075917.21056-1-pvorel@suse.cz>
Hi!
> include/safe_macros_fn.h | 3 +++
> include/tst_safe_macros.h | 5 ++++-
> lib/safe_macros.c | 15 +++++++++++++++
> 3 files changed, 22 insertions(+), 1 deletion(-)
>
> diff --git a/include/safe_macros_fn.h b/include/safe_macros_fn.h
> index 3df952811..9b11801a4 100644
> --- a/include/safe_macros_fn.h
> +++ b/include/safe_macros_fn.h
> @@ -30,6 +30,9 @@ char* safe_basename(const char *file, const int lineno,
> int safe_chdir(const char *file, const int lineno,
> void (*cleanup_fn)(void), const char *path);
>
> +int safe_chroot(const char *file, const int lineno,
> + void (*cleanup_fn)(void), const char *path);
Can we pretty please avoid adding the function prototypes with the
unused cleanup pointer?
The safe_macros_fn.h file exists only for a historical reasons, new safe
macros should be added to the tst_safe_macros.h file only, both macro
and function prototype should go there.
--
Cyril Hrubis
chrubis@suse.cz
next prev parent reply other threads:[~2018-06-20 10:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-20 7:59 [LTP] [PATCH 1/3] lib: Add SAFE_CHROOT(path) macro Petr Vorel
2018-06-20 7:59 ` [LTP] [PATCH 2/3] lib: Introduce TESTPTR() Petr Vorel
2018-06-20 10:08 ` Cyril Hrubis
2018-06-20 7:59 ` [LTP] [PATCH 3/3] cve/cve-2018-1000001: Add Realpath Buffer Underflow test Petr Vorel
2018-06-20 10:04 ` Cyril Hrubis [this message]
2018-06-20 12:26 ` [LTP] [PATCH 1/3] lib: Add SAFE_CHROOT(path) macro Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180620100447.GB21435@rei \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.