From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rodrigo Vivi Date: Wed, 20 Jun 2018 18:59:56 +0000 Subject: Re: [PATCH][next] drm/i915/psr: fix copy-paste error with setting of tp2_wakeup_time_us Message-Id: <20180620185956.GB8258@intel.com> List-Id: References: <20180620132543.28092-1-colin.king@canonical.com> In-Reply-To: <20180620132543.28092-1-colin.king@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Colin King Cc: David Airlie , intel-gfx@lists.freedesktop.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org On Wed, Jun 20, 2018 at 02:25:43PM +0100, Colin King wrote: > From: Colin Ian King > > Currently for the psr_table->tp2_tp3_wakeup_time case 3 there appears > to be a copy-paste error from the previous switch statement where > dev_priv->vbt.psr.tp1_wakeup_time_us is being assigned and I believe > it should be dev_priv->vbt.psr.tp2_tp3_wakeup_time_us that should be > assigned instead. > > Detected by CoverityScan, CID#1470105 ("Copy-paste error") > > Fixes: 77312ae8f071 ("drm/i915/psr: vbt change for psr") > Signed-off-by: Colin Ian King Reviewed-by: Rodrigo Vivi pushing to dinq now. thanks for the patch. > --- > drivers/gpu/drm/i915/intel_bios.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/intel_bios.c b/drivers/gpu/drm/i915/intel_bios.c > index 03f04b472394..e0a14be1080a 100644 > --- a/drivers/gpu/drm/i915/intel_bios.c > +++ b/drivers/gpu/drm/i915/intel_bios.c > @@ -740,7 +740,7 @@ parse_psr(struct drm_i915_private *dev_priv, const struct bdb_header *bdb) > dev_priv->vbt.psr.tp2_tp3_wakeup_time_us = 100; > break; > case 3: > - dev_priv->vbt.psr.tp1_wakeup_time_us = 0; > + dev_priv->vbt.psr.tp2_tp3_wakeup_time_us = 0; > break; > default: > DRM_DEBUG_KMS("VBT tp2_tp3 wakeup time value %d is outside range[0-3], defaulting to max value 2500us\n", > -- > 2.17.0 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rodrigo Vivi Subject: Re: [PATCH][next] drm/i915/psr: fix copy-paste error with setting of tp2_wakeup_time_us Date: Wed, 20 Jun 2018 11:59:56 -0700 Message-ID: <20180620185956.GB8258@intel.com> References: <20180620132543.28092-1-colin.king@canonical.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <20180620132543.28092-1-colin.king@canonical.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Colin King Cc: David Airlie , intel-gfx@lists.freedesktop.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org T24gV2VkLCBKdW4gMjAsIDIwMTggYXQgMDI6MjU6NDNQTSArMDEwMCwgQ29saW4gS2luZyB3cm90 ZToKPiBGcm9tOiBDb2xpbiBJYW4gS2luZyA8Y29saW4ua2luZ0BjYW5vbmljYWwuY29tPgo+IAo+ IEN1cnJlbnRseSBmb3IgdGhlIHBzcl90YWJsZS0+dHAyX3RwM193YWtldXBfdGltZSBjYXNlIDMg dGhlcmUgYXBwZWFycwo+IHRvIGJlIGEgY29weS1wYXN0ZSBlcnJvciBmcm9tIHRoZSBwcmV2aW91 cyBzd2l0Y2ggc3RhdGVtZW50IHdoZXJlCj4gZGV2X3ByaXYtPnZidC5wc3IudHAxX3dha2V1cF90 aW1lX3VzIGlzIGJlaW5nIGFzc2lnbmVkIGFuZCBJIGJlbGlldmUKPiBpdCBzaG91bGQgYmUgZGV2 X3ByaXYtPnZidC5wc3IudHAyX3RwM193YWtldXBfdGltZV91cyB0aGF0IHNob3VsZCBiZQo+IGFz c2lnbmVkIGluc3RlYWQuCj4gCj4gRGV0ZWN0ZWQgYnkgQ292ZXJpdHlTY2FuLCBDSUQjMTQ3MDEw NSAoIkNvcHktcGFzdGUgZXJyb3IiKQo+IAo+IEZpeGVzOiA3NzMxMmFlOGYwNzEgKCJkcm0vaTkx NS9wc3I6IHZidCBjaGFuZ2UgZm9yIHBzciIpCj4gU2lnbmVkLW9mZi1ieTogQ29saW4gSWFuIEtp bmcgPGNvbGluLmtpbmdAY2Fub25pY2FsLmNvbT4KClJldmlld2VkLWJ5OiBSb2RyaWdvIFZpdmkg PHJvZHJpZ28udml2aUBpbnRlbC5jb20+CgpwdXNoaW5nIHRvIGRpbnEgbm93LiB0aGFua3MgZm9y IHRoZSBwYXRjaC4KCj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Jpb3MuYyB8 IDIgKy0KPiAgMSBmaWxlIGNoYW5nZWQsIDEgaW5zZXJ0aW9uKCspLCAxIGRlbGV0aW9uKC0pCj4g Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Jpb3MuYyBiL2RyaXZl cnMvZ3B1L2RybS9pOTE1L2ludGVsX2Jpb3MuYwo+IGluZGV4IDAzZjA0YjQ3MjM5NC4uZTBhMTRi ZTEwODBhIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Jpb3MuYwo+ ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Jpb3MuYwo+IEBAIC03NDAsNyArNzQw LDcgQEAgcGFyc2VfcHNyKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiwgY29uc3Qg c3RydWN0IGJkYl9oZWFkZXIgKmJkYikKPiAgCQkJZGV2X3ByaXYtPnZidC5wc3IudHAyX3RwM193 YWtldXBfdGltZV91cyA9IDEwMDsKPiAgCQkJYnJlYWs7Cj4gIAkJY2FzZSAzOgo+IC0JCQlkZXZf cHJpdi0+dmJ0LnBzci50cDFfd2FrZXVwX3RpbWVfdXMgPSAwOwo+ICsJCQlkZXZfcHJpdi0+dmJ0 LnBzci50cDJfdHAzX3dha2V1cF90aW1lX3VzID0gMDsKPiAgCQkJYnJlYWs7Cj4gIAkJZGVmYXVs dDoKPiAgCQkJRFJNX0RFQlVHX0tNUygiVkJUIHRwMl90cDMgd2FrZXVwIHRpbWUgdmFsdWUgJWQg aXMgb3V0c2lkZSByYW5nZVswLTNdLCBkZWZhdWx0aW5nIHRvIG1heCB2YWx1ZSAyNTAwdXNcbiIs Cj4gLS0gCj4gMi4xNy4wCj4gCj4gX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX18KPiBkcmktZGV2ZWwgbWFpbGluZyBsaXN0Cj4gZHJpLWRldmVsQGxpc3RzLmZy ZWVkZXNrdG9wLm9yZwo+IGh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlz dGluZm8vZHJpLWRldmVsCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9w Lm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVs LWdmeAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2BBE5C43140 for ; Wed, 20 Jun 2018 19:00:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E52DD20846 for ; Wed, 20 Jun 2018 19:00:05 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E52DD20846 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932568AbeFTTAD (ORCPT ); Wed, 20 Jun 2018 15:00:03 -0400 Received: from mga02.intel.com ([134.134.136.20]:28836 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932365AbeFTTAA (ORCPT ); Wed, 20 Jun 2018 15:00:00 -0400 X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 20 Jun 2018 11:59:59 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,248,1526367600"; d="scan'208";a="50920813" Received: from rdvivi-vienna.jf.intel.com (HELO intel.com) ([10.7.196.88]) by orsmga008.jf.intel.com with ESMTP; 20 Jun 2018 11:59:59 -0700 Date: Wed, 20 Jun 2018 11:59:56 -0700 From: Rodrigo Vivi To: Colin King Cc: Jani Nikula , Joonas Lahtinen , David Airlie , intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH][next] drm/i915/psr: fix copy-paste error with setting of tp2_wakeup_time_us Message-ID: <20180620185956.GB8258@intel.com> References: <20180620132543.28092-1-colin.king@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180620132543.28092-1-colin.king@canonical.com> User-Agent: Mutt/1.10.0 (2018-05-17) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jun 20, 2018 at 02:25:43PM +0100, Colin King wrote: > From: Colin Ian King > > Currently for the psr_table->tp2_tp3_wakeup_time case 3 there appears > to be a copy-paste error from the previous switch statement where > dev_priv->vbt.psr.tp1_wakeup_time_us is being assigned and I believe > it should be dev_priv->vbt.psr.tp2_tp3_wakeup_time_us that should be > assigned instead. > > Detected by CoverityScan, CID#1470105 ("Copy-paste error") > > Fixes: 77312ae8f071 ("drm/i915/psr: vbt change for psr") > Signed-off-by: Colin Ian King Reviewed-by: Rodrigo Vivi pushing to dinq now. thanks for the patch. > --- > drivers/gpu/drm/i915/intel_bios.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/intel_bios.c b/drivers/gpu/drm/i915/intel_bios.c > index 03f04b472394..e0a14be1080a 100644 > --- a/drivers/gpu/drm/i915/intel_bios.c > +++ b/drivers/gpu/drm/i915/intel_bios.c > @@ -740,7 +740,7 @@ parse_psr(struct drm_i915_private *dev_priv, const struct bdb_header *bdb) > dev_priv->vbt.psr.tp2_tp3_wakeup_time_us = 100; > break; > case 3: > - dev_priv->vbt.psr.tp1_wakeup_time_us = 0; > + dev_priv->vbt.psr.tp2_tp3_wakeup_time_us = 0; > break; > default: > DRM_DEBUG_KMS("VBT tp2_tp3 wakeup time value %d is outside range[0-3], defaulting to max value 2500us\n", > -- > 2.17.0 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel