From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rodrigo Vivi Subject: Re: [Intel-gfx] [PATCH] drm/i915: mark expected switch fall-through Date: Wed, 20 Jun 2018 12:06:28 -0700 Message-ID: <20180620190628.GC8258@intel.com> References: <20180620133100.GA608@embeddedor.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <20180620133100.GA608@embeddedor.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: "Gustavo A. R. Silva" Cc: David Airlie , intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org T24gV2VkLCBKdW4gMjAsIDIwMTggYXQgMDg6MzE6MDBBTSAtMDUwMCwgR3VzdGF2byBBLiBSLiBT aWx2YSB3cm90ZToKPiBJbiBwcmVwYXJhdGlvbiB0byBlbmFibGluZyAtV2ltcGxpY2l0LWZhbGx0 aHJvdWdoLCBtYXJrIHN3aXRjaCBjYXNlcwo+IHdoZXJlIHdlIGFyZSBleHBlY3RpbmcgdG8gZmFs bCB0aHJvdWdoLgo+IAo+IEFkZHJlc3Nlcy1Db3Zlcml0eS1JRDogMTQ3MDEwMiAoIk1pc3Npbmcg YnJlYWsgaW4gc3dpdGNoIikKCkFueSBvdGhlciBhZHZhbnRhZ2UgYmVzaWRlcyBjb3Zlcml0eT8K Q2FuJ3Qgd2UgYWRkcmVzcyBpdCBieSBtYXJraW5nIGFzICJJbnRlbnRpb25hbCIgb24gdGhlIHRv b2w/CgpJJ20gYWZyYWlkIHRoZXJlIHdpbGwgYmUgc28gbWFueSBtb3JlIHBsYWNlcyB0byBhZGQg ZmFsbHRocm91Z2gKbWFya3MuLi4uCgo+IFNpZ25lZC1vZmYtYnk6IEd1c3Rhdm8gQS4gUi4gU2ls dmEgPGd1c3Rhdm9AZW1iZWRkZWRvci5jb20+Cj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1 L2ludGVsX2RwbGxfbWdyLmMgfCAxICsKPiAgMSBmaWxlIGNoYW5nZWQsIDEgaW5zZXJ0aW9uKCsp Cj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RwbGxfbWdyLmMg Yi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcGxsX21nci5jCj4gaW5kZXggMTMyZmU2My4u NmE0MGE3NyAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcGxsX21n ci5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHBsbF9tZ3IuYwo+IEBAIC0y NTY2LDYgKzI1NjYsNyBAQCBpbnQgaWNsX2NhbGNfZHBfY29tYm9fcGxsX2xpbmsoc3RydWN0IGRy bV9pOTE1X3ByaXZhdGUgKmRldl9wcml2LAo+ICAJc3dpdGNoIChpbmRleCkgewo+ICAJZGVmYXVs dDoKPiAgCQlNSVNTSU5HX0NBU0UoaW5kZXgpOwo+ICsJCS8qIGZhbGwgdGhyb3VnaCAqLwo+ICAJ Y2FzZSAwOgo+ICAJCWxpbmtfY2xvY2sgPSA1NDAwMDA7Cj4gIAkJYnJlYWs7Cj4gLS0gCj4gMi43 LjQKPiAKPiBfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwo+ IEludGVsLWdmeCBtYWlsaW5nIGxpc3QKPiBJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3Jn Cj4gaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1n ZngKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRl dmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8v bGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 85A0EC43141 for ; Wed, 20 Jun 2018 19:06:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 43BC1208A4 for ; Wed, 20 Jun 2018 19:06:45 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 43BC1208A4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932802AbeFTTGn (ORCPT ); Wed, 20 Jun 2018 15:06:43 -0400 Received: from mga03.intel.com ([134.134.136.65]:14770 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932737AbeFTTGl (ORCPT ); Wed, 20 Jun 2018 15:06:41 -0400 X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 20 Jun 2018 12:06:40 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,248,1526367600"; d="scan'208";a="209762726" Received: from rdvivi-vienna.jf.intel.com (HELO intel.com) ([10.7.196.88]) by orsmga004.jf.intel.com with ESMTP; 20 Jun 2018 12:06:31 -0700 Date: Wed, 20 Jun 2018 12:06:28 -0700 From: Rodrigo Vivi To: "Gustavo A. R. Silva" Cc: Jani Nikula , Joonas Lahtinen , David Airlie , intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Subject: Re: [Intel-gfx] [PATCH] drm/i915: mark expected switch fall-through Message-ID: <20180620190628.GC8258@intel.com> References: <20180620133100.GA608@embeddedor.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180620133100.GA608@embeddedor.com> User-Agent: Mutt/1.10.0 (2018-05-17) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jun 20, 2018 at 08:31:00AM -0500, Gustavo A. R. Silva wrote: > In preparation to enabling -Wimplicit-fallthrough, mark switch cases > where we are expecting to fall through. > > Addresses-Coverity-ID: 1470102 ("Missing break in switch") Any other advantage besides coverity? Can't we address it by marking as "Intentional" on the tool? I'm afraid there will be so many more places to add fallthrough marks.... > Signed-off-by: Gustavo A. R. Silva > --- > drivers/gpu/drm/i915/intel_dpll_mgr.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/i915/intel_dpll_mgr.c b/drivers/gpu/drm/i915/intel_dpll_mgr.c > index 132fe63..6a40a77 100644 > --- a/drivers/gpu/drm/i915/intel_dpll_mgr.c > +++ b/drivers/gpu/drm/i915/intel_dpll_mgr.c > @@ -2566,6 +2566,7 @@ int icl_calc_dp_combo_pll_link(struct drm_i915_private *dev_priv, > switch (index) { > default: > MISSING_CASE(index); > + /* fall through */ > case 0: > link_clock = 540000; > break; > -- > 2.7.4 > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/intel-gfx