From: Rodrigo Vivi <rodrigo.vivi@intel.com>
To: "José Roberto de Souza" <jose.souza@intel.com>
Cc: dri-devel@lists.freedesktop.org
Subject: Re: [PATCH libdrm 2/2] intel: Introducing Amber Lake platform
Date: Wed, 20 Jun 2018 16:42:09 -0700 [thread overview]
Message-ID: <20180620234207.GG8258@intel.com> (raw)
In-Reply-To: <20180620233115.GE8258@intel.com>
On Wed, Jun 20, 2018 at 04:31:15PM -0700, Rodrigo Vivi wrote:
> On Tue, Jun 19, 2018 at 04:45:21PM -0700, José Roberto de Souza wrote:
> > Amber Lake uses the same gen graphics as Kaby Lake, including a id
> > that were previously marked as reserved on Kaby Lake, but that now is
> > moved to AML page.
> >
> > So, let's just move it to AML macro that will feed into KBL macro
> > just to keep it better organized to make easier future code review
> > but it will be handled as a KBL.
> >
> > This is a copy of merged i915's
> > commit e364672477a1 ("drm/i915/aml: Introducing Amber Lake platform")
> >
> > Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> > Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
>
> Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
>
> I just didn't push yet because I haven't migrated my system to
> new gitlab yet. And I wasn't able to login.
> I hope that someone else can push these 2 patches for now.
> I will try to get my gitlab account working later anyways...
nevermind. the reset pswd email finally arrived on my inbox
so gitlab up and running
patches pushed, thanks.
>
> Thanks,
> Rodrigo.
>
> > ---
> > intel/intel_chipset.h | 9 ++++++---
> > 1 file changed, 6 insertions(+), 3 deletions(-)
> >
> > diff --git a/intel/intel_chipset.h b/intel/intel_chipset.h
> > index 44e65f9e..583d6447 100644
> > --- a/intel/intel_chipset.h
> > +++ b/intel/intel_chipset.h
> > @@ -201,7 +201,6 @@
> > #define PCI_CHIP_KABYLAKE_ULX_GT1_5 0x5915
> > #define PCI_CHIP_KABYLAKE_ULX_GT1 0x590E
> > #define PCI_CHIP_KABYLAKE_ULX_GT2_0 0x591E
> > -#define PCI_CHIP_KABYLAKE_ULX_GT2_1 0x591C
> > #define PCI_CHIP_KABYLAKE_DT_GT2 0x5912
> > #define PCI_CHIP_KABYLAKE_M_GT2 0x5917
> > #define PCI_CHIP_KABYLAKE_DT_GT1 0x5902
> > @@ -213,6 +212,9 @@
> > #define PCI_CHIP_KABYLAKE_SRV_GT1 0x590A
> > #define PCI_CHIP_KABYLAKE_WKS_GT2 0x591D
> >
> > +#define PCI_CHIP_AMBERLAKE_ULX_GT2_1 0x591C
> > +#define PCI_CHIP_AMBERLAKE_ULX_GT2_2 0x87C0
> > +
> > #define PCI_CHIP_BROXTON_0 0x0A84
> > #define PCI_CHIP_BROXTON_1 0x1A84
> > #define PCI_CHIP_BROXTON_2 0x5A84
> > @@ -468,12 +470,13 @@
> > #define IS_KBL_GT2(devid) ((devid) == PCI_CHIP_KABYLAKE_ULT_GT2 || \
> > (devid) == PCI_CHIP_KABYLAKE_ULT_GT2F || \
> > (devid) == PCI_CHIP_KABYLAKE_ULX_GT2_0 || \
> > - (devid) == PCI_CHIP_KABYLAKE_ULX_GT2_1 || \
> > (devid) == PCI_CHIP_KABYLAKE_DT_GT2 || \
> > (devid) == PCI_CHIP_KABYLAKE_M_GT2 || \
> > (devid) == PCI_CHIP_KABYLAKE_HALO_GT2 || \
> > (devid) == PCI_CHIP_KABYLAKE_SRV_GT2 || \
> > - (devid) == PCI_CHIP_KABYLAKE_WKS_GT2)
> > + (devid) == PCI_CHIP_KABYLAKE_WKS_GT2 || \
> > + (devid) == PCI_CHIP_AMBERLAKE_ULX_GT2_1 || \
> > + (devid) == PCI_CHIP_AMBERLAKE_ULX_GT2_2)
> >
> > #define IS_KBL_GT3(devid) ((devid) == PCI_CHIP_KABYLAKE_ULT_GT3_0 || \
> > (devid) == PCI_CHIP_KABYLAKE_ULT_GT3_1 || \
> > --
> > 2.17.1
> >
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2018-06-20 23:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-19 23:45 [PATCH libdrm 1/2] intel: Introducing Whiskey Lake platform José Roberto de Souza
2018-06-19 23:45 ` [PATCH libdrm 2/2] intel: Introducing Amber " José Roberto de Souza
2018-06-20 23:31 ` Rodrigo Vivi
2018-06-20 23:42 ` Rodrigo Vivi [this message]
2018-06-20 23:29 ` [PATCH libdrm 1/2] intel: Introducing Whiskey " Rodrigo Vivi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180620234207.GG8258@intel.com \
--to=rodrigo.vivi@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=jose.souza@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.