From: Chris Opperman <eklikeroomys@gmail.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Kate Stewart <kstewart@linuxfoundation.org>,
devel@driverdev.osuosl.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org,
Philippe Ombredanne <pombredanne@nexb.com>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH] staging: wlan-ng: improved readability of function prism2_add_key
Date: Thu, 21 Jun 2018 06:42:52 +0200 [thread overview]
Message-ID: <20180621044252.GA19583@kerdev> (raw)
In-Reply-To: <20180620200829.qm2zxeyyl5kqh6gu@mwanda>
Hi Dan,
I agree completely. I was concerned whether the preprocessor definitions in
p80211metadef.h were named according to some convention as there are
many definitions named similarly there.
I am considering renaming this specific definition to "p80211_dot11_keyid",
would that be more acceptable?
Kind Regards,
Chris Opperman
next prev parent reply other threads:[~2018-06-21 4:44 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-20 17:10 [PATCH] staging: wlan-ng: improved readability of function prism2_add_key Chris Opperman
2018-06-20 20:08 ` Dan Carpenter
2018-06-21 4:42 ` Chris Opperman [this message]
2018-06-21 8:22 ` Dan Carpenter
2018-06-21 15:53 ` Chris Opperman
2018-06-22 10:46 ` Dan Carpenter
2018-06-22 15:12 ` Chris Opperman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180621044252.GA19583@kerdev \
--to=eklikeroomys@gmail.com \
--cc=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=kstewart@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pombredanne@nexb.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.