From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mx3-rdu2.redhat.com ([66.187.233.73] helo=mx1.redhat.com) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1fVv7u-0002Yl-JH for kexec@lists.infradead.org; Thu, 21 Jun 2018 08:39:43 +0000 Date: Thu, 21 Jun 2018 16:39:15 +0800 From: Baoquan He Subject: Re: [PATCH 3/4 V3] Remap the device table of IOMMU in encrypted manner for kdump Message-ID: <20180621083915.GE3815@MiWiFi-R3L-srv> References: <20180616082714.32035-1-lijiang@redhat.com> <20180616082714.32035-4-lijiang@redhat.com> <60c6f00e-0eb3-d39c-6a1e-8a1dc1e095af@amd.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "kexec" Errors-To: kexec-bounces+dwmw2=infradead.org@lists.infradead.org To: lijiang Cc: Tom Lendacky , iommu@lists.linux-foundation.org, dyoung@redhat.com, linux-kernel@vger.kernel.org, kexec@lists.infradead.org T24gMDYvMjEvMTggYXQgMDE6NDJwbSwgbGlqaWFuZyB3cm90ZToKPiDlnKggMjAxOOW5tDA25pyI MjHml6UgMDA6NDIsIFRvbSBMZW5kYWNreSDlhpnpgZM6Cj4gPiBPbiA2LzE2LzIwMTggMzoyNyBB TSwgTGlhbmJvIEppYW5nIHdyb3RlOgo+ID4+IEluIGtkdW1wIG1vZGUsIGl0IHdpbGwgY29weSB0 aGUgZGV2aWNlIHRhYmxlIG9mIElPTU1VIGZyb20gdGhlIG9sZAo+ID4+IGRldmljZSB0YWJsZSwg d2hpY2ggaXMgZW5jcnlwdGVkIHdoZW4gU01FIGlzIGVuYWJsZWQgaW4gdGhlIGZpcnN0Cj4gPj4g a2VybmVsLiBTbyB3ZSBtdXN0IHJlbWFwIGl0IGluIGVuY3J5cHRlZCBtYW5uZXIgaW4gb3JkZXIg dG8gYmUKPiA+PiBhdXRvbWF0aWNhbGx5IGRlY3J5cHRlZCB3aGVuIHdlIHJlYWQuCj4gPj4KPiA+ PiBTaWduZWQtb2ZmLWJ5OiBMaWFuYm8gSmlhbmcgPGxpamlhbmdAcmVkaGF0LmNvbT4KPiA+PiAt LS0KPiA+PiBTb21lIGNoYW5nZXM6Cj4gPj4gMS4gYWRkIHNvbWUgY29tbWVudHMKPiA+PiAyLiBj bGVhbiBjb21waWxlIHdhcm5pbmcuCj4gPj4KPiA+PiAgZHJpdmVycy9pb21tdS9hbWRfaW9tbXVf aW5pdC5jIHwgMTUgKysrKysrKysrKysrKystCj4gPj4gIDEgZmlsZSBjaGFuZ2VkLCAxNCBpbnNl cnRpb25zKCspLCAxIGRlbGV0aW9uKC0pCj4gPj4KPiA+PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9p b21tdS9hbWRfaW9tbXVfaW5pdC5jIGIvZHJpdmVycy9pb21tdS9hbWRfaW9tbXVfaW5pdC5jCj4g Pj4gaW5kZXggOTA0YzU3NS4uYTIwYWY0YyAxMDA2NDQKPiA+PiAtLS0gYS9kcml2ZXJzL2lvbW11 L2FtZF9pb21tdV9pbml0LmMKPiA+PiArKysgYi9kcml2ZXJzL2lvbW11L2FtZF9pb21tdV9pbml0 LmMKPiA+PiBAQCAtODg5LDExICs4ODksMjQgQEAgc3RhdGljIGJvb2wgY29weV9kZXZpY2VfdGFi bGUodm9pZCkKPiA+PiAgCX0KPiA+PiAgCj4gPj4gIAlvbGRfZGV2dGJfcGh5cyA9IGVudHJ5ICYg UEFHRV9NQVNLOwo+ID4+ICsKPiA+PiArCS8qCj4gPj4gKwkgKiAgV2hlbiBzbWUgZW5hYmxlIGlu IHRoZSBmaXJzdCBrZXJuZWwsIG9sZF9kZXZ0Yl9waHlzIGluY2x1ZGVzIHRoZQo+ID4+ICsJICog IG1lbW9yeSBlbmNyeXB0aW9uIG1hc2soc21lX21lX21hc2spLCB3ZSBtdXN0IHJlbW92ZSB0aGUg bWVtb3J5Cj4gPj4gKwkgKiAgZW5jcnlwdGlvbiBtYXNrIHRvIG9idGFpbiB0aGUgdHJ1ZSBwaHlz aWNhbCBhZGRyZXNzIGluIGtkdW1wIG1vZGUuCj4gPj4gKwkgKi8KPiA+PiArCWlmIChtZW1fZW5j cnlwdF9hY3RpdmUoKSAmJiBpc19rZHVtcF9rZXJuZWwoKSkKPiA+PiArCQlvbGRfZGV2dGJfcGh5 cyA9IF9fc21lX2NscihvbGRfZGV2dGJfcGh5cyk7Cj4gPj4gKwo+ID4gCj4gPiBZb3UgY2FuIHBy b2JhYmx5IGp1c3QgdXNlICJpZiAoaXNfa2R1bXBfa2VybmVsKCkpIiBoZXJlLCBzaW5jZSBtZW1v cnkKPiA+IGVuY3J5cHRpb24gaXMgZWl0aGVyIG9uIGluIGJvdGggdGhlIGZpcnN0IGFuZCBzZWNv bmQga2VybmVsIG9yIG9mZiBpbgo+ID4gYm90aCB0aGUgZmlyc3QgYW5kIHNlY29uZCBrZXJuZWwu ICBBdCB3aGljaCBwb2ludCBfX3NtZV9jbHIoKSB3aWxsIGRvCj4gPiB0aGUgcHJvcGVyIHRoaW5n Lgo+ID4gCj4gPiBBY3R1YWxseSwgdGhpcyBuZWVkcyB0byBiZSBkb25lIG5vIG1hdHRlciB3aGF0 LiAgV2hlbiBkb2luZyBlaXRoZXIgdGhlCj4gPiBpb3JlbWFwX2VuY3J5cHRlZCgpIG9yIHRoZSBt ZW1yZW1hcCgpLCB0aGUgcGh5c2ljYWwgYWRkcmVzcyBzaG91bGQgbm90Cj4gPiBpbmNsdWRlIHRo ZSBlbmNyeXB0aW9uIGJpdC9tYXNrLgo+ID4gCj4gPiBUaGFua3MsCj4gPiBUb20KPiA+IAo+IFRo YW5rcyBmb3IgeW91ciBjb21tZW50cy4gSWYgd2UgZG9uJ3QgcmVtb3ZlIHRoZSBtZW1vcnkgZW5j cnlwdGlvbiBtYXNrLCBpdCB3aWxsCj4gcmV0dXJuIGZhbHNlIGJlY2F1c2UgdGhlICdvbGRfZGV2 dGJfcGh5cyA+PSAweDEwMDAwMDAwMFVMTCcgbWF5IGJlY29tZSB0cnVlLgoKTGlhbmJvLCB5b3Ug bWF5IG5vdCBnZXQgd2hhdCBUb20gc3VnZ2VzdGVkLiBUb20gbWVhbnMgbm8gbWF0dGVyIHdoYXQg aXQKaXMsIGVuY3J5cHRlZCBvciBub3QgaW4gMXN0IGtlcm5lbCwgd2UgbmVlZCBnZXQgcHVyZSBw aHlzaWNhbGwgYWRkcmVzcywKYW5kIHVzaW5nIGJlbG93IGNvZGUgaXMgYWx3YXlzIHJpZ2h0IGZv ciBib3RoIGNhc2VzLgoKCWlmIChpc19rZHVtcF9rZXJuZWwoKSkKCQlvbGRfZGV2dGJfcGh5cyA9 IF9fc21lX2NscihvbGRfZGV2dGJfcGh5cyk7CgpBbmQgdGhpcyBpcyBzaW1wbGVyLiBZb3UgZXZl biBjYW4gYWRkIG9uZSBsaW5lIG9mIGNvZGUgY29tbWVudCB0byBzYXkKbGlrZSAiUGh5c2ljYWwg YWRkcmVzcyB3L28gZW5jcnlwdGlvbiBtYXNrIGlzIG5lZWRlZCBoZXJlLiIKPiAKPiBMaWFuYm8K PiA+PiAgCWlmIChvbGRfZGV2dGJfcGh5cyA+PSAweDEwMDAwMDAwMFVMTCkgewo+ID4+ICAJCXBy X2VycigiVGhlIGFkZHJlc3Mgb2Ygb2xkIGRldmljZSB0YWJsZSBpcyBhYm92ZSA0Rywgbm90IHRy dXN0d29ydGh5IVxuIik7Cj4gPj4gIAkJcmV0dXJuIGZhbHNlOwo+ID4+ICAJfQo+ID4+IC0Jb2xk X2RldnRiID0gbWVtcmVtYXAob2xkX2RldnRiX3BoeXMsIGRldl90YWJsZV9zaXplLCBNRU1SRU1B UF9XQik7Cj4gPj4gKwlvbGRfZGV2dGIgPSAobWVtX2VuY3J5cHRfYWN0aXZlKCkgJiYgaXNfa2R1 bXBfa2VybmVsKCkpCj4gPj4gKwkJICAgID8gKF9fZm9yY2Ugdm9pZCAqKWlvcmVtYXBfZW5jcnlw dGVkKG9sZF9kZXZ0Yl9waHlzLAo+ID4+ICsJCQkJCQkJZGV2X3RhYmxlX3NpemUpCj4gPj4gKwkJ ICAgIDogbWVtcmVtYXAob2xkX2RldnRiX3BoeXMsIGRldl90YWJsZV9zaXplLCBNRU1SRU1BUF9X Qik7PiArCj4gPj4gIAlpZiAoIW9sZF9kZXZ0YikKPiA+PiAgCQlyZXR1cm4gZmFsc2U7Cj4gPj4g IAo+ID4+Cj4gCj4gX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X18KPiBrZXhlYyBtYWlsaW5nIGxpc3QKPiBrZXhlY0BsaXN0cy5pbmZyYWRlYWQub3JnCj4gaHR0 cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9rZXhlYwoKX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18Ka2V4ZWMgbWFpbGluZyBsaXN0 CmtleGVjQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFp bG1hbi9saXN0aW5mby9rZXhlYwo= From mboxrd@z Thu Jan 1 00:00:00 1970 From: Baoquan He Subject: Re: [PATCH 3/4 V3] Remap the device table of IOMMU in encrypted manner for kdump Date: Thu, 21 Jun 2018 16:39:15 +0800 Message-ID: <20180621083915.GE3815@MiWiFi-R3L-srv> References: <20180616082714.32035-1-lijiang@redhat.com> <20180616082714.32035-4-lijiang@redhat.com> <60c6f00e-0eb3-d39c-6a1e-8a1dc1e095af@amd.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: lijiang Cc: Tom Lendacky , iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, dyoung-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, kexec-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: iommu@lists.linux-foundation.org T24gMDYvMjEvMTggYXQgMDE6NDJwbSwgbGlqaWFuZyB3cm90ZToKPiDlnKggMjAxOOW5tDA25pyI MjHml6UgMDA6NDIsIFRvbSBMZW5kYWNreSDlhpnpgZM6Cj4gPiBPbiA2LzE2LzIwMTggMzoyNyBB TSwgTGlhbmJvIEppYW5nIHdyb3RlOgo+ID4+IEluIGtkdW1wIG1vZGUsIGl0IHdpbGwgY29weSB0 aGUgZGV2aWNlIHRhYmxlIG9mIElPTU1VIGZyb20gdGhlIG9sZAo+ID4+IGRldmljZSB0YWJsZSwg d2hpY2ggaXMgZW5jcnlwdGVkIHdoZW4gU01FIGlzIGVuYWJsZWQgaW4gdGhlIGZpcnN0Cj4gPj4g a2VybmVsLiBTbyB3ZSBtdXN0IHJlbWFwIGl0IGluIGVuY3J5cHRlZCBtYW5uZXIgaW4gb3JkZXIg dG8gYmUKPiA+PiBhdXRvbWF0aWNhbGx5IGRlY3J5cHRlZCB3aGVuIHdlIHJlYWQuCj4gPj4KPiA+ PiBTaWduZWQtb2ZmLWJ5OiBMaWFuYm8gSmlhbmcgPGxpamlhbmdAcmVkaGF0LmNvbT4KPiA+PiAt LS0KPiA+PiBTb21lIGNoYW5nZXM6Cj4gPj4gMS4gYWRkIHNvbWUgY29tbWVudHMKPiA+PiAyLiBj bGVhbiBjb21waWxlIHdhcm5pbmcuCj4gPj4KPiA+PiAgZHJpdmVycy9pb21tdS9hbWRfaW9tbXVf aW5pdC5jIHwgMTUgKysrKysrKysrKysrKystCj4gPj4gIDEgZmlsZSBjaGFuZ2VkLCAxNCBpbnNl cnRpb25zKCspLCAxIGRlbGV0aW9uKC0pCj4gPj4KPiA+PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9p b21tdS9hbWRfaW9tbXVfaW5pdC5jIGIvZHJpdmVycy9pb21tdS9hbWRfaW9tbXVfaW5pdC5jCj4g Pj4gaW5kZXggOTA0YzU3NS4uYTIwYWY0YyAxMDA2NDQKPiA+PiAtLS0gYS9kcml2ZXJzL2lvbW11 L2FtZF9pb21tdV9pbml0LmMKPiA+PiArKysgYi9kcml2ZXJzL2lvbW11L2FtZF9pb21tdV9pbml0 LmMKPiA+PiBAQCAtODg5LDExICs4ODksMjQgQEAgc3RhdGljIGJvb2wgY29weV9kZXZpY2VfdGFi bGUodm9pZCkKPiA+PiAgCX0KPiA+PiAgCj4gPj4gIAlvbGRfZGV2dGJfcGh5cyA9IGVudHJ5ICYg UEFHRV9NQVNLOwo+ID4+ICsKPiA+PiArCS8qCj4gPj4gKwkgKiAgV2hlbiBzbWUgZW5hYmxlIGlu IHRoZSBmaXJzdCBrZXJuZWwsIG9sZF9kZXZ0Yl9waHlzIGluY2x1ZGVzIHRoZQo+ID4+ICsJICog IG1lbW9yeSBlbmNyeXB0aW9uIG1hc2soc21lX21lX21hc2spLCB3ZSBtdXN0IHJlbW92ZSB0aGUg bWVtb3J5Cj4gPj4gKwkgKiAgZW5jcnlwdGlvbiBtYXNrIHRvIG9idGFpbiB0aGUgdHJ1ZSBwaHlz aWNhbCBhZGRyZXNzIGluIGtkdW1wIG1vZGUuCj4gPj4gKwkgKi8KPiA+PiArCWlmIChtZW1fZW5j cnlwdF9hY3RpdmUoKSAmJiBpc19rZHVtcF9rZXJuZWwoKSkKPiA+PiArCQlvbGRfZGV2dGJfcGh5 cyA9IF9fc21lX2NscihvbGRfZGV2dGJfcGh5cyk7Cj4gPj4gKwo+ID4gCj4gPiBZb3UgY2FuIHBy b2JhYmx5IGp1c3QgdXNlICJpZiAoaXNfa2R1bXBfa2VybmVsKCkpIiBoZXJlLCBzaW5jZSBtZW1v cnkKPiA+IGVuY3J5cHRpb24gaXMgZWl0aGVyIG9uIGluIGJvdGggdGhlIGZpcnN0IGFuZCBzZWNv bmQga2VybmVsIG9yIG9mZiBpbgo+ID4gYm90aCB0aGUgZmlyc3QgYW5kIHNlY29uZCBrZXJuZWwu ICBBdCB3aGljaCBwb2ludCBfX3NtZV9jbHIoKSB3aWxsIGRvCj4gPiB0aGUgcHJvcGVyIHRoaW5n Lgo+ID4gCj4gPiBBY3R1YWxseSwgdGhpcyBuZWVkcyB0byBiZSBkb25lIG5vIG1hdHRlciB3aGF0 LiAgV2hlbiBkb2luZyBlaXRoZXIgdGhlCj4gPiBpb3JlbWFwX2VuY3J5cHRlZCgpIG9yIHRoZSBt ZW1yZW1hcCgpLCB0aGUgcGh5c2ljYWwgYWRkcmVzcyBzaG91bGQgbm90Cj4gPiBpbmNsdWRlIHRo ZSBlbmNyeXB0aW9uIGJpdC9tYXNrLgo+ID4gCj4gPiBUaGFua3MsCj4gPiBUb20KPiA+IAo+IFRo YW5rcyBmb3IgeW91ciBjb21tZW50cy4gSWYgd2UgZG9uJ3QgcmVtb3ZlIHRoZSBtZW1vcnkgZW5j cnlwdGlvbiBtYXNrLCBpdCB3aWxsCj4gcmV0dXJuIGZhbHNlIGJlY2F1c2UgdGhlICdvbGRfZGV2 dGJfcGh5cyA+PSAweDEwMDAwMDAwMFVMTCcgbWF5IGJlY29tZSB0cnVlLgoKTGlhbmJvLCB5b3Ug bWF5IG5vdCBnZXQgd2hhdCBUb20gc3VnZ2VzdGVkLiBUb20gbWVhbnMgbm8gbWF0dGVyIHdoYXQg aXQKaXMsIGVuY3J5cHRlZCBvciBub3QgaW4gMXN0IGtlcm5lbCwgd2UgbmVlZCBnZXQgcHVyZSBw aHlzaWNhbGwgYWRkcmVzcywKYW5kIHVzaW5nIGJlbG93IGNvZGUgaXMgYWx3YXlzIHJpZ2h0IGZv ciBib3RoIGNhc2VzLgoKCWlmIChpc19rZHVtcF9rZXJuZWwoKSkKCQlvbGRfZGV2dGJfcGh5cyA9 IF9fc21lX2NscihvbGRfZGV2dGJfcGh5cyk7CgpBbmQgdGhpcyBpcyBzaW1wbGVyLiBZb3UgZXZl biBjYW4gYWRkIG9uZSBsaW5lIG9mIGNvZGUgY29tbWVudCB0byBzYXkKbGlrZSAiUGh5c2ljYWwg YWRkcmVzcyB3L28gZW5jcnlwdGlvbiBtYXNrIGlzIG5lZWRlZCBoZXJlLiIKPiAKPiBMaWFuYm8K PiA+PiAgCWlmIChvbGRfZGV2dGJfcGh5cyA+PSAweDEwMDAwMDAwMFVMTCkgewo+ID4+ICAJCXBy X2VycigiVGhlIGFkZHJlc3Mgb2Ygb2xkIGRldmljZSB0YWJsZSBpcyBhYm92ZSA0Rywgbm90IHRy dXN0d29ydGh5IVxuIik7Cj4gPj4gIAkJcmV0dXJuIGZhbHNlOwo+ID4+ICAJfQo+ID4+IC0Jb2xk X2RldnRiID0gbWVtcmVtYXAob2xkX2RldnRiX3BoeXMsIGRldl90YWJsZV9zaXplLCBNRU1SRU1B UF9XQik7Cj4gPj4gKwlvbGRfZGV2dGIgPSAobWVtX2VuY3J5cHRfYWN0aXZlKCkgJiYgaXNfa2R1 bXBfa2VybmVsKCkpCj4gPj4gKwkJICAgID8gKF9fZm9yY2Ugdm9pZCAqKWlvcmVtYXBfZW5jcnlw dGVkKG9sZF9kZXZ0Yl9waHlzLAo+ID4+ICsJCQkJCQkJZGV2X3RhYmxlX3NpemUpCj4gPj4gKwkJ ICAgIDogbWVtcmVtYXAob2xkX2RldnRiX3BoeXMsIGRldl90YWJsZV9zaXplLCBNRU1SRU1BUF9X Qik7PiArCj4gPj4gIAlpZiAoIW9sZF9kZXZ0YikKPiA+PiAgCQlyZXR1cm4gZmFsc2U7Cj4gPj4g IAo+ID4+Cj4gCj4gX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X18KPiBrZXhlYyBtYWlsaW5nIGxpc3QKPiBrZXhlY0BsaXN0cy5pbmZyYWRlYWQub3JnCj4gaHR0 cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9rZXhlYwpfX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwppb21tdSBtYWlsaW5nIGxpc3QK aW9tbXVAbGlzdHMubGludXgtZm91bmRhdGlvbi5vcmcKaHR0cHM6Ly9saXN0cy5saW51eGZvdW5k YXRpb24ub3JnL21haWxtYW4vbGlzdGluZm8vaW9tbXU= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6C672C43141 for ; Thu, 21 Jun 2018 08:39:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 30D52208A1 for ; Thu, 21 Jun 2018 08:39:29 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 30D52208A1 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932752AbeFUIj0 (ORCPT ); Thu, 21 Jun 2018 04:39:26 -0400 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:53466 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754334AbeFUIjV (ORCPT ); Thu, 21 Jun 2018 04:39:21 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 394B14023336; Thu, 21 Jun 2018 08:39:20 +0000 (UTC) Received: from localhost (ovpn-8-18.pek2.redhat.com [10.72.8.18]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 355FE2026D6B; Thu, 21 Jun 2018 08:39:18 +0000 (UTC) Date: Thu, 21 Jun 2018 16:39:15 +0800 From: Baoquan He To: lijiang Cc: Tom Lendacky , linux-kernel@vger.kernel.org, dyoung@redhat.com, iommu@lists.linux-foundation.org, kexec@lists.infradead.org Subject: Re: [PATCH 3/4 V3] Remap the device table of IOMMU in encrypted manner for kdump Message-ID: <20180621083915.GE3815@MiWiFi-R3L-srv> References: <20180616082714.32035-1-lijiang@redhat.com> <20180616082714.32035-4-lijiang@redhat.com> <60c6f00e-0eb3-d39c-6a1e-8a1dc1e095af@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.9.1 (2017-09-22) X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.6]); Thu, 21 Jun 2018 08:39:20 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.6]); Thu, 21 Jun 2018 08:39:20 +0000 (UTC) for IP:'10.11.54.4' DOMAIN:'int-mx04.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'bhe@redhat.com' RCPT:'' Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/21/18 at 01:42pm, lijiang wrote: > 在 2018年06月21日 00:42, Tom Lendacky 写道: > > On 6/16/2018 3:27 AM, Lianbo Jiang wrote: > >> In kdump mode, it will copy the device table of IOMMU from the old > >> device table, which is encrypted when SME is enabled in the first > >> kernel. So we must remap it in encrypted manner in order to be > >> automatically decrypted when we read. > >> > >> Signed-off-by: Lianbo Jiang > >> --- > >> Some changes: > >> 1. add some comments > >> 2. clean compile warning. > >> > >> drivers/iommu/amd_iommu_init.c | 15 ++++++++++++++- > >> 1 file changed, 14 insertions(+), 1 deletion(-) > >> > >> diff --git a/drivers/iommu/amd_iommu_init.c b/drivers/iommu/amd_iommu_init.c > >> index 904c575..a20af4c 100644 > >> --- a/drivers/iommu/amd_iommu_init.c > >> +++ b/drivers/iommu/amd_iommu_init.c > >> @@ -889,11 +889,24 @@ static bool copy_device_table(void) > >> } > >> > >> old_devtb_phys = entry & PAGE_MASK; > >> + > >> + /* > >> + * When sme enable in the first kernel, old_devtb_phys includes the > >> + * memory encryption mask(sme_me_mask), we must remove the memory > >> + * encryption mask to obtain the true physical address in kdump mode. > >> + */ > >> + if (mem_encrypt_active() && is_kdump_kernel()) > >> + old_devtb_phys = __sme_clr(old_devtb_phys); > >> + > > > > You can probably just use "if (is_kdump_kernel())" here, since memory > > encryption is either on in both the first and second kernel or off in > > both the first and second kernel. At which point __sme_clr() will do > > the proper thing. > > > > Actually, this needs to be done no matter what. When doing either the > > ioremap_encrypted() or the memremap(), the physical address should not > > include the encryption bit/mask. > > > > Thanks, > > Tom > > > Thanks for your comments. If we don't remove the memory encryption mask, it will > return false because the 'old_devtb_phys >= 0x100000000ULL' may become true. Lianbo, you may not get what Tom suggested. Tom means no matter what it is, encrypted or not in 1st kernel, we need get pure physicall address, and using below code is always right for both cases. if (is_kdump_kernel()) old_devtb_phys = __sme_clr(old_devtb_phys); And this is simpler. You even can add one line of code comment to say like "Physical address w/o encryption mask is needed here." > > Lianbo > >> if (old_devtb_phys >= 0x100000000ULL) { > >> pr_err("The address of old device table is above 4G, not trustworthy!\n"); > >> return false; > >> } > >> - old_devtb = memremap(old_devtb_phys, dev_table_size, MEMREMAP_WB); > >> + old_devtb = (mem_encrypt_active() && is_kdump_kernel()) > >> + ? (__force void *)ioremap_encrypted(old_devtb_phys, > >> + dev_table_size) > >> + : memremap(old_devtb_phys, dev_table_size, MEMREMAP_WB);> + > >> if (!old_devtb) > >> return false; > >> > >> > > _______________________________________________ > kexec mailing list > kexec@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/kexec