From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 728C5C43140 for ; Thu, 21 Jun 2018 09:51:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 317E8208A1 for ; Thu, 21 Jun 2018 09:51:48 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 317E8208A1 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=techsingularity.net Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932939AbeFUJvq (ORCPT ); Thu, 21 Jun 2018 05:51:46 -0400 Received: from outbound-smtp27.blacknight.com ([81.17.249.195]:55679 "EHLO outbound-smtp27.blacknight.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932677AbeFUJvp (ORCPT ); Thu, 21 Jun 2018 05:51:45 -0400 Received: from mail.blacknight.com (pemlinmail05.blacknight.ie [81.17.254.26]) by outbound-smtp27.blacknight.com (Postfix) with ESMTPS id 0A47EB8A96 for ; Thu, 21 Jun 2018 10:51:44 +0100 (IST) Received: (qmail 10301 invoked from network); 21 Jun 2018 09:51:43 -0000 Received: from unknown (HELO techsingularity.net) (mgorman@techsingularity.net@[37.228.237.171]) by 81.17.254.9 with ESMTPSA (DHE-RSA-AES256-SHA encrypted, authenticated); 21 Jun 2018 09:51:43 -0000 Date: Thu, 21 Jun 2018 10:51:43 +0100 From: Mel Gorman To: Srikar Dronamraju Cc: Ingo Molnar , Peter Zijlstra , LKML , Rik van Riel , Thomas Gleixner Subject: Re: [PATCH v2 14/19] sched/numa: Updation of scan period need not be in lock Message-ID: <20180621095143.4a4ikeffphcz7ruw@techsingularity.net> References: <1529514181-9842-1-git-send-email-srikar@linux.vnet.ibm.com> <1529514181-9842-15-git-send-email-srikar@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <1529514181-9842-15-git-send-email-srikar@linux.vnet.ibm.com> User-Agent: NeoMutt/20170912 (1.9.0) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jun 20, 2018 at 10:32:55PM +0530, Srikar Dronamraju wrote: > The metrics for updating scan periods are local or task specific. > Currently this updation happens under numa_group lock which seems > unnecessary. Hence move this updation outside the lock. > > Running SPECjbb2005 on a 4 node machine and comparing bops/JVM > JVMS LAST_PATCH WITH_PATCH %CHANGE > 16 25355.9 25645.4 1.141 > 1 72812 72142 -0.92 > > Reviewed-by: Rik van Riel > Signed-off-by: Srikar Dronamraju Acked-by: Mel Gorman -- Mel Gorman SUSE Labs