From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mx3-rdu2.redhat.com ([66.187.233.73] helo=mx1.redhat.com) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1fVwkb-00008o-OZ for kexec@lists.infradead.org; Thu, 21 Jun 2018 10:23:39 +0000 Date: Thu, 21 Jun 2018 18:23:21 +0800 From: Baoquan He Subject: Re: [PATCH 2/4 V3] Allocate pages for kdump without encryption when SME is enabled Message-ID: <20180621102321.GK29979@MiWiFi-R3L-srv> References: <20180616082714.32035-1-lijiang@redhat.com> <20180616082714.32035-3-lijiang@redhat.com> <20180621015306.GG29979@MiWiFi-R3L-srv> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "kexec" Errors-To: kexec-bounces+dwmw2=infradead.org@lists.infradead.org To: lijiang Cc: thomas.lendacky@amd.com, iommu@lists.linux-foundation.org, dyoung@redhat.com, linux-kernel@vger.kernel.org, kexec@lists.infradead.org T24gMDYvMjEvMTggYXQgMDE6MDZwbSwgbGlqaWFuZyB3cm90ZToKPiDlnKggMjAxOOW5tDA25pyI MjHml6UgMDk6NTMsIEJhb3F1YW4gSGUg5YaZ6YGTOgo+ID4gT24gMDYvMTYvMTggYXQgMDQ6Mjdw bSwgTGlhbmJvIEppYW5nIHdyb3RlOgo+ID4+IFdoZW4gU01FIGlzIGVuYWJsZWQgaW4gdGhlIGZp cnN0IGtlcm5lbCwgd2Ugd2lsbCBhbGxvY2F0ZSBwYWdlcwo+ID4+IGZvciBrZHVtcCB3aXRob3V0 IGVuY3J5cHRpb24gaW4gb3JkZXIgdG8gYmUgYWJsZSB0byBib290IHRoZQo+ID4+IHNlY29uZCBr ZXJuZWwgaW4gdGhlIHNhbWUgbWFubmVyIGFzIGtleGVjLCB3aGljaCBoZWxwcyB0byBrZWVwCj4g Pj4gdGhlIHNhbWUgY29kZSBzdHlsZS4KPiA+Pgo+ID4+IFNpZ25lZC1vZmYtYnk6IExpYW5ibyBK aWFuZyA8bGlqaWFuZ0ByZWRoYXQuY29tPgo+ID4+IC0tLQo+ID4+ICBrZXJuZWwva2V4ZWNfY29y ZS5jIHwgMTIgKysrKysrKysrKysrCj4gPj4gIDEgZmlsZSBjaGFuZ2VkLCAxMiBpbnNlcnRpb25z KCspCj4gPj4KPiA+PiBkaWZmIC0tZ2l0IGEva2VybmVsL2tleGVjX2NvcmUuYyBiL2tlcm5lbC9r ZXhlY19jb3JlLmMKPiA+PiBpbmRleCAyMGZlZjFhLi4zYzIyYTliIDEwMDY0NAo+ID4+IC0tLSBh L2tlcm5lbC9rZXhlY19jb3JlLmMKPiA+PiArKysgYi9rZXJuZWwva2V4ZWNfY29yZS5jCj4gPj4g QEAgLTQ3MSw2ICs0NzEsMTYgQEAgc3RhdGljIHN0cnVjdCBwYWdlICpraW1hZ2VfYWxsb2NfY3Jh c2hfY29udHJvbF9wYWdlcyhzdHJ1Y3Qga2ltYWdlICppbWFnZSwKPiA+PiAgCQl9Cj4gPj4gIAl9 Cj4gPj4gIAo+ID4+ICsJaWYgKHBhZ2VzKSB7Cj4gPj4gKwkJdW5zaWduZWQgaW50IGNvdW50LCBp Owo+ID4+ICsKPiA+PiArCQlwYWdlcy0+bWFwcGluZyA9IE5VTEw7Cj4gPj4gKwkJc2V0X3BhZ2Vf cHJpdmF0ZShwYWdlcywgb3JkZXIpOwo+ID4+ICsJCWNvdW50ID0gMSA8PCBvcmRlcjsKPiA+PiAr CQlmb3IgKGkgPSAwOyBpIDwgY291bnQ7IGkrKykKPiA+PiArCQkJU2V0UGFnZVJlc2VydmVkKHBh Z2VzICsgaSk7Cj4gPiAKPiA+IEkgZ3Vlc3MgeW91IG1pZ2h0IGltaXRhdGUgdGhlIGtleGVjIGNh c2UsIGhvd2V2ZXIga2V4ZWMgZ2V0IHBhZ2VzIGZyb20KPiA+IGJ1ZGR5LiBDcmFzaCBwYWdlcyBh cmUgcmVzZXJ2ZWQgaW4gbWVtYmxvY2ssIHRoZXNlIGNvZGVzIG1pZ2h0IG1ha2Ugbm8gc2Vuc2Uu Cj4gPiAKPiBUaGFua3MgZm9yIHlvdXIgY29tbWVudHMuCj4gV2UgaGF2ZSBjaGFuZ2VkIHRoZSBh dHRyaWJ1dGUgb2YgcGFnZXMsIHNvIHRoZSBvcmlnaW5hbCBhdHRyaWJ1dGUgb2YgcGFnZXMgd2ls bCBiZQo+IHJlc3RvcmVkIHdoZW4gdGhleSBmcmVlLgoKSG1tLCB5b3UgY2FuIGNoZWNrIHdoYXQg a2ltYWdlX2ZyZWUoKSBpcyBkb2luZywgYW5kIHdoZXJlCmtpbWFnZS0+Y29udHJvbF9wYWdlcywg ZGVzdF9wYWdlcywgdW51c2FibGVfcGFnZXMgaXMgYXNzaWduZWQuIERvIHlvdQprbm93IHdoZXJl IHRoZXNlIG9yaWdpbmFsIGF0dHJpYnV0ZSBvZiBwYWdlcyBjb21lcyBmcm9tIGFuZCB0aGV5IGFy ZQp1c2VkL25lZWRlZCBpbiBDUkFTSCBjYXNlLCBpZiB5b3UgY2FyZSBhYm91dCB0aGVtPwoKPiAK PiA+PiArCQlhcmNoX2tleGVjX3Bvc3RfYWxsb2NfcGFnZXMocGFnZV9hZGRyZXNzKHBhZ2VzKSwg MSA8PCBvcmRlciwgMCk7Cj4gPj4gKwl9Cj4gPj4gIAlyZXR1cm4gcGFnZXM7Cj4gPj4gIH0KPiA+ PiAgCj4gPj4gQEAgLTg2NSw2ICs4NzUsNyBAQCBzdGF0aWMgaW50IGtpbWFnZV9sb2FkX2NyYXNo X3NlZ21lbnQoc3RydWN0IGtpbWFnZSAqaW1hZ2UsCj4gPj4gIAkJCXJlc3VsdCAgPSAtRU5PTUVN Owo+ID4+ICAJCQlnb3RvIG91dDsKPiA+PiAgCQl9Cj4gPj4gKwkJYXJjaF9rZXhlY19wb3N0X2Fs bG9jX3BhZ2VzKHBhZ2VfYWRkcmVzcyhwYWdlKSwgMSwgMCk7Cj4gPj4gIAkJcHRyID0ga21hcChw YWdlKTsKPiA+PiAgCQlwdHIgKz0gbWFkZHIgJiB+UEFHRV9NQVNLOwo+ID4+ICAJCW1jaHVuayA9 IG1pbl90KHNpemVfdCwgbWJ5dGVzLAo+ID4+IEBAIC04ODIsNiArODkzLDcgQEAgc3RhdGljIGlu dCBraW1hZ2VfbG9hZF9jcmFzaF9zZWdtZW50KHN0cnVjdCBraW1hZ2UgKmltYWdlLAo+ID4+ICAJ CQlyZXN1bHQgPSBjb3B5X2Zyb21fdXNlcihwdHIsIGJ1ZiwgdWNodW5rKTsKPiA+PiAgCQlrZXhl Y19mbHVzaF9pY2FjaGVfcGFnZShwYWdlKTsKPiA+PiAgCQlrdW5tYXAocGFnZSk7Cj4gPj4gKwkJ YXJjaF9rZXhlY19wcmVfZnJlZV9wYWdlcyhwYWdlX2FkZHJlc3MocGFnZSksIDEpOwo+ID4+ICAJ CWlmIChyZXN1bHQpIHsKPiA+PiAgCQkJcmVzdWx0ID0gLUVGQVVMVDsKPiA+PiAgCQkJZ290byBv dXQ7Cj4gPj4gLS0gCj4gPj4gMi45LjUKPiA+Pgo+ID4+Cj4gPj4gX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX18KPiA+PiBrZXhlYyBtYWlsaW5nIGxpc3QKPiA+ PiBrZXhlY0BsaXN0cy5pbmZyYWRlYWQub3JnCj4gPj4gaHR0cDovL2xpc3RzLmluZnJhZGVhZC5v cmcvbWFpbG1hbi9saXN0aW5mby9rZXhlYwoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX18Ka2V4ZWMgbWFpbGluZyBsaXN0CmtleGVjQGxpc3RzLmluZnJhZGVh ZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9rZXhlYwo= From mboxrd@z Thu Jan 1 00:00:00 1970 From: Baoquan He Subject: Re: [PATCH 2/4 V3] Allocate pages for kdump without encryption when SME is enabled Date: Thu, 21 Jun 2018 18:23:21 +0800 Message-ID: <20180621102321.GK29979@MiWiFi-R3L-srv> References: <20180616082714.32035-1-lijiang@redhat.com> <20180616082714.32035-3-lijiang@redhat.com> <20180621015306.GG29979@MiWiFi-R3L-srv> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: lijiang Cc: thomas.lendacky-5C7GfCeVMHo@public.gmane.org, iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, dyoung-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, kexec-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: iommu@lists.linux-foundation.org T24gMDYvMjEvMTggYXQgMDE6MDZwbSwgbGlqaWFuZyB3cm90ZToKPiDlnKggMjAxOOW5tDA25pyI MjHml6UgMDk6NTMsIEJhb3F1YW4gSGUg5YaZ6YGTOgo+ID4gT24gMDYvMTYvMTggYXQgMDQ6Mjdw bSwgTGlhbmJvIEppYW5nIHdyb3RlOgo+ID4+IFdoZW4gU01FIGlzIGVuYWJsZWQgaW4gdGhlIGZp cnN0IGtlcm5lbCwgd2Ugd2lsbCBhbGxvY2F0ZSBwYWdlcwo+ID4+IGZvciBrZHVtcCB3aXRob3V0 IGVuY3J5cHRpb24gaW4gb3JkZXIgdG8gYmUgYWJsZSB0byBib290IHRoZQo+ID4+IHNlY29uZCBr ZXJuZWwgaW4gdGhlIHNhbWUgbWFubmVyIGFzIGtleGVjLCB3aGljaCBoZWxwcyB0byBrZWVwCj4g Pj4gdGhlIHNhbWUgY29kZSBzdHlsZS4KPiA+Pgo+ID4+IFNpZ25lZC1vZmYtYnk6IExpYW5ibyBK aWFuZyA8bGlqaWFuZ0ByZWRoYXQuY29tPgo+ID4+IC0tLQo+ID4+ICBrZXJuZWwva2V4ZWNfY29y ZS5jIHwgMTIgKysrKysrKysrKysrCj4gPj4gIDEgZmlsZSBjaGFuZ2VkLCAxMiBpbnNlcnRpb25z KCspCj4gPj4KPiA+PiBkaWZmIC0tZ2l0IGEva2VybmVsL2tleGVjX2NvcmUuYyBiL2tlcm5lbC9r ZXhlY19jb3JlLmMKPiA+PiBpbmRleCAyMGZlZjFhLi4zYzIyYTliIDEwMDY0NAo+ID4+IC0tLSBh L2tlcm5lbC9rZXhlY19jb3JlLmMKPiA+PiArKysgYi9rZXJuZWwva2V4ZWNfY29yZS5jCj4gPj4g QEAgLTQ3MSw2ICs0NzEsMTYgQEAgc3RhdGljIHN0cnVjdCBwYWdlICpraW1hZ2VfYWxsb2NfY3Jh c2hfY29udHJvbF9wYWdlcyhzdHJ1Y3Qga2ltYWdlICppbWFnZSwKPiA+PiAgCQl9Cj4gPj4gIAl9 Cj4gPj4gIAo+ID4+ICsJaWYgKHBhZ2VzKSB7Cj4gPj4gKwkJdW5zaWduZWQgaW50IGNvdW50LCBp Owo+ID4+ICsKPiA+PiArCQlwYWdlcy0+bWFwcGluZyA9IE5VTEw7Cj4gPj4gKwkJc2V0X3BhZ2Vf cHJpdmF0ZShwYWdlcywgb3JkZXIpOwo+ID4+ICsJCWNvdW50ID0gMSA8PCBvcmRlcjsKPiA+PiAr CQlmb3IgKGkgPSAwOyBpIDwgY291bnQ7IGkrKykKPiA+PiArCQkJU2V0UGFnZVJlc2VydmVkKHBh Z2VzICsgaSk7Cj4gPiAKPiA+IEkgZ3Vlc3MgeW91IG1pZ2h0IGltaXRhdGUgdGhlIGtleGVjIGNh c2UsIGhvd2V2ZXIga2V4ZWMgZ2V0IHBhZ2VzIGZyb20KPiA+IGJ1ZGR5LiBDcmFzaCBwYWdlcyBh cmUgcmVzZXJ2ZWQgaW4gbWVtYmxvY2ssIHRoZXNlIGNvZGVzIG1pZ2h0IG1ha2Ugbm8gc2Vuc2Uu Cj4gPiAKPiBUaGFua3MgZm9yIHlvdXIgY29tbWVudHMuCj4gV2UgaGF2ZSBjaGFuZ2VkIHRoZSBh dHRyaWJ1dGUgb2YgcGFnZXMsIHNvIHRoZSBvcmlnaW5hbCBhdHRyaWJ1dGUgb2YgcGFnZXMgd2ls bCBiZQo+IHJlc3RvcmVkIHdoZW4gdGhleSBmcmVlLgoKSG1tLCB5b3UgY2FuIGNoZWNrIHdoYXQg a2ltYWdlX2ZyZWUoKSBpcyBkb2luZywgYW5kIHdoZXJlCmtpbWFnZS0+Y29udHJvbF9wYWdlcywg ZGVzdF9wYWdlcywgdW51c2FibGVfcGFnZXMgaXMgYXNzaWduZWQuIERvIHlvdQprbm93IHdoZXJl IHRoZXNlIG9yaWdpbmFsIGF0dHJpYnV0ZSBvZiBwYWdlcyBjb21lcyBmcm9tIGFuZCB0aGV5IGFy ZQp1c2VkL25lZWRlZCBpbiBDUkFTSCBjYXNlLCBpZiB5b3UgY2FyZSBhYm91dCB0aGVtPwoKPiAK PiA+PiArCQlhcmNoX2tleGVjX3Bvc3RfYWxsb2NfcGFnZXMocGFnZV9hZGRyZXNzKHBhZ2VzKSwg MSA8PCBvcmRlciwgMCk7Cj4gPj4gKwl9Cj4gPj4gIAlyZXR1cm4gcGFnZXM7Cj4gPj4gIH0KPiA+ PiAgCj4gPj4gQEAgLTg2NSw2ICs4NzUsNyBAQCBzdGF0aWMgaW50IGtpbWFnZV9sb2FkX2NyYXNo X3NlZ21lbnQoc3RydWN0IGtpbWFnZSAqaW1hZ2UsCj4gPj4gIAkJCXJlc3VsdCAgPSAtRU5PTUVN Owo+ID4+ICAJCQlnb3RvIG91dDsKPiA+PiAgCQl9Cj4gPj4gKwkJYXJjaF9rZXhlY19wb3N0X2Fs bG9jX3BhZ2VzKHBhZ2VfYWRkcmVzcyhwYWdlKSwgMSwgMCk7Cj4gPj4gIAkJcHRyID0ga21hcChw YWdlKTsKPiA+PiAgCQlwdHIgKz0gbWFkZHIgJiB+UEFHRV9NQVNLOwo+ID4+ICAJCW1jaHVuayA9 IG1pbl90KHNpemVfdCwgbWJ5dGVzLAo+ID4+IEBAIC04ODIsNiArODkzLDcgQEAgc3RhdGljIGlu dCBraW1hZ2VfbG9hZF9jcmFzaF9zZWdtZW50KHN0cnVjdCBraW1hZ2UgKmltYWdlLAo+ID4+ICAJ CQlyZXN1bHQgPSBjb3B5X2Zyb21fdXNlcihwdHIsIGJ1ZiwgdWNodW5rKTsKPiA+PiAgCQlrZXhl Y19mbHVzaF9pY2FjaGVfcGFnZShwYWdlKTsKPiA+PiAgCQlrdW5tYXAocGFnZSk7Cj4gPj4gKwkJ YXJjaF9rZXhlY19wcmVfZnJlZV9wYWdlcyhwYWdlX2FkZHJlc3MocGFnZSksIDEpOwo+ID4+ICAJ CWlmIChyZXN1bHQpIHsKPiA+PiAgCQkJcmVzdWx0ID0gLUVGQVVMVDsKPiA+PiAgCQkJZ290byBv dXQ7Cj4gPj4gLS0gCj4gPj4gMi45LjUKPiA+Pgo+ID4+Cj4gPj4gX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX18KPiA+PiBrZXhlYyBtYWlsaW5nIGxpc3QKPiA+ PiBrZXhlY0BsaXN0cy5pbmZyYWRlYWQub3JnCj4gPj4gaHR0cDovL2xpc3RzLmluZnJhZGVhZC5v cmcvbWFpbG1hbi9saXN0aW5mby9rZXhlYwpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fXwppb21tdSBtYWlsaW5nIGxpc3QKaW9tbXVAbGlzdHMubGludXgtZm91 bmRhdGlvbi5vcmcKaHR0cHM6Ly9saXN0cy5saW51eGZvdW5kYXRpb24ub3JnL21haWxtYW4vbGlz dGluZm8vaW9tbXU= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EA2D3C43141 for ; Thu, 21 Jun 2018 10:23:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A40C820883 for ; Thu, 21 Jun 2018 10:23:30 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A40C820883 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754236AbeFUKX2 (ORCPT ); Thu, 21 Jun 2018 06:23:28 -0400 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:35778 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752926AbeFUKX1 (ORCPT ); Thu, 21 Jun 2018 06:23:27 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id E19C24021FC9; Thu, 21 Jun 2018 10:23:26 +0000 (UTC) Received: from localhost (ovpn-8-18.pek2.redhat.com [10.72.8.18]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 29E561117637; Thu, 21 Jun 2018 10:23:23 +0000 (UTC) Date: Thu, 21 Jun 2018 18:23:21 +0800 From: Baoquan He To: lijiang Cc: linux-kernel@vger.kernel.org, thomas.lendacky@amd.com, iommu@lists.linux-foundation.org, dyoung@redhat.com, kexec@lists.infradead.org Subject: Re: [PATCH 2/4 V3] Allocate pages for kdump without encryption when SME is enabled Message-ID: <20180621102321.GK29979@MiWiFi-R3L-srv> References: <20180616082714.32035-1-lijiang@redhat.com> <20180616082714.32035-3-lijiang@redhat.com> <20180621015306.GG29979@MiWiFi-R3L-srv> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.9.1 (2017-09-22) X-Scanned-By: MIMEDefang 2.78 on 10.11.54.3 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.7]); Thu, 21 Jun 2018 10:23:26 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.7]); Thu, 21 Jun 2018 10:23:26 +0000 (UTC) for IP:'10.11.54.3' DOMAIN:'int-mx03.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'bhe@redhat.com' RCPT:'' Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/21/18 at 01:06pm, lijiang wrote: > 在 2018年06月21日 09:53, Baoquan He 写道: > > On 06/16/18 at 04:27pm, Lianbo Jiang wrote: > >> When SME is enabled in the first kernel, we will allocate pages > >> for kdump without encryption in order to be able to boot the > >> second kernel in the same manner as kexec, which helps to keep > >> the same code style. > >> > >> Signed-off-by: Lianbo Jiang > >> --- > >> kernel/kexec_core.c | 12 ++++++++++++ > >> 1 file changed, 12 insertions(+) > >> > >> diff --git a/kernel/kexec_core.c b/kernel/kexec_core.c > >> index 20fef1a..3c22a9b 100644 > >> --- a/kernel/kexec_core.c > >> +++ b/kernel/kexec_core.c > >> @@ -471,6 +471,16 @@ static struct page *kimage_alloc_crash_control_pages(struct kimage *image, > >> } > >> } > >> > >> + if (pages) { > >> + unsigned int count, i; > >> + > >> + pages->mapping = NULL; > >> + set_page_private(pages, order); > >> + count = 1 << order; > >> + for (i = 0; i < count; i++) > >> + SetPageReserved(pages + i); > > > > I guess you might imitate the kexec case, however kexec get pages from > > buddy. Crash pages are reserved in memblock, these codes might make no sense. > > > Thanks for your comments. > We have changed the attribute of pages, so the original attribute of pages will be > restored when they free. Hmm, you can check what kimage_free() is doing, and where kimage->control_pages, dest_pages, unusable_pages is assigned. Do you know where these original attribute of pages comes from and they are used/needed in CRASH case, if you care about them? > > >> + arch_kexec_post_alloc_pages(page_address(pages), 1 << order, 0); > >> + } > >> return pages; > >> } > >> > >> @@ -865,6 +875,7 @@ static int kimage_load_crash_segment(struct kimage *image, > >> result = -ENOMEM; > >> goto out; > >> } > >> + arch_kexec_post_alloc_pages(page_address(page), 1, 0); > >> ptr = kmap(page); > >> ptr += maddr & ~PAGE_MASK; > >> mchunk = min_t(size_t, mbytes, > >> @@ -882,6 +893,7 @@ static int kimage_load_crash_segment(struct kimage *image, > >> result = copy_from_user(ptr, buf, uchunk); > >> kexec_flush_icache_page(page); > >> kunmap(page); > >> + arch_kexec_pre_free_pages(page_address(page), 1); > >> if (result) { > >> result = -EFAULT; > >> goto out; > >> -- > >> 2.9.5 > >> > >> > >> _______________________________________________ > >> kexec mailing list > >> kexec@lists.infradead.org > >> http://lists.infradead.org/mailman/listinfo/kexec