From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.linutronix.de (146.0.238.70:993) by crypto-ml.lab.linutronix.de with IMAP4-SSL for ; 21 Jun 2018 13:56:54 -0000 Received: from userp2130.oracle.com ([156.151.31.86]) by Galois.linutronix.de with esmtps (TLS1.2:RSA_AES_256_CBC_SHA256:256) (Exim 4.80) (envelope-from ) id 1fW04y-0008KA-Cb for speck@linutronix.de; Thu, 21 Jun 2018 15:56:53 +0200 Received: from pps.filterd (userp2130.oracle.com [127.0.0.1]) by userp2130.oracle.com (8.16.0.22/8.16.0.22) with SMTP id w5LDsfEh048084 for ; Thu, 21 Jun 2018 13:56:45 GMT Received: from aserv0022.oracle.com (aserv0022.oracle.com [141.146.126.234]) by userp2130.oracle.com with ESMTP id 2jmt01rwsy-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Thu, 21 Jun 2018 13:56:45 +0000 Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72]) by aserv0022.oracle.com (8.14.4/8.14.4) with ESMTP id w5LDui9r015932 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Thu, 21 Jun 2018 13:56:44 GMT Received: from abhmp0006.oracle.com (abhmp0006.oracle.com [141.146.116.12]) by userv0121.oracle.com (8.14.4/8.13.8) with ESMTP id w5LDui8P019395 for ; Thu, 21 Jun 2018 13:56:44 GMT Date: Thu, 21 Jun 2018 09:56:43 -0400 From: Konrad Rzeszutek Wilk Subject: [MODERATED] Re: [PATCH v2.1 4/6] [PATCH v2.1 4/6] Patch #4 Message-ID: <20180621135643.GD28543@char.US.ORACLE.com> References: <20180620204351.997227234@localhost.localdomain> <20180621084310.GS2494@hirez.programming.kicks-ass.net> MIME-Version: 1.0 In-Reply-To: <20180621084310.GS2494@hirez.programming.kicks-ass.net> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit To: speck@linutronix.de List-ID: On Thu, Jun 21, 2018 at 10:43:10AM +0200, speck for Peter Zijlstra wrote: > On Wed, Jun 20, 2018 at 04:43:00PM -0400, speck for konrad.wilk_at_oracle.com wrote: > > x86/KVM: Warn user if KVM is loaded SMT and L1TF CPU bug being present. > > > > If the L1TF CPU bug is present we allow the KVM module to be loaded > > as the major of users that use Linux and KVM have trusted guests > > and do not want a broken setup. > > Why on module load? Doesn't the module get loaded unconditionally? My > desktop seems to have it loaded and I'm pretty sure i've never used KVM > on it. > > Would it not make more sense to do this in kvm_create_vm() ? Then only > people actually using KVM get to deal with it. Excellent suggestion. Let me see about that. Did the text sound scary enough or should I notch it up with more scary warnings?