From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH 2/2] drm/i915/cnl: Don't get separate AUX power domain ref for DP PSR Date: Thu, 21 Jun 2018 19:13:51 +0300 Message-ID: <20180621161351.GR20518@intel.com> References: <20180621155830.11311-1-imre.deak@intel.com> <20180621155830.11311-2-imre.deak@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTPS id 8F0BF898F5 for ; Thu, 21 Jun 2018 16:13:54 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20180621155830.11311-2-imre.deak@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Imre Deak Cc: intel-gfx@lists.freedesktop.org, Dhinakaran Pandiyan , Paulo Zanoni List-Id: intel-gfx@lists.freedesktop.org T24gVGh1LCBKdW4gMjEsIDIwMTggYXQgMDY6NTg6MzBQTSArMDMwMCwgSW1yZSBEZWFrIHdyb3Rl Ogo+IEFmdGVyIHRoZSBwcmV2aW91cyBwYXRjaCB3ZSBkb24ndCBuZWVkIHRvIGdldCBhbiBleHBs aWNpdCBBVVggcG93ZXIKPiByZWZlcmVuY2UgZm9yIFBTUiBmdW5jdGlvbmFsaXR5LCBzaW5jZSB3 ZSBob2xkIG5vdyBhbiBBVVggcmVmZXJlbmNlCj4gd2hlbmV2ZXIgdGhlIG1haW4gbGluayBpcyBh Y3RpdmUgb24gYW55IERQIHBvcnRzLgo+IAo+IENjOiBWaWxsZSBTeXJqw6Rsw6QgPHZpbGxlLnN5 cmphbGFAbGludXguaW50ZWwuY29tPgo+IENjOiBEaGluYWthcmFuIFBhbmRpeWFuIDxkaGluYWth cmFuLnBhbmRpeWFuQGludGVsLmNvbT4KPiBDYzogUGF1bG8gWmFub25pIDxwYXVsby5yLnphbm9u aUBpbnRlbC5jb20+Cj4gU2lnbmVkLW9mZi1ieTogSW1yZSBEZWFrIDxpbXJlLmRlYWtAaW50ZWwu Y29tPgo+IC0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmggICAgfCAg MSAtCj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3Bzci5jICAgICAgICB8IDQxIC0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRl bF9ydW50aW1lX3BtLmMgfCAgMyAtLS0KPiAgMyBmaWxlcyBjaGFuZ2VkLCA0NSBkZWxldGlvbnMo LSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5o IGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5oCj4gaW5kZXggZGZiMDJkYTcz YWM4Li4yOTUwMWJmMzY4YjIgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50 ZWxfZGlzcGxheS5oCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5o Cj4gQEAgLTE5OCw3ICsxOTgsNiBAQCBlbnVtIGludGVsX2Rpc3BsYXlfcG93ZXJfZG9tYWluIHsK PiAgCVBPV0VSX0RPTUFJTl9BVVhfRCwKPiAgCVBPV0VSX0RPTUFJTl9BVVhfRSwKPiAgCVBPV0VS X0RPTUFJTl9BVVhfRiwKPiAtCVBPV0VSX0RPTUFJTl9BVVhfSU9fQSwKPiAgCVBPV0VSX0RPTUFJ Tl9HTUJVUywKPiAgCVBPV0VSX0RPTUFJTl9NT0RFU0VULAo+ICAJUE9XRVJfRE9NQUlOX0dUX0lS USwKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcHNyLmMgYi9kcml2 ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9wc3IuYwo+IGluZGV4IGQ0Y2QxOWZlYTE0OC4uZWVjZGQ4 YjViNWUwIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3Bzci5jCj4g KysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcHNyLmMKPiBAQCAtNTYsNDMgKzU2LDYg QEAKPiAgI2luY2x1ZGUgImludGVsX2Rydi5oIgo+ICAjaW5jbHVkZSAiaTkxNV9kcnYuaCIKPiAg Cj4gLXN0YXRpYyBpbmxpbmUgZW51bSBpbnRlbF9kaXNwbGF5X3Bvd2VyX2RvbWFpbgo+IC1wc3Jf YXV4X2RvbWFpbihzdHJ1Y3QgaW50ZWxfZHAgKmludGVsX2RwKQo+IC17Cj4gLQkvKiBDTkwgSFcg cmVxdWlyZXMgY29ycmVzcG9uZGluZyBBVVggSU9zIHRvIGJlIHBvd2VyZWQgdXAgZm9yIFBTUi4K PiAtCSAqIEhvd2V2ZXIsIGZvciBub24tQSBBVVggcG9ydHMgdGhlIGNvcnJlc3BvbmRpbmcgbm9u LUVEUCB0cmFuc2NvZGVycwo+IC0JICogd291bGQgaGF2ZSBhbHJlYWR5IGVuYWJsZWQgcG93ZXIg d2VsbCAyIGFuZCBEQ19PRkYuIFRoaXMgbWVhbnMgd2UgY2FuCj4gLQkgKiBhY3F1aXJlIGEgd2lk ZXIgUE9XRVJfRE9NQUlOX0FVWF97QixDLEQsRn0gcmVmZXJlbmNlIGluc3RlYWQgb2YgYQo+IC0J ICogc3BlY2lmaWMgQVVYX0lPIHJlZmVyZW5jZSB3aXRob3V0IHBvd2VyaW5nIHVwIGFueSBleHRy YSB3ZWxscy4KPiAtCSAqIE5vdGUgdGhhdCBQU1IgaXMgZW5hYmxlZCBvbmx5IG9uIFBvcnQgQSBl dmVuIHRob3VnaCB0aGlzIGZ1bmN0aW9uCj4gLQkgKiByZXR1cm5zIHRoZSBjb3JyZWN0IGRvbWFp biBmb3Igb3RoZXIgcG9ydHMgdG9vLgo+IC0JICovCj4gLQlyZXR1cm4gaW50ZWxfZHAtPmF1eF9j aCA9PSBBVVhfQ0hfQSA/IFBPV0VSX0RPTUFJTl9BVVhfSU9fQSA6Cj4gLQkJCQkJICAgICAgaW50 ZWxfZHAtPmF1eF9wb3dlcl9kb21haW47CgpIbW0uIElzbid0IHRoaXMgZ29pbmcgdG8gcHJldmVu dCBEQzUgZHVyaW5nIFBTUj8KCj4gLX0KPiAtCj4gLXN0YXRpYyB2b2lkIHBzcl9hdXhfaW9fcG93 ZXJfZ2V0KHN0cnVjdCBpbnRlbF9kcCAqaW50ZWxfZHApCj4gLXsKPiAtCXN0cnVjdCBpbnRlbF9k aWdpdGFsX3BvcnQgKmludGVsX2RpZ19wb3J0ID0gZHBfdG9fZGlnX3BvcnQoaW50ZWxfZHApOwo+ IC0Jc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2ID0gdG9faTkxNShpbnRlbF9kaWdf cG9ydC0+YmFzZS5iYXNlLmRldik7Cj4gLQo+IC0JaWYgKElOVEVMX0dFTihkZXZfcHJpdikgPCAx MCkKPiAtCQlyZXR1cm47Cj4gLQo+IC0JaW50ZWxfZGlzcGxheV9wb3dlcl9nZXQoZGV2X3ByaXYs IHBzcl9hdXhfZG9tYWluKGludGVsX2RwKSk7Cj4gLX0KPiAtCj4gLXN0YXRpYyB2b2lkIHBzcl9h dXhfaW9fcG93ZXJfcHV0KHN0cnVjdCBpbnRlbF9kcCAqaW50ZWxfZHApCj4gLXsKPiAtCXN0cnVj dCBpbnRlbF9kaWdpdGFsX3BvcnQgKmludGVsX2RpZ19wb3J0ID0gZHBfdG9fZGlnX3BvcnQoaW50 ZWxfZHApOwo+IC0Jc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2ID0gdG9faTkxNShp bnRlbF9kaWdfcG9ydC0+YmFzZS5iYXNlLmRldik7Cj4gLQo+IC0JaWYgKElOVEVMX0dFTihkZXZf cHJpdikgPCAxMCkKPiAtCQlyZXR1cm47Cj4gLQo+IC0JaW50ZWxfZGlzcGxheV9wb3dlcl9wdXQo ZGV2X3ByaXYsIHBzcl9hdXhfZG9tYWluKGludGVsX2RwKSk7Cj4gLX0KPiAtCj4gIHZvaWQgaW50 ZWxfcHNyX2lycV9jb250cm9sKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiwgYm9v bCBkZWJ1ZykKPiAgewo+ICAJdTMyIGRlYnVnX21hc2ssIG1hc2s7Cj4gQEAgLTU5NSw4ICs1NTgs NiBAQCBzdGF0aWMgdm9pZCBoc3dfcHNyX2VuYWJsZV9zb3VyY2Uoc3RydWN0IGludGVsX2RwICpp bnRlbF9kcCwKPiAgCXN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiA9IHRvX2k5MTUo ZGV2KTsKPiAgCWVudW0gdHJhbnNjb2RlciBjcHVfdHJhbnNjb2RlciA9IGNydGNfc3RhdGUtPmNw dV90cmFuc2NvZGVyOwo+ICAKPiAtCXBzcl9hdXhfaW9fcG93ZXJfZ2V0KGludGVsX2RwKTsKPiAt Cj4gIAkvKiBPbmx5IEhTVyBhbmQgQkRXIGhhdmUgUFNSIEFVWCByZWdpc3RlcnMgdGhhdCBuZWVk IHRvIGJlIHNldHVwLiBTS0wrCj4gIAkgKiB1c2UgaGFyZGNvZGVkIHZhbHVlcyBQU1IgQVVYIHRy YW5zYWN0aW9ucwo+ICAJICovCj4gQEAgLTcxNyw4ICs2NzgsNiBAQCBzdGF0aWMgdm9pZCBoc3df cHNyX2Rpc2FibGUoc3RydWN0IGludGVsX2RwICppbnRlbF9kcCwKPiAgCQllbHNlCj4gIAkJCVdB Uk5fT04oSTkxNV9SRUFEKEVEUF9QU1JfQ1RMKSAmIEVEUF9QU1JfRU5BQkxFKTsKPiAgCX0KPiAt Cj4gLQlwc3JfYXV4X2lvX3Bvd2VyX3B1dChpbnRlbF9kcCk7Cj4gIH0KPiAgCj4gIC8qKgo+IGRp ZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9ydW50aW1lX3BtLmMgYi9kcml2 ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9ydW50aW1lX3BtLmMKPiBpbmRleCBkZTNhODEwMzRmNzcu LjU4YThmMDdlYWZhNCAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9y dW50aW1lX3BtLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9ydW50aW1lX3Bt LmMKPiBAQCAtMTMyLDggKzEzMiw2IEBAIGludGVsX2Rpc3BsYXlfcG93ZXJfZG9tYWluX3N0cihl bnVtIGludGVsX2Rpc3BsYXlfcG93ZXJfZG9tYWluIGRvbWFpbikKPiAgCQlyZXR1cm4gIkFVWF9F IjsKPiAgCWNhc2UgUE9XRVJfRE9NQUlOX0FVWF9GOgo+ICAJCXJldHVybiAiQVVYX0YiOwo+IC0J Y2FzZSBQT1dFUl9ET01BSU5fQVVYX0lPX0E6Cj4gLQkJcmV0dXJuICJBVVhfSU9fQSI7Cj4gIAlj YXNlIFBPV0VSX0RPTUFJTl9HTUJVUzoKPiAgCQlyZXR1cm4gIkdNQlVTIjsKPiAgCWNhc2UgUE9X RVJfRE9NQUlOX0lOSVQ6Cj4gQEAgLTE4NzIsNyArMTg3MCw2IEBAIHZvaWQgaW50ZWxfZGlzcGxh eV9wb3dlcl9wdXQoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2LAo+ICAJQklUX1VM TChQT1dFUl9ET01BSU5fSU5JVCkpCj4gICNkZWZpbmUgQ05MX0RJU1BMQVlfQVVYX0FfUE9XRVJf RE9NQUlOUyAoCQlcCj4gIAlCSVRfVUxMKFBPV0VSX0RPTUFJTl9BVVhfQSkgfAkJCVwKPiAtCUJJ VF9VTEwoUE9XRVJfRE9NQUlOX0FVWF9JT19BKSB8CQlcCj4gIAlCSVRfVUxMKFBPV0VSX0RPTUFJ Tl9JTklUKSkKPiAgI2RlZmluZSBDTkxfRElTUExBWV9BVVhfQl9QT1dFUl9ET01BSU5TICgJCVwK PiAgCUJJVF9VTEwoUE9XRVJfRE9NQUlOX0FVWF9CKSB8CQkJXAo+IC0tIAo+IDIuMTMuMgoKLS0g ClZpbGxlIFN5cmrDpGzDpApJbnRlbApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVl ZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5m by9pbnRlbC1nZngK