From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH 1/2] drm/i915/ddi: Get AUX power domain for DP main link too Date: Thu, 21 Jun 2018 20:37:15 +0300 Message-ID: <20180621173715.GS20518@intel.com> References: <20180621155830.11311-1-imre.deak@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4AC076E921 for ; Thu, 21 Jun 2018 17:37:19 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20180621155830.11311-1-imre.deak@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Imre Deak Cc: intel-gfx@lists.freedesktop.org, Dhinakaran Pandiyan , Paulo Zanoni List-Id: intel-gfx@lists.freedesktop.org T24gVGh1LCBKdW4gMjEsIDIwMTggYXQgMDY6NTg6MjlQTSArMDMwMCwgSW1yZSBEZWFrIHdyb3Rl Ogo+IFNvIGZhciB3ZSBnb3QgYW4gQVVYIHBvd2VyIGRvbWFpbiByZWZlcmVuY2Ugb25seSBmb3Ig dGhlIGR1cmF0aW9uIG9mIERQCj4gQVVYIHRyYW5zZmVycy4gSG93ZXZlciwgdGhlIGZvbGxvd2lu Z3Mgc3VnZ2VzdCB0aGF0IHdlIGFsc28gbmVlZCB0aGVzZQo+IGZvciBtYWluIGxpbmsgZnVuY3Rp b25hbGl0eToKPiAtIFRoZSBzcGVjaWZpY2F0aW9uIGRvZXNuJ3Qgc3RhdGUgd2hldGhlciBpdCdz IG5lZWRlZCBvciBub3QgZm9yIG1haW4KPiAgIGxpbmsgZnVuY3Rpb25hbGl0eSwgYnV0IHN1Z2dl c3RzIHRoYXQgdGhlc2UgcG93ZXIgd2VsbHMgbmVlZCB0byBiZQo+ICAgZW5hYmxlZCBhbHJlYWR5 IGR1cmluZyBkaXNwbGF5IGNvcmUgaW5pdGlhbGl6YXRpb24gKFNlcXVlbmNlcyB0bwo+ICAgSW5p dGlhbGl6ZSBEaXNwbGF5KS4KPiAtIEZvciBQU1Igd2UgbmVlZCB0byBrZWVwIHRoZSBBVVggcG93 ZXIgd2VsbCBlbmFibGVkLgo+IC0gT24gSUNMIGNvbWJvIFBIWSBwb3J0cyAobm9uLVRDKSB0aGUg QVVYIHBvd2VyIHdlbGwgaXMgbmVlZGVkIGZvcgo+ICAgbGluayB0cmFpbmluZyB0b286IHdoaWxl IHRoZSBwb3J0IGlzIGVuYWJsZWQgd2l0aCBhIERQIGxpbmsgdHJhaW5pbmcKPiAgIHRlc3QgcGF0 dGVybiB0cnlpbmcgdG8gdG9nZ2xlIHRoZSBBVVggcG93ZXIgd2VsbCB3aWxsIHRpbWUgb3V0Lgo+ IC0gT24gSUNMIE1HIFBIWSBwb3J0cyAoVEMpIHRoZSBBVVggcG93ZXIgd2VsbCBpcyBuZWVkZWQg YWxzbyBmb3IgbWFpbgo+ICAgbGluayBmdW5jdGlvbmFsaXR5IChib3RoIGluIERQIGFuZCBIRE1J IG1vZGVzKS4KPiAtIFdpbmRvd3MgZW5hYmxlcyB0aGVzZSBwb3dlciB3ZWxscyBib3RoIGZvciBt YWluIGFuZCBBVVggbGFuZQo+ICAgZnVuY3Rpb25hbGl0eS4KPiAKPiBCYXNlZCBvbiB0aGUgYWJv dmUgdGFrZSBhbiBBVVggcG93ZXIgcmVmZXJlbmNlIGZvciBtYWluIGxpbmsKPiBmdW5jdGlvbmFs aXR5IHRvby4gVGhpcyBtYWtlcyBhIGRpZmZlcmVuY2Ugb25seSBvbiBHRU4xMCsgKEdMSyspCj4g cGxhdGZvcm1zLCB3aGVyZSB3ZSBoYXZlIHNlcGFyYXRlIHBvcnQgc3BlY2lmaWMgQVVYIHBvd2Vy IHdlbGxzLgo+IAo+IENjOiBWaWxsZSBTeXJqw6Rsw6QgPHZpbGxlLnN5cmphbGFAbGludXguaW50 ZWwuY29tPgo+IENjOiBEaGluYWthcmFuIFBhbmRpeWFuIDxkaGluYWthcmFuLnBhbmRpeWFuQGlu dGVsLmNvbT4KPiBDYzogUGF1bG8gWmFub25pIDxwYXVsby5yLnphbm9uaUBpbnRlbC5jb20+Cj4g U2lnbmVkLW9mZi1ieTogSW1yZSBEZWFrIDxpbXJlLmRlYWtAaW50ZWwuY29tPgo+IC0tLQo+ICBk cml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kZGkuYyAgICAgfCAzMyArKysrKysrKysrKysrKysr KysrKysrKysrKysrKy0tLS0KPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5j IHwgMTIgKysrKysrKysrKystCj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rydi5oICAg ICB8ICAzICsrLQo+ICAzIGZpbGVzIGNoYW5nZWQsIDQyIGluc2VydGlvbnMoKyksIDYgZGVsZXRp b25zKC0pCj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RkaS5j IGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGRpLmMKPiBpbmRleCAwNDRmZTFmYjk4NzIu LmIwOWNiNjk2OWJiYiAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9k ZGkuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RkaS5jCj4gQEAgLTE5ODMs MTUgKzE5ODMsMzYgQEAgYm9vbCBpbnRlbF9kZGlfZ2V0X2h3X3N0YXRlKHN0cnVjdCBpbnRlbF9l bmNvZGVyICplbmNvZGVyLAo+ICAJcmV0dXJuIHJldDsKPiAgfQo+ICAKPiAtc3RhdGljIHU2NCBp bnRlbF9kZGlfZ2V0X3Bvd2VyX2RvbWFpbnMoc3RydWN0IGludGVsX2VuY29kZXIgKmVuY29kZXIp Cj4gK3N0YXRpYyB1NjQgaW50ZWxfZGRpX2dldF9wb3dlcl9kb21haW5zKHN0cnVjdCBpbnRlbF9l bmNvZGVyICplbmNvZGVyLAo+ICsJCQkJICAgICAgIHN0cnVjdCBpbnRlbF9jcnRjX3N0YXRlICpj cnRjX3N0YXRlKQo+ICB7Cj4gIAlzdHJ1Y3QgaW50ZWxfZGlnaXRhbF9wb3J0ICpkaWdfcG9ydCA9 IGVuY190b19kaWdfcG9ydCgmZW5jb2Rlci0+YmFzZSk7Cj4gIAllbnVtIHBpcGUgcGlwZTsKPiAr CXU2NCBkb21haW5zOwo+ICAKPiAtCWlmIChpbnRlbF9kZGlfZ2V0X2h3X3N0YXRlKGVuY29kZXIs ICZwaXBlKSkKPiAtCQlyZXR1cm4gQklUX1VMTChkaWdfcG9ydC0+ZGRpX2lvX3Bvd2VyX2RvbWFp bik7Cj4gKwlpZiAoIWludGVsX2RkaV9nZXRfaHdfc3RhdGUoZW5jb2RlciwgJnBpcGUpKQo+ICsJ CXJldHVybiAwOwo+ICAKPiAtCXJldHVybiAwOwo+ICsJZG9tYWlucyA9IEJJVF9VTEwoZGlnX3Bv cnQtPmRkaV9pb19wb3dlcl9kb21haW4pOwo+ICsJaWYgKCFjcnRjX3N0YXRlKQo+ICsJCXJldHVy biBkb21haW5zOwo+ICsKPiArCS8qCj4gKwkgKiBUT0RPOiBBZGQgc3VwcG9ydCBmb3IgTVNUIGVu Y29kZXJzLiBBdG0sIHRoZSBmb2xsb3dpbmcgc2hvdWxkIG5ldmVyCj4gKwkgKiBoYXBwZW4gc2lu Y2UgdGhpcyBmdW5jdGlvbiB3aWxsIGJlIGNhbGxlZCBvbmx5IGZvciB0aGUgcHJpbWFyeQo+ICsJ ICogZW5jb2RlciB3aGljaCBkb2Vzbid0IGhhdmUgaXRzIG93biBwaXBlL2NydGNfc3RhdGUuCj4g KwkgKi8KPiArCWlmIChXQVJOX09OKGludGVsX2NydGNfaGFzX3R5cGUoY3J0Y19zdGF0ZSwgSU5U RUxfT1VUUFVUX0RQX01TVCkpKQo+ICsJCXJldHVybiBkb21haW5zOwo+ICsKPiArCS8qIEFVWCBw b3dlciBpcyBvbmx5IG5lZWRlZCBmb3IgKGUpRFAgbW9kZSwgbm90IGZvciBIRE1JLiAqLwo+ICsJ aWYgKCFpbnRlbF9jcnRjX2hhc190eXBlKGNydGNfc3RhdGUsIElOVEVMX09VVFBVVF9IRE1JKSkg ewo+ICsJCXN0cnVjdCBpbnRlbF9kcCAqaW50ZWxfZHAgPSAmZGlnX3BvcnQtPmRwOwo+ICsKPiAr CQlkb21haW5zIHw9IEJJVF9VTEwoaW50ZWxfZHAtPmF1eF9wb3dlcl9kb21haW4pOwo+ICsJfQo+ ICsKPiArCXJldHVybiBkb21haW5zOwo+ICB9Cj4gIAo+ICB2b2lkIGludGVsX2RkaV9lbmFibGVf cGlwZV9jbG9jayhjb25zdCBzdHJ1Y3QgaW50ZWxfY3J0Y19zdGF0ZSAqY3J0Y19zdGF0ZSkKPiBA QCAtMjYzMSw2ICsyNjUyLDggQEAgc3RhdGljIHZvaWQgaW50ZWxfZGRpX3ByZV9lbmFibGVfZHAo c3RydWN0IGludGVsX2VuY29kZXIgKmVuY29kZXIsCj4gIAo+ICAJV0FSTl9PTihpc19tc3QgJiYg KHBvcnQgPT0gUE9SVF9BIHx8IHBvcnQgPT0gUE9SVF9FKSk7Cj4gIAo+ICsJaW50ZWxfZGlzcGxh eV9wb3dlcl9nZXQoZGV2X3ByaXYsIGludGVsX2RwLT5hdXhfcG93ZXJfZG9tYWluKTsKPiArCj4g IAlpbnRlbF9kcF9zZXRfbGlua19wYXJhbXMoaW50ZWxfZHAsIGNydGNfc3RhdGUtPnBvcnRfY2xv Y2ssCj4gIAkJCQkgY3J0Y19zdGF0ZS0+bGFuZV9jb3VudCwgaXNfbXN0KTsKPiAgCj4gQEAgLTI3 NzUsNiArMjc5OCw4IEBAIHN0YXRpYyB2b2lkIGludGVsX2RkaV9wb3N0X2Rpc2FibGVfZHAoc3Ry dWN0IGludGVsX2VuY29kZXIgKmVuY29kZXIsCj4gIAlpbnRlbF9kaXNwbGF5X3Bvd2VyX3B1dChk ZXZfcHJpdiwgZGlnX3BvcnQtPmRkaV9pb19wb3dlcl9kb21haW4pOwo+ICAKPiAgCWludGVsX2Rk aV9jbGtfZGlzYWJsZShlbmNvZGVyKTsKPiArCj4gKwlpbnRlbF9kaXNwbGF5X3Bvd2VyX3B1dChk ZXZfcHJpdiwgaW50ZWxfZHAtPmF1eF9wb3dlcl9kb21haW4pOwo+ICB9Cj4gIAo+ICBzdGF0aWMg dm9pZCBpbnRlbF9kZGlfcG9zdF9kaXNhYmxlX2hkbWkoc3RydWN0IGludGVsX2VuY29kZXIgKmVu Y29kZXIsCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXku YyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYwo+IGluZGV4IDJjOGZlZjNl ZGU1NC4uZDlmZWZjZWM0YjFhIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2lu dGVsX2Rpc3BsYXkuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXku Ywo+IEBAIC0xNTY3NiwxMSArMTU2NzYsMjEgQEAgZ2V0X2VuY29kZXJfcG93ZXJfZG9tYWlucyhz dHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYpCj4gIAlmb3JfZWFjaF9pbnRlbF9lbmNv ZGVyKCZkZXZfcHJpdi0+ZHJtLCBlbmNvZGVyKSB7Cj4gIAkJdTY0IGdldF9kb21haW5zOwo+ICAJ CWVudW0gaW50ZWxfZGlzcGxheV9wb3dlcl9kb21haW4gZG9tYWluOwo+ICsJCXN0cnVjdCBpbnRl bF9jcnRjX3N0YXRlICpjcnRjX3N0YXRlOwo+ICAKPiAgCQlpZiAoIWVuY29kZXItPmdldF9wb3dl cl9kb21haW5zKQo+ICAJCQljb250aW51ZTsKPiAgCj4gLQkJZ2V0X2RvbWFpbnMgPSBlbmNvZGVy LT5nZXRfcG93ZXJfZG9tYWlucyhlbmNvZGVyKTsKPiArCQkvKgo+ICsJCSAqIEluIGNhc2Ugb2Yg YSBkYW5nbGluZyBlbmNvZGVyIHdpdGhvdXQgYSBjcnRjIHdlIHN0aWxsIG5lZWQKPiArCQkgKiB0 byBnZXQgcG93ZXIgZG9tYWluIHJlZnMuIFN1Y2ggZW5jb2RlcnMgd2lsbCBiZSBkaXNhYmxlZAo+ ICsJCSAqIGRyb3BwaW5nIHRoZXNlIHJlZmVyZW5jZXMuCj4gKwkJICovCj4gKwkJY3J0Y19zdGF0 ZSA9IGVuY29kZXItPmJhc2UuY3J0YyA/Cj4gKwkJCSAgICAgdG9faW50ZWxfY3J0Y19zdGF0ZShl bmNvZGVyLT5iYXNlLmNydGMtPnN0YXRlKSA6Cj4gKwkJCSAgICAgTlVMTDsKCkFjdHVhbGx5IEkg dGhpbmsgd2UgY2FuIGp1c3QgZHJvcCB0aGlzIE5VTEwgY3J0YyBzdGF0ZSBjYXNlLiBJZiB0aGUK ZW5jb2RlciBpcyBhY3RpdmUgaXQgd2lsbCBoYXZlIGEgY3J0YyBhc3NpZ25lZCwgYW5kIG9ubHkg dGhlbiBkbyB3ZQphY3R1YWxseSBzaHV0IGl0IGRvd24gaWYgdGhlIGNvbm5lY3Rvci9jcnRjIGlz IG5vdCBhY3RpdmUuIFNvIGlmIHdlIHdlCmV2ZXIgZGlkIGdldCBpbnRvIGEgc2l0dWF0aW9uIHdo ZXJlIHdlIGRpZG4ndCBoYXZlIHRoZSBjcnRjIHdlJ2QKbGVhayB0aGUgcG93ZXIgcmVmZXJlbmNl cy4gQWxzbyB3ZSBuZWVkIHRoZSBjcnRjIHN0YXRlIHRvIHNodXQgZG93bgp0aGUgZW5jb2Rlci4K ClRoZSBlbnRpcmUgc2FuaXRpemVfZW5jb2RlcigpIHRoaW5nIGlzIGEgYml0IHdvbmt5LiBJbiBj YXNlIHdlIGhhdmUgYW4KYWN0aXZlIGVuY29kZXIgd2l0aG91dCBhIGNvbm5lY3RvciBpdCB3b24n dCBhY3R1YWxseSBkbyBhbnl0aGluZy4gSQpzdXBwb3NlIHRoYXQgY291bGQgYXQgbGVhc3QgaGFw cGVuIHdpdGggc2R2by4gV2l0aCBkZGkgaXQgd291bGQgcmVxdWlyZWQKdGhlIHBvcnQgdG8gYmUg ZW5hYmxlZCB3aXRoIHRoZSB3cm9uZyBtb2RlIHdoaWNoIEkgc3VwcG9zZSBpcyBhCnNsaWdodGx5 IGxlc3MgcmVhbGlzdGljIG9wdGlvbi4KCkFub3RoZXIgY2FzZSB3aGVuIHdlIHdvdWxkbid0IGRv IGFueXRoaW5nIGlzIGlmIHRoZSBwb3J0IGlzIGVuYWJsZWQKd2l0aG91dCBhbnkgdHJhbnNjb2Rl ciBoYXZpbmcgc2VsZWN0ZWQgaXQuIFRoYXQgY291bGQgaGFwcGVuIHdpdGgKQ1BUL1BQVCBEUCBv ciBEREkuIE90aGVyIHBvcnQgdHlwZXMgaGF2ZSB0aGUgcGlwZSBzZWxlY3QgYml0cyBvbiB0aGUK cG9ydCBzbyBpdCdzIG5vdCBwb3NzaWJsZSB0byBnZXQgaW50byB0aGF0IHNpdHVhdGlvbi4KClNp bmNlIHdlIGRvbid0IHNlZW0gdG8gaGF2ZSBhbnkgbXlzdGVyaW91cyBidWcgcmVwb3J0cyBhYm91 dCBwb3J0cyBiZWluZwp3b25reSBtYXliZSB0aGVzZSB0aGluZ3MganVzdCBkb24ndCBoYXBwZW4g aW4gcHJhY3RpY2UuIE9yIGV2ZXJ5dGhpbmcKanVzdCBoYXBwZW5zIHRvIHdvcmsgb3V0IGJ5IGFj Y2llbnQgZXZlbiBpZiBkb24ndCBzaHV0IHRoaW5ncyBkb3duCmNsZWFubHkuCgo+ICsKPiArCQln ZXRfZG9tYWlucyA9IGVuY29kZXItPmdldF9wb3dlcl9kb21haW5zKGVuY29kZXIsIGNydGNfc3Rh dGUpOwo+ICAJCWZvcl9lYWNoX3Bvd2VyX2RvbWFpbihkb21haW4sIGdldF9kb21haW5zKQo+ICAJ CQlpbnRlbF9kaXNwbGF5X3Bvd2VyX2dldChkZXZfcHJpdiwgZG9tYWluKTsKPiAgCX0KPiBkaWZm IC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHJ2LmggYi9kcml2ZXJzL2dwdS9k cm0vaTkxNS9pbnRlbF9kcnYuaAo+IGluZGV4IDBjM2FjMGVhZmRlMC4uNzE3NDQyOWQ5MzBhIDEw MDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rydi5oCj4gKysrIGIvZHJp dmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHJ2LmgKPiBAQCAtMjU0LDcgKzI1NCw4IEBAIHN0cnVj dCBpbnRlbF9lbmNvZGVyIHsKPiAgCQkJICAgc3RydWN0IGludGVsX2NydGNfc3RhdGUgKnBpcGVf Y29uZmlnKTsKPiAgCS8qIFJldHVybnMgYSBtYXNrIG9mIHBvd2VyIGRvbWFpbnMgdGhhdCBuZWVk IHRvIGJlIHJlZmVyZW5jZWQgYXMgcGFydAo+ICAJICogb2YgdGhlIGhhcmR3YXJlIHN0YXRlIHJl YWRvdXQgY29kZS4gKi8KPiAtCXU2NCAoKmdldF9wb3dlcl9kb21haW5zKShzdHJ1Y3QgaW50ZWxf ZW5jb2RlciAqZW5jb2Rlcik7Cj4gKwl1NjQgKCpnZXRfcG93ZXJfZG9tYWlucykoc3RydWN0IGlu dGVsX2VuY29kZXIgKmVuY29kZXIsCj4gKwkJCQkgc3RydWN0IGludGVsX2NydGNfc3RhdGUgKmNy dGNfc3RhdGUpOwo+ICAJLyoKPiAgCSAqIENhbGxlZCBkdXJpbmcgc3lzdGVtIHN1c3BlbmQgYWZ0 ZXIgYWxsIHBlbmRpbmcgcmVxdWVzdHMgZm9yIHRoZQo+ICAJICogZW5jb2RlciBhcmUgZmx1c2hl ZCAoZm9yIGV4YW1wbGUgZm9yIERQIEFVWCB0cmFuc2FjdGlvbnMpIGFuZAo+IC0tIAo+IDIuMTMu MgoKLS0gClZpbGxlIFN5cmrDpGzDpApJbnRlbApfX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0 cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9s aXN0aW5mby9pbnRlbC1nZngK