From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf0-f194.google.com ([209.85.192.194]:33053 "EHLO mail-pf0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933129AbeFVC2o (ORCPT ); Thu, 21 Jun 2018 22:28:44 -0400 Date: Fri, 22 Jun 2018 10:28:38 +0800 From: Eryu Guan Subject: Re: [fstests PATCH 1/2] src/: fix up mmap() error checking Message-ID: <20180622022838.GM2780@desktop> References: <20180620225147.12151-1-ross.zwisler@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180620225147.12151-1-ross.zwisler@linux.intel.com> Sender: fstests-owner@vger.kernel.org To: Ross Zwisler Cc: fstests@vger.kernel.org, Jan Kara , Dan Williams , Dave Chinner , Christoph Hellwig , linux-nvdimm@lists.01.org, Jeff Moyer , linux-ext4@vger.kernel.org List-ID: On Wed, Jun 20, 2018 at 04:51:46PM -0600, Ross Zwisler wrote: > I noticed that in some of my C tests in src/ I was incorrectly checking for > mmap() failure by looking for NULL instead of MAP_FAILED. Fix those and > clean up some places where we were testing against -1 (the actual value of > MAP_FAILED) which was manually being cast to a pointer. > > Signed-off-by: Ross Zwisler BTW, I've applied this patch, no need to resend it in v2. Thanks, Eryu From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eryu Guan Subject: Re: [fstests PATCH 1/2] src/: fix up mmap() error checking Date: Fri, 22 Jun 2018 10:28:38 +0800 Message-ID: <20180622022838.GM2780@desktop> References: <20180620225147.12151-1-ross.zwisler@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: Jan Kara , linux-nvdimm-hn68Rpc1hR1g9hUCZPvPmw@public.gmane.org, Dave Chinner , fstests-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-ext4-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Christoph Hellwig To: Ross Zwisler Return-path: Content-Disposition: inline In-Reply-To: <20180620225147.12151-1-ross.zwisler-VuQAYsv1563Yd54FQh9/CA@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linux-nvdimm-bounces-hn68Rpc1hR1g9hUCZPvPmw@public.gmane.org Sender: "Linux-nvdimm" List-Id: linux-ext4.vger.kernel.org On Wed, Jun 20, 2018 at 04:51:46PM -0600, Ross Zwisler wrote: > I noticed that in some of my C tests in src/ I was incorrectly checking for > mmap() failure by looking for NULL instead of MAP_FAILED. Fix those and > clean up some places where we were testing against -1 (the actual value of > MAP_FAILED) which was manually being cast to a pointer. > > Signed-off-by: Ross Zwisler BTW, I've applied this patch, no need to resend it in v2. Thanks, Eryu From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf0-x241.google.com (mail-pf0-x241.google.com [IPv6:2607:f8b0:400e:c00::241]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 65FB4210D5158 for ; Thu, 21 Jun 2018 19:28:44 -0700 (PDT) Received: by mail-pf0-x241.google.com with SMTP id a12-v6so2451742pfi.3 for ; Thu, 21 Jun 2018 19:28:44 -0700 (PDT) Date: Fri, 22 Jun 2018 10:28:38 +0800 From: Eryu Guan Subject: Re: [fstests PATCH 1/2] src/: fix up mmap() error checking Message-ID: <20180622022838.GM2780@desktop> References: <20180620225147.12151-1-ross.zwisler@linux.intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20180620225147.12151-1-ross.zwisler@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-nvdimm-bounces@lists.01.org Sender: "Linux-nvdimm" To: Ross Zwisler Cc: Jan Kara , linux-nvdimm@lists.01.org, Dave Chinner , fstests@vger.kernel.org, linux-ext4@vger.kernel.org, Christoph Hellwig List-ID: On Wed, Jun 20, 2018 at 04:51:46PM -0600, Ross Zwisler wrote: > I noticed that in some of my C tests in src/ I was incorrectly checking for > mmap() failure by looking for NULL instead of MAP_FAILED. Fix those and > clean up some places where we were testing against -1 (the actual value of > MAP_FAILED) which was manually being cast to a pointer. > > Signed-off-by: Ross Zwisler BTW, I've applied this patch, no need to resend it in v2. Thanks, Eryu _______________________________________________ Linux-nvdimm mailing list Linux-nvdimm@lists.01.org https://lists.01.org/mailman/listinfo/linux-nvdimm