From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mx3-rdu2.redhat.com ([66.187.233.73] helo=mx1.redhat.com) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1fWCC0-0003pW-R3 for kexec@lists.infradead.org; Fri, 22 Jun 2018 02:52:58 +0000 Date: Fri, 22 Jun 2018 10:52:35 +0800 From: Baoquan He Subject: Re: [PATCH 3/4 V3] Remap the device table of IOMMU in encrypted manner for kdump Message-ID: <20180622025235.GN29979@MiWiFi-R3L-srv> References: <20180616082714.32035-1-lijiang@redhat.com> <20180616082714.32035-4-lijiang@redhat.com> <60c6f00e-0eb3-d39c-6a1e-8a1dc1e095af@amd.com> <20180621083915.GE3815@MiWiFi-R3L-srv> <4c71ac2a-5c53-f1b1-8de6-4b7b944d5d06@amd.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <4c71ac2a-5c53-f1b1-8de6-4b7b944d5d06@amd.com> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "kexec" Errors-To: kexec-bounces+dwmw2=infradead.org@lists.infradead.org To: Tom Lendacky Cc: dyoung@redhat.com, iommu@lists.linux-foundation.org, kexec@lists.infradead.org, lijiang , linux-kernel@vger.kernel.org T24gMDYvMjEvMTggYXQgMDg6MTJhbSwgVG9tIExlbmRhY2t5IHdyb3RlOgo+IE9uIDYvMjEvMjAx OCAzOjM5IEFNLCBCYW9xdWFuIEhlIHdyb3RlOgo+ID4gT24gMDYvMjEvMTggYXQgMDE6NDJwbSwg bGlqaWFuZyB3cm90ZToKPiA+PiDlnKggMjAxOOW5tDA25pyIMjHml6UgMDA6NDIsIFRvbSBMZW5k YWNreSDlhpnpgZM6Cj4gPj4+IE9uIDYvMTYvMjAxOCAzOjI3IEFNLCBMaWFuYm8gSmlhbmcgd3Jv dGU6Cj4gPj4+PiBJbiBrZHVtcCBtb2RlLCBpdCB3aWxsIGNvcHkgdGhlIGRldmljZSB0YWJsZSBv ZiBJT01NVSBmcm9tIHRoZSBvbGQKPiA+Pj4+IGRldmljZSB0YWJsZSwgd2hpY2ggaXMgZW5jcnlw dGVkIHdoZW4gU01FIGlzIGVuYWJsZWQgaW4gdGhlIGZpcnN0Cj4gPj4+PiBrZXJuZWwuIFNvIHdl IG11c3QgcmVtYXAgaXQgaW4gZW5jcnlwdGVkIG1hbm5lciBpbiBvcmRlciB0byBiZQo+ID4+Pj4g YXV0b21hdGljYWxseSBkZWNyeXB0ZWQgd2hlbiB3ZSByZWFkLgo+ID4+Pj4KPiA+Pj4+IFNpZ25l ZC1vZmYtYnk6IExpYW5ibyBKaWFuZyA8bGlqaWFuZ0ByZWRoYXQuY29tPgo+ID4+Pj4gLS0tCj4g Pj4+PiBTb21lIGNoYW5nZXM6Cj4gPj4+PiAxLiBhZGQgc29tZSBjb21tZW50cwo+ID4+Pj4gMi4g Y2xlYW4gY29tcGlsZSB3YXJuaW5nLgo+ID4+Pj4KPiA+Pj4+ICBkcml2ZXJzL2lvbW11L2FtZF9p b21tdV9pbml0LmMgfCAxNSArKysrKysrKysrKysrKy0KPiA+Pj4+ICAxIGZpbGUgY2hhbmdlZCwg MTQgaW5zZXJ0aW9ucygrKSwgMSBkZWxldGlvbigtKQo+ID4+Pj4KPiA+Pj4+IGRpZmYgLS1naXQg YS9kcml2ZXJzL2lvbW11L2FtZF9pb21tdV9pbml0LmMgYi9kcml2ZXJzL2lvbW11L2FtZF9pb21t dV9pbml0LmMKPiA+Pj4+IGluZGV4IDkwNGM1NzUuLmEyMGFmNGMgMTAwNjQ0Cj4gPj4+PiAtLS0g YS9kcml2ZXJzL2lvbW11L2FtZF9pb21tdV9pbml0LmMKPiA+Pj4+ICsrKyBiL2RyaXZlcnMvaW9t bXUvYW1kX2lvbW11X2luaXQuYwo+ID4+Pj4gQEAgLTg4OSwxMSArODg5LDI0IEBAIHN0YXRpYyBi b29sIGNvcHlfZGV2aWNlX3RhYmxlKHZvaWQpCj4gPj4+PiAgCX0KPiA+Pj4+ICAKPiA+Pj4+ICAJ b2xkX2RldnRiX3BoeXMgPSBlbnRyeSAmIFBBR0VfTUFTSzsKPiA+Pj4+ICsKPiA+Pj4+ICsJLyoK PiA+Pj4+ICsJICogIFdoZW4gc21lIGVuYWJsZSBpbiB0aGUgZmlyc3Qga2VybmVsLCBvbGRfZGV2 dGJfcGh5cyBpbmNsdWRlcyB0aGUKPiA+Pj4+ICsJICogIG1lbW9yeSBlbmNyeXB0aW9uIG1hc2so c21lX21lX21hc2spLCB3ZSBtdXN0IHJlbW92ZSB0aGUgbWVtb3J5Cj4gPj4+PiArCSAqICBlbmNy eXB0aW9uIG1hc2sgdG8gb2J0YWluIHRoZSB0cnVlIHBoeXNpY2FsIGFkZHJlc3MgaW4ga2R1bXAg bW9kZS4KPiA+Pj4+ICsJICovCj4gPj4+PiArCWlmIChtZW1fZW5jcnlwdF9hY3RpdmUoKSAmJiBp c19rZHVtcF9rZXJuZWwoKSkKPiA+Pj4+ICsJCW9sZF9kZXZ0Yl9waHlzID0gX19zbWVfY2xyKG9s ZF9kZXZ0Yl9waHlzKTsKPiA+Pj4+ICsKPiA+Pj4KPiA+Pj4gWW91IGNhbiBwcm9iYWJseSBqdXN0 IHVzZSAiaWYgKGlzX2tkdW1wX2tlcm5lbCgpKSIgaGVyZSwgc2luY2UgbWVtb3J5Cj4gPj4+IGVu Y3J5cHRpb24gaXMgZWl0aGVyIG9uIGluIGJvdGggdGhlIGZpcnN0IGFuZCBzZWNvbmQga2VybmVs IG9yIG9mZiBpbgo+ID4+PiBib3RoIHRoZSBmaXJzdCBhbmQgc2Vjb25kIGtlcm5lbC4gIEF0IHdo aWNoIHBvaW50IF9fc21lX2NscigpIHdpbGwgZG8KPiA+Pj4gdGhlIHByb3BlciB0aGluZy4KPiA+ Pj4KPiA+Pj4gQWN0dWFsbHksIHRoaXMgbmVlZHMgdG8gYmUgZG9uZSBubyBtYXR0ZXIgd2hhdC4g IFdoZW4gZG9pbmcgZWl0aGVyIHRoZQo+ID4+PiBpb3JlbWFwX2VuY3J5cHRlZCgpIG9yIHRoZSBt ZW1yZW1hcCgpLCB0aGUgcGh5c2ljYWwgYWRkcmVzcyBzaG91bGQgbm90Cj4gPj4+IGluY2x1ZGUg dGhlIGVuY3J5cHRpb24gYml0L21hc2suCj4gPj4+Cj4gPj4+IFRoYW5rcywKPiA+Pj4gVG9tCj4g Pj4+Cj4gPj4gVGhhbmtzIGZvciB5b3VyIGNvbW1lbnRzLiBJZiB3ZSBkb24ndCByZW1vdmUgdGhl IG1lbW9yeSBlbmNyeXB0aW9uIG1hc2ssIGl0IHdpbGwKPiA+PiByZXR1cm4gZmFsc2UgYmVjYXVz ZSB0aGUgJ29sZF9kZXZ0Yl9waHlzID49IDB4MTAwMDAwMDAwVUxMJyBtYXkgYmVjb21lIHRydWUu Cj4gPiAKPiA+IExpYW5ibywgeW91IG1heSBub3QgZ2V0IHdoYXQgVG9tIHN1Z2dlc3RlZC4gVG9t IG1lYW5zIG5vIG1hdHRlciB3aGF0IGl0Cj4gPiBpcywgZW5jcnlwdGVkIG9yIG5vdCBpbiAxc3Qg a2VybmVsLCB3ZSBuZWVkIGdldCBwdXJlIHBoeXNpY2FsbCBhZGRyZXNzLAo+ID4gYW5kIHVzaW5n IGJlbG93IGNvZGUgaXMgYWx3YXlzIHJpZ2h0IGZvciBib3RoIGNhc2VzLgo+ID4gCj4gPiAJaWYg KGlzX2tkdW1wX2tlcm5lbCgpKQo+ID4gCQlvbGRfZGV2dGJfcGh5cyA9IF9fc21lX2NscihvbGRf ZGV2dGJfcGh5cyk7Cj4gPiAKPiA+IEFuZCB0aGlzIGlzIHNpbXBsZXIuIFlvdSBldmVuIGNhbiBh ZGQgb25lIGxpbmUgb2YgY29kZSBjb21tZW50IHRvIHNheQo+ID4gbGlrZSAiUGh5c2ljYWwgYWRk cmVzcyB3L28gZW5jcnlwdGlvbiBtYXNrIGlzIG5lZWRlZCBoZXJlLiIKPiAKPiBFdmVuIHNpbXBs ZXIsIHRoZXJlJ3Mgbm8gbmVlZCB0byBldmVuIGNoZWNrIGZvciBpc19rZHVtcF9rZXJuZWwoKS4g IFRoZQo+IF9fc21lX2NscigpIHNob3VsZCBhbHdheXMgYmUgZG9uZSBpZiB0aGUgcGh5c2ljYWwg YWRkcmVzcyBpcyBnb2luZyB0byBiZQo+IHVzZWQgZm9yIHNvbWUgZm9ybSBvZiBpbyBvciBtZW1v cnkgcmVtYXBwaW5nLgo+IAo+IFNvIHlvdSBjb3VsZCBqdXN0IGNoYW5nZSB0aGUgZXhpc3Rpbmc6 Cj4gCj4gCW9sZF9kZXZ0Yl9waHlzID0gZW50cnkgJiBQQUdFX01BU0s7Cj4gCj4gdG86Cj4gCj4g CW9sZF9kZXZ0Yl9waHlzID0gX19zbWVfY2xyKGVudHJ5KSAmIFBBR0VfTUFTSzsKCkFncmVlLCB0 aGlzIGlzIGV2ZW4gYmV0dGVyLgoKPiAKPiA+Pgo+ID4+IExpYW5ibwo+ID4+Pj4gIAlpZiAob2xk X2RldnRiX3BoeXMgPj0gMHgxMDAwMDAwMDBVTEwpIHsKPiA+Pj4+ICAJCXByX2VycigiVGhlIGFk ZHJlc3Mgb2Ygb2xkIGRldmljZSB0YWJsZSBpcyBhYm92ZSA0Rywgbm90IHRydXN0d29ydGh5IVxu Iik7Cj4gPj4+PiAgCQlyZXR1cm4gZmFsc2U7Cj4gPj4+PiAgCX0KPiA+Pj4+IC0Jb2xkX2RldnRi ID0gbWVtcmVtYXAob2xkX2RldnRiX3BoeXMsIGRldl90YWJsZV9zaXplLCBNRU1SRU1BUF9XQik7 Cj4gPj4+PiArCW9sZF9kZXZ0YiA9IChtZW1fZW5jcnlwdF9hY3RpdmUoKSAmJiBpc19rZHVtcF9r ZXJuZWwoKSkKPiA+Pj4+ICsJCSAgICA/IChfX2ZvcmNlIHZvaWQgKilpb3JlbWFwX2VuY3J5cHRl ZChvbGRfZGV2dGJfcGh5cywKPiA+Pj4+ICsJCQkJCQkJZGV2X3RhYmxlX3NpemUpCj4gPj4+PiAr CQkgICAgOiBtZW1yZW1hcChvbGRfZGV2dGJfcGh5cywgZGV2X3RhYmxlX3NpemUsIE1FTVJFTUFQ X1dCKTs+ICsKPiA+Pj4+ICAJaWYgKCFvbGRfZGV2dGIpCj4gPj4+PiAgCQlyZXR1cm4gZmFsc2U7 Cj4gPj4+PiAgCj4gPj4+Pgo+ID4+Cj4gPj4gX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX18KPiA+PiBrZXhlYyBtYWlsaW5nIGxpc3QKPiA+PiBrZXhlY0BsaXN0 cy5pbmZyYWRlYWQub3JnCj4gPj4gaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9s aXN0aW5mby9rZXhlYwo+IAo+IF9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fCj4ga2V4ZWMgbWFpbGluZyBsaXN0Cj4ga2V4ZWNAbGlzdHMuaW5mcmFkZWFkLm9y Zwo+IGh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8va2V4ZWMKCl9f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmtleGVjIG1haWxp bmcgbGlzdAprZXhlY0BsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQu b3JnL21haWxtYW4vbGlzdGluZm8va2V4ZWMK From mboxrd@z Thu Jan 1 00:00:00 1970 From: Baoquan He Subject: Re: [PATCH 3/4 V3] Remap the device table of IOMMU in encrypted manner for kdump Date: Fri, 22 Jun 2018 10:52:35 +0800 Message-ID: <20180622025235.GN29979@MiWiFi-R3L-srv> References: <20180616082714.32035-1-lijiang@redhat.com> <20180616082714.32035-4-lijiang@redhat.com> <60c6f00e-0eb3-d39c-6a1e-8a1dc1e095af@amd.com> <20180621083915.GE3815@MiWiFi-R3L-srv> <4c71ac2a-5c53-f1b1-8de6-4b7b944d5d06@amd.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <4c71ac2a-5c53-f1b1-8de6-4b7b944d5d06-5C7GfCeVMHo@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Tom Lendacky Cc: dyoung-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, kexec-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, lijiang , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: iommu@lists.linux-foundation.org T24gMDYvMjEvMTggYXQgMDg6MTJhbSwgVG9tIExlbmRhY2t5IHdyb3RlOgo+IE9uIDYvMjEvMjAx OCAzOjM5IEFNLCBCYW9xdWFuIEhlIHdyb3RlOgo+ID4gT24gMDYvMjEvMTggYXQgMDE6NDJwbSwg bGlqaWFuZyB3cm90ZToKPiA+PiDlnKggMjAxOOW5tDA25pyIMjHml6UgMDA6NDIsIFRvbSBMZW5k YWNreSDlhpnpgZM6Cj4gPj4+IE9uIDYvMTYvMjAxOCAzOjI3IEFNLCBMaWFuYm8gSmlhbmcgd3Jv dGU6Cj4gPj4+PiBJbiBrZHVtcCBtb2RlLCBpdCB3aWxsIGNvcHkgdGhlIGRldmljZSB0YWJsZSBv ZiBJT01NVSBmcm9tIHRoZSBvbGQKPiA+Pj4+IGRldmljZSB0YWJsZSwgd2hpY2ggaXMgZW5jcnlw dGVkIHdoZW4gU01FIGlzIGVuYWJsZWQgaW4gdGhlIGZpcnN0Cj4gPj4+PiBrZXJuZWwuIFNvIHdl IG11c3QgcmVtYXAgaXQgaW4gZW5jcnlwdGVkIG1hbm5lciBpbiBvcmRlciB0byBiZQo+ID4+Pj4g YXV0b21hdGljYWxseSBkZWNyeXB0ZWQgd2hlbiB3ZSByZWFkLgo+ID4+Pj4KPiA+Pj4+IFNpZ25l ZC1vZmYtYnk6IExpYW5ibyBKaWFuZyA8bGlqaWFuZ0ByZWRoYXQuY29tPgo+ID4+Pj4gLS0tCj4g Pj4+PiBTb21lIGNoYW5nZXM6Cj4gPj4+PiAxLiBhZGQgc29tZSBjb21tZW50cwo+ID4+Pj4gMi4g Y2xlYW4gY29tcGlsZSB3YXJuaW5nLgo+ID4+Pj4KPiA+Pj4+ICBkcml2ZXJzL2lvbW11L2FtZF9p b21tdV9pbml0LmMgfCAxNSArKysrKysrKysrKysrKy0KPiA+Pj4+ICAxIGZpbGUgY2hhbmdlZCwg MTQgaW5zZXJ0aW9ucygrKSwgMSBkZWxldGlvbigtKQo+ID4+Pj4KPiA+Pj4+IGRpZmYgLS1naXQg YS9kcml2ZXJzL2lvbW11L2FtZF9pb21tdV9pbml0LmMgYi9kcml2ZXJzL2lvbW11L2FtZF9pb21t dV9pbml0LmMKPiA+Pj4+IGluZGV4IDkwNGM1NzUuLmEyMGFmNGMgMTAwNjQ0Cj4gPj4+PiAtLS0g YS9kcml2ZXJzL2lvbW11L2FtZF9pb21tdV9pbml0LmMKPiA+Pj4+ICsrKyBiL2RyaXZlcnMvaW9t bXUvYW1kX2lvbW11X2luaXQuYwo+ID4+Pj4gQEAgLTg4OSwxMSArODg5LDI0IEBAIHN0YXRpYyBi b29sIGNvcHlfZGV2aWNlX3RhYmxlKHZvaWQpCj4gPj4+PiAgCX0KPiA+Pj4+ICAKPiA+Pj4+ICAJ b2xkX2RldnRiX3BoeXMgPSBlbnRyeSAmIFBBR0VfTUFTSzsKPiA+Pj4+ICsKPiA+Pj4+ICsJLyoK PiA+Pj4+ICsJICogIFdoZW4gc21lIGVuYWJsZSBpbiB0aGUgZmlyc3Qga2VybmVsLCBvbGRfZGV2 dGJfcGh5cyBpbmNsdWRlcyB0aGUKPiA+Pj4+ICsJICogIG1lbW9yeSBlbmNyeXB0aW9uIG1hc2so c21lX21lX21hc2spLCB3ZSBtdXN0IHJlbW92ZSB0aGUgbWVtb3J5Cj4gPj4+PiArCSAqICBlbmNy eXB0aW9uIG1hc2sgdG8gb2J0YWluIHRoZSB0cnVlIHBoeXNpY2FsIGFkZHJlc3MgaW4ga2R1bXAg bW9kZS4KPiA+Pj4+ICsJICovCj4gPj4+PiArCWlmIChtZW1fZW5jcnlwdF9hY3RpdmUoKSAmJiBp c19rZHVtcF9rZXJuZWwoKSkKPiA+Pj4+ICsJCW9sZF9kZXZ0Yl9waHlzID0gX19zbWVfY2xyKG9s ZF9kZXZ0Yl9waHlzKTsKPiA+Pj4+ICsKPiA+Pj4KPiA+Pj4gWW91IGNhbiBwcm9iYWJseSBqdXN0 IHVzZSAiaWYgKGlzX2tkdW1wX2tlcm5lbCgpKSIgaGVyZSwgc2luY2UgbWVtb3J5Cj4gPj4+IGVu Y3J5cHRpb24gaXMgZWl0aGVyIG9uIGluIGJvdGggdGhlIGZpcnN0IGFuZCBzZWNvbmQga2VybmVs IG9yIG9mZiBpbgo+ID4+PiBib3RoIHRoZSBmaXJzdCBhbmQgc2Vjb25kIGtlcm5lbC4gIEF0IHdo aWNoIHBvaW50IF9fc21lX2NscigpIHdpbGwgZG8KPiA+Pj4gdGhlIHByb3BlciB0aGluZy4KPiA+ Pj4KPiA+Pj4gQWN0dWFsbHksIHRoaXMgbmVlZHMgdG8gYmUgZG9uZSBubyBtYXR0ZXIgd2hhdC4g IFdoZW4gZG9pbmcgZWl0aGVyIHRoZQo+ID4+PiBpb3JlbWFwX2VuY3J5cHRlZCgpIG9yIHRoZSBt ZW1yZW1hcCgpLCB0aGUgcGh5c2ljYWwgYWRkcmVzcyBzaG91bGQgbm90Cj4gPj4+IGluY2x1ZGUg dGhlIGVuY3J5cHRpb24gYml0L21hc2suCj4gPj4+Cj4gPj4+IFRoYW5rcywKPiA+Pj4gVG9tCj4g Pj4+Cj4gPj4gVGhhbmtzIGZvciB5b3VyIGNvbW1lbnRzLiBJZiB3ZSBkb24ndCByZW1vdmUgdGhl IG1lbW9yeSBlbmNyeXB0aW9uIG1hc2ssIGl0IHdpbGwKPiA+PiByZXR1cm4gZmFsc2UgYmVjYXVz ZSB0aGUgJ29sZF9kZXZ0Yl9waHlzID49IDB4MTAwMDAwMDAwVUxMJyBtYXkgYmVjb21lIHRydWUu Cj4gPiAKPiA+IExpYW5ibywgeW91IG1heSBub3QgZ2V0IHdoYXQgVG9tIHN1Z2dlc3RlZC4gVG9t IG1lYW5zIG5vIG1hdHRlciB3aGF0IGl0Cj4gPiBpcywgZW5jcnlwdGVkIG9yIG5vdCBpbiAxc3Qg a2VybmVsLCB3ZSBuZWVkIGdldCBwdXJlIHBoeXNpY2FsbCBhZGRyZXNzLAo+ID4gYW5kIHVzaW5n IGJlbG93IGNvZGUgaXMgYWx3YXlzIHJpZ2h0IGZvciBib3RoIGNhc2VzLgo+ID4gCj4gPiAJaWYg KGlzX2tkdW1wX2tlcm5lbCgpKQo+ID4gCQlvbGRfZGV2dGJfcGh5cyA9IF9fc21lX2NscihvbGRf ZGV2dGJfcGh5cyk7Cj4gPiAKPiA+IEFuZCB0aGlzIGlzIHNpbXBsZXIuIFlvdSBldmVuIGNhbiBh ZGQgb25lIGxpbmUgb2YgY29kZSBjb21tZW50IHRvIHNheQo+ID4gbGlrZSAiUGh5c2ljYWwgYWRk cmVzcyB3L28gZW5jcnlwdGlvbiBtYXNrIGlzIG5lZWRlZCBoZXJlLiIKPiAKPiBFdmVuIHNpbXBs ZXIsIHRoZXJlJ3Mgbm8gbmVlZCB0byBldmVuIGNoZWNrIGZvciBpc19rZHVtcF9rZXJuZWwoKS4g IFRoZQo+IF9fc21lX2NscigpIHNob3VsZCBhbHdheXMgYmUgZG9uZSBpZiB0aGUgcGh5c2ljYWwg YWRkcmVzcyBpcyBnb2luZyB0byBiZQo+IHVzZWQgZm9yIHNvbWUgZm9ybSBvZiBpbyBvciBtZW1v cnkgcmVtYXBwaW5nLgo+IAo+IFNvIHlvdSBjb3VsZCBqdXN0IGNoYW5nZSB0aGUgZXhpc3Rpbmc6 Cj4gCj4gCW9sZF9kZXZ0Yl9waHlzID0gZW50cnkgJiBQQUdFX01BU0s7Cj4gCj4gdG86Cj4gCj4g CW9sZF9kZXZ0Yl9waHlzID0gX19zbWVfY2xyKGVudHJ5KSAmIFBBR0VfTUFTSzsKCkFncmVlLCB0 aGlzIGlzIGV2ZW4gYmV0dGVyLgoKPiAKPiA+Pgo+ID4+IExpYW5ibwo+ID4+Pj4gIAlpZiAob2xk X2RldnRiX3BoeXMgPj0gMHgxMDAwMDAwMDBVTEwpIHsKPiA+Pj4+ICAJCXByX2VycigiVGhlIGFk ZHJlc3Mgb2Ygb2xkIGRldmljZSB0YWJsZSBpcyBhYm92ZSA0Rywgbm90IHRydXN0d29ydGh5IVxu Iik7Cj4gPj4+PiAgCQlyZXR1cm4gZmFsc2U7Cj4gPj4+PiAgCX0KPiA+Pj4+IC0Jb2xkX2RldnRi ID0gbWVtcmVtYXAob2xkX2RldnRiX3BoeXMsIGRldl90YWJsZV9zaXplLCBNRU1SRU1BUF9XQik7 Cj4gPj4+PiArCW9sZF9kZXZ0YiA9IChtZW1fZW5jcnlwdF9hY3RpdmUoKSAmJiBpc19rZHVtcF9r ZXJuZWwoKSkKPiA+Pj4+ICsJCSAgICA/IChfX2ZvcmNlIHZvaWQgKilpb3JlbWFwX2VuY3J5cHRl ZChvbGRfZGV2dGJfcGh5cywKPiA+Pj4+ICsJCQkJCQkJZGV2X3RhYmxlX3NpemUpCj4gPj4+PiAr CQkgICAgOiBtZW1yZW1hcChvbGRfZGV2dGJfcGh5cywgZGV2X3RhYmxlX3NpemUsIE1FTVJFTUFQ X1dCKTs+ICsKPiA+Pj4+ICAJaWYgKCFvbGRfZGV2dGIpCj4gPj4+PiAgCQlyZXR1cm4gZmFsc2U7 Cj4gPj4+PiAgCj4gPj4+Pgo+ID4+Cj4gPj4gX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX18KPiA+PiBrZXhlYyBtYWlsaW5nIGxpc3QKPiA+PiBrZXhlY0BsaXN0 cy5pbmZyYWRlYWQub3JnCj4gPj4gaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9s aXN0aW5mby9rZXhlYwo+IAo+IF9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fCj4ga2V4ZWMgbWFpbGluZyBsaXN0Cj4ga2V4ZWNAbGlzdHMuaW5mcmFkZWFkLm9y Zwo+IGh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8va2V4ZWMKX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KaW9tbXUgbWFpbGlu ZyBsaXN0CmlvbW11QGxpc3RzLmxpbnV4LWZvdW5kYXRpb24ub3JnCmh0dHBzOi8vbGlzdHMubGlu dXhmb3VuZGF0aW9uLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2lvbW11 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 50731C43143 for ; Fri, 22 Jun 2018 02:52:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0204A23C7F for ; Fri, 22 Jun 2018 02:52:46 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0204A23C7F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934276AbeFVCwo (ORCPT ); Thu, 21 Jun 2018 22:52:44 -0400 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:58538 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S933914AbeFVCwn (ORCPT ); Thu, 21 Jun 2018 22:52:43 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 68D9E4015199; Fri, 22 Jun 2018 02:52:43 +0000 (UTC) Received: from localhost (ovpn-8-18.pek2.redhat.com [10.72.8.18]) by smtp.corp.redhat.com (Postfix) with ESMTPS id CEEAD1117652; Fri, 22 Jun 2018 02:52:40 +0000 (UTC) Date: Fri, 22 Jun 2018 10:52:35 +0800 From: Baoquan He To: Tom Lendacky Cc: lijiang , kexec@lists.infradead.org, iommu@lists.linux-foundation.org, dyoung@redhat.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/4 V3] Remap the device table of IOMMU in encrypted manner for kdump Message-ID: <20180622025235.GN29979@MiWiFi-R3L-srv> References: <20180616082714.32035-1-lijiang@redhat.com> <20180616082714.32035-4-lijiang@redhat.com> <60c6f00e-0eb3-d39c-6a1e-8a1dc1e095af@amd.com> <20180621083915.GE3815@MiWiFi-R3L-srv> <4c71ac2a-5c53-f1b1-8de6-4b7b944d5d06@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <4c71ac2a-5c53-f1b1-8de6-4b7b944d5d06@amd.com> User-Agent: Mutt/1.9.1 (2017-09-22) X-Scanned-By: MIMEDefang 2.78 on 10.11.54.3 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.6]); Fri, 22 Jun 2018 02:52:43 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.6]); Fri, 22 Jun 2018 02:52:43 +0000 (UTC) for IP:'10.11.54.3' DOMAIN:'int-mx03.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'bhe@redhat.com' RCPT:'' Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/21/18 at 08:12am, Tom Lendacky wrote: > On 6/21/2018 3:39 AM, Baoquan He wrote: > > On 06/21/18 at 01:42pm, lijiang wrote: > >> 在 2018年06月21日 00:42, Tom Lendacky 写道: > >>> On 6/16/2018 3:27 AM, Lianbo Jiang wrote: > >>>> In kdump mode, it will copy the device table of IOMMU from the old > >>>> device table, which is encrypted when SME is enabled in the first > >>>> kernel. So we must remap it in encrypted manner in order to be > >>>> automatically decrypted when we read. > >>>> > >>>> Signed-off-by: Lianbo Jiang > >>>> --- > >>>> Some changes: > >>>> 1. add some comments > >>>> 2. clean compile warning. > >>>> > >>>> drivers/iommu/amd_iommu_init.c | 15 ++++++++++++++- > >>>> 1 file changed, 14 insertions(+), 1 deletion(-) > >>>> > >>>> diff --git a/drivers/iommu/amd_iommu_init.c b/drivers/iommu/amd_iommu_init.c > >>>> index 904c575..a20af4c 100644 > >>>> --- a/drivers/iommu/amd_iommu_init.c > >>>> +++ b/drivers/iommu/amd_iommu_init.c > >>>> @@ -889,11 +889,24 @@ static bool copy_device_table(void) > >>>> } > >>>> > >>>> old_devtb_phys = entry & PAGE_MASK; > >>>> + > >>>> + /* > >>>> + * When sme enable in the first kernel, old_devtb_phys includes the > >>>> + * memory encryption mask(sme_me_mask), we must remove the memory > >>>> + * encryption mask to obtain the true physical address in kdump mode. > >>>> + */ > >>>> + if (mem_encrypt_active() && is_kdump_kernel()) > >>>> + old_devtb_phys = __sme_clr(old_devtb_phys); > >>>> + > >>> > >>> You can probably just use "if (is_kdump_kernel())" here, since memory > >>> encryption is either on in both the first and second kernel or off in > >>> both the first and second kernel. At which point __sme_clr() will do > >>> the proper thing. > >>> > >>> Actually, this needs to be done no matter what. When doing either the > >>> ioremap_encrypted() or the memremap(), the physical address should not > >>> include the encryption bit/mask. > >>> > >>> Thanks, > >>> Tom > >>> > >> Thanks for your comments. If we don't remove the memory encryption mask, it will > >> return false because the 'old_devtb_phys >= 0x100000000ULL' may become true. > > > > Lianbo, you may not get what Tom suggested. Tom means no matter what it > > is, encrypted or not in 1st kernel, we need get pure physicall address, > > and using below code is always right for both cases. > > > > if (is_kdump_kernel()) > > old_devtb_phys = __sme_clr(old_devtb_phys); > > > > And this is simpler. You even can add one line of code comment to say > > like "Physical address w/o encryption mask is needed here." > > Even simpler, there's no need to even check for is_kdump_kernel(). The > __sme_clr() should always be done if the physical address is going to be > used for some form of io or memory remapping. > > So you could just change the existing: > > old_devtb_phys = entry & PAGE_MASK; > > to: > > old_devtb_phys = __sme_clr(entry) & PAGE_MASK; Agree, this is even better. > > >> > >> Lianbo > >>>> if (old_devtb_phys >= 0x100000000ULL) { > >>>> pr_err("The address of old device table is above 4G, not trustworthy!\n"); > >>>> return false; > >>>> } > >>>> - old_devtb = memremap(old_devtb_phys, dev_table_size, MEMREMAP_WB); > >>>> + old_devtb = (mem_encrypt_active() && is_kdump_kernel()) > >>>> + ? (__force void *)ioremap_encrypted(old_devtb_phys, > >>>> + dev_table_size) > >>>> + : memremap(old_devtb_phys, dev_table_size, MEMREMAP_WB);> + > >>>> if (!old_devtb) > >>>> return false; > >>>> > >>>> > >> > >> _______________________________________________ > >> kexec mailing list > >> kexec@lists.infradead.org > >> http://lists.infradead.org/mailman/listinfo/kexec > > _______________________________________________ > kexec mailing list > kexec@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/kexec