From mboxrd@z Thu Jan 1 00:00:00 1970 From: Konrad Rzeszutek Wilk Subject: Re: [PATCH v3 07/13] xen/arm: Simplify alternative patching of non-writable region Date: Fri, 22 Jun 2018 09:33:22 -0400 Message-ID: <20180622133322.GG10869@char.US.ORACLE.com> References: <20180612113643.32020-1-julien.grall@arm.com> <20180612113643.32020-8-julien.grall@arm.com> <20180612211759.GC17709@char.us.oracle.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1fWMBv-0000ag-T2 for xen-devel@lists.xenproject.org; Fri, 22 Jun 2018 13:33:31 +0000 Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" To: Julien Grall Cc: xen-devel@lists.xenproject.org, nd@arm.com, sstabellini@kernel.org, andre.przywara@arm.com List-Id: xen-devel@lists.xenproject.org T24gVHVlLCBKdW4gMTIsIDIwMTggYXQgMTE6MDY6MTZQTSArMDEwMCwgSnVsaWVuIEdyYWxsIHdy b3RlOgo+IEhpIEtvbnJhZCwKPiAKPiBPbiAxMi8wNi8yMDE4IDIyOjE3LCBLb25yYWQgUnplc3p1 dGVrIFdpbGsgd3JvdGU6Cj4gPiBPbiBUdWUsIEp1biAxMiwgMjAxOCBhdCAxMjozNjozN1BNICsw MTAwLCBKdWxpZW4gR3JhbGwgd3JvdGU6Cj4gPiA+IER1cmluZyB0aGUgTU1VIHNldHVwIHByb2Nl c3MsIFhlbiB3aWxsIHNldCBTQ1RMUl9FTDIuV05YCj4gPiA+IChXcml0ZS1Ob24tZVhlY3V0YWJs ZSkgYml0LiBCZWNhdXNlIG9mIHRoYXQsIHRoZSBhbHRlcm5hdGl2ZSBjb2RlIG5lZWQKPiA+ID4g dG8gcmUtbWFwcGVkIHRoZSByZWdpb24gaW4gYSBkaWZmZXJlbmNlIHBsYWNlIGluIG9yZGVyIHRv IG1vZGlmeSB0aGUKPiA+ID4gdGV4dCBzZWN0aW9uLgo+ID4gPiAKPiA+ID4gQXQgdGhlIG1vbWVu dCwgdGhlIGZ1bmN0aW9uIHBhdGNoaW5nIHRoZSBjb2RlIGlzIG9ubHkgYXdhcmUgb2YgdGhlCj4g PiA+IHJlLW1hcHBlZCByZWdpb24uIFRoaXMgcmVxdWlyZXMgdGhlIGNhbGxlciB0byBtZXNzIHdp dGggWGVuIGludGVybmFsIGluCj4gPiA+IG9yZGVyIHRvIGhhdmUgZnVuY3Rpb24gc3VjaCBhcyBp c19hY3RpdmVfa2VybmVsX3RleHQoKSB3b3JraW5nLgo+ID4gPiAKPiA+ID4gQWxsIHRoZSBpbnRl cmFjdGlvbnMgd2l0aCBYZW4gaW50ZXJuYWwgY2FuIGJlIHJlbW92ZWQgYnkgc3BlY2lmeWluZyB0 aGUKPiA+ID4gb2Zmc2V0IGJldHdlZW4gdGhlIHJlZ2lvbiBwYXRjaCBhbmQgdGhlIHdyaXRhYmxl IHJlZ2lvbiBmb3IgdXBkYXRpbmcgdGhlCj4gPiA+IGluc3RydWN0aW9uCj4gPiA+IAo+ID4gPiBU aGlzIHNpbXBsaWZpY2F0aW9uIHdpbGwgYWxzbyBtYWtlIGl0IGVhc2llciB0byBpbnRlZ3JhdGUg ZHluYW1pYyBwYXRjaGluZwo+ID4gPiBpbiBhIGZvbGxvdy11cCBwYXRjaC4gSW5kZWVkLCB0aGUg Y2FsbGJhY2sgYWRkcmVzcyBzaG91bGQgYmUgaW4KPiA+ID4gYW4gb3JpZ2luYWwgcmVnaW9uIGFu ZCBub3QgcmUtbWFwcGVkIG9ubHkgd2hpY2ggaXMgd3JpdGVhYmxlIG5vbi1leGVjdXRhYmxlLgo+ ID4gPiAKPiA+ID4gVGhpcyBpcyBwYXJ0IG9mIFhTQS0yNjMuCj4gPiA+IAo+ID4gPiBTaWduZWQt b2ZmLWJ5OiBKdWxpZW4gR3JhbGwgPGp1bGllbi5ncmFsbEBhcm0uY29tPgo+ID4gPiBSZXZpZXdl ZC1ieTogU3RlZmFubyBTdGFiZWxsaW5pIDxzc3RhYmVsbGluaUBrZXJuZWwub3JnPgo+ID4gPiAK PiA+ID4gLS0tCj4gPiA+IAo+ID4gPiBDYzogS29ucmFkIFJ6ZXN6dXRlayBXaWxrIDxrb25yYWQu d2lsa0BvcmFjbGUuY29tPgo+ID4gPiAKPiA+ID4gICAgICBDaGFuZ2VzIGluIHYzOgo+ID4gPiAg ICAgICAgICAtIEFkZCBzdGVmYW5vJ3MgcmV2aWV3ZWQtYnkKPiA+ID4gCj4gPiA+ICAgICAgQ2hh bmdlcyBpbiB2MjoKPiA+ID4gICAgICAgICAgLSBBZGQgY29tbWl0IG1lc3NhZ2UKPiA+ID4gICAg ICAgICAgLSBSZW1vdmUgY29tbWVudCBpbiB0aGUgY29kZSB0aGF0IGRvZXMgbm90IG1ha2Ugc2Vu c2UgYW55bW9yZQo+ID4gPiAtLS0KPiA+ID4gICB4ZW4vYXJjaC9hcm0vYWx0ZXJuYXRpdmUuYyB8 IDQyICsrKysrKysrKysrKystLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLQo+ID4gPiAgIDEg ZmlsZSBjaGFuZ2VkLCAxMyBpbnNlcnRpb25zKCspLCAyOSBkZWxldGlvbnMoLSkKPiA+ID4gCj4g PiA+IGRpZmYgLS1naXQgYS94ZW4vYXJjaC9hcm0vYWx0ZXJuYXRpdmUuYyBiL3hlbi9hcmNoL2Fy bS9hbHRlcm5hdGl2ZS5jCj4gPiA+IGluZGV4IDlmZmRjNDc1ZDYuLjkzNmNmMDQ5NTYgMTAwNjQ0 Cj4gPiA+IC0tLSBhL3hlbi9hcmNoL2FybS9hbHRlcm5hdGl2ZS5jCj4gPiA+ICsrKyBiL3hlbi9h cmNoL2FybS9hbHRlcm5hdGl2ZS5jCj4gPiA+IEBAIC05NywxMiArOTcsMTYgQEAgc3RhdGljIHUz MiBnZXRfYWx0X2luc24oY29uc3Qgc3RydWN0IGFsdF9pbnN0ciAqYWx0LAo+ID4gPiAgIC8qCj4g PiA+ICAgICogVGhlIHJlZ2lvbiBwYXRjaGVkIHNob3VsZCBiZSByZWFkLXdyaXRlIHRvIGFsbG93 IF9fYXBwbHlfYWx0ZXJuYXRpdmVzCj4gPiA+ICAgICogdG8gcmVwbGFjaW5nIHRoZSBpbnN0cnVj dGlvbnMgd2hlbiBuZWNlc3NhcnkuCj4gPiA+ICsgKgo+ID4gPiArICogQHVwZGF0ZV9vZmZzZXQ6 IE9mZnNldCBiZXR3ZWVuIHRoZSByZWdpb24gcGF0Y2hlZCBhbmQgdGhlIHdyaXRhYmxlCj4gPiA+ ICsgKiByZWdpb24gZm9yIHRoZSB1cGRhdGUuIDAgaWYgdGhlIHBhdGNoZWQgcmVnaW9uIGlzIHdy aXRhYmxlLgo+ID4gPiAgICAqLwo+ID4gPiAtc3RhdGljIGludCBfX2FwcGx5X2FsdGVybmF0aXZl cyhjb25zdCBzdHJ1Y3QgYWx0X3JlZ2lvbiAqcmVnaW9uKQo+ID4gPiArc3RhdGljIGludCBfX2Fw cGx5X2FsdGVybmF0aXZlcyhjb25zdCBzdHJ1Y3QgYWx0X3JlZ2lvbiAqcmVnaW9uLAo+ID4gPiAr ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBwYWRkcl90IHVwZGF0ZV9vZmZzZXQpCj4g PiA+ICAgewo+ID4gPiAgICAgICBjb25zdCBzdHJ1Y3QgYWx0X2luc3RyICphbHQ7Cj4gPiA+IC0g ICAgY29uc3QgdTMyICpyZXBscHRyOwo+ID4gPiAtICAgIHUzMiAqb3JpZ3B0cjsKPiA+ID4gKyAg ICBjb25zdCB1MzIgKnJlcGxwdHIsICpvcmlncHRyOwo+ID4gPiArICAgIHUzMiAqdXBkcHRyOwo+ ID4gPiAgICAgICBwcmludGsoWEVOTE9HX0lORk8gImFsdGVybmF0aXZlczogUGF0Y2hpbmcgd2l0 aCBhbHQgdGFibGUgJXAgLT4gJXBcbiIsCj4gPiA+ICAgICAgICAgICAgICByZWdpb24tPmJlZ2lu LCByZWdpb24tPmVuZCk7Cj4gPiA+IEBAIC0xMTgsNiArMTIyLDcgQEAgc3RhdGljIGludCBfX2Fw cGx5X2FsdGVybmF0aXZlcyhjb25zdCBzdHJ1Y3QgYWx0X3JlZ2lvbiAqcmVnaW9uKQo+ID4gPiAg ICAgICAgICAgQlVHX09OKGFsdC0+YWx0X2xlbiAhPSBhbHQtPm9yaWdfbGVuKTsKPiA+ID4gICAg ICAgICAgIG9yaWdwdHIgPSBBTFRfT1JJR19QVFIoYWx0KTsKPiA+ID4gKyAgICAgICAgdXBkcHRy ID0gKHZvaWQgKilvcmlncHRyICsgdXBkYXRlX29mZnNldDsKPiA+ID4gICAgICAgICAgIHJlcGxw dHIgPSBBTFRfUkVQTF9QVFIoYWx0KTsKPiA+ID4gICAgICAgICAgIG5yX2luc3QgPSBhbHQtPmFs dF9sZW4gLyBzaXplb2YoaW5zbik7Cj4gPiA+IEBAIC0xMjUsNyArMTMwLDcgQEAgc3RhdGljIGlu dCBfX2FwcGx5X2FsdGVybmF0aXZlcyhjb25zdCBzdHJ1Y3QgYWx0X3JlZ2lvbiAqcmVnaW9uKQo+ ID4gPiAgICAgICAgICAgZm9yICggaSA9IDA7IGkgPCBucl9pbnN0OyBpKysgKQo+ID4gPiAgICAg ICAgICAgewo+ID4gPiAgICAgICAgICAgICAgIGluc24gPSBnZXRfYWx0X2luc24oYWx0LCBvcmln cHRyICsgaSwgcmVwbHB0ciArIGkpOwo+ID4gPiAtICAgICAgICAgICAgKihvcmlncHRyICsgaSkg PSBjcHVfdG9fbGUzMihpbnNuKTsKPiA+ID4gKyAgICAgICAgICAgICoodXBkcHRyICsgaSkgPSBj cHVfdG9fbGUzMihpbnNuKTsKPiA+ID4gICAgICAgICAgIH0KPiA+ID4gICAgICAgICAgIC8qIEVu c3VyZSB0aGUgbmV3IGluc3RydWN0aW9ucyByZWFjaGVkIHRoZSBtZW1vcnkgYW5kIG51a2UgKi8K PiA+ID4gQEAgLTE2Miw5ICsxNjcsNiBAQCBzdGF0aWMgaW50IF9fYXBwbHlfYWx0ZXJuYXRpdmVz X211bHRpX3N0b3Aodm9pZCAqdW51c2VkKQo+ID4gPiAgICAgICAgICAgcGFkZHJfdCB4ZW5fc2l6 ZSA9IF9lbmQgLSBfc3RhcnQ7Cj4gPiA+ICAgICAgICAgICB1bnNpZ25lZCBpbnQgeGVuX29yZGVy ID0gZ2V0X29yZGVyX2Zyb21fYnl0ZXMoeGVuX3NpemUpOwo+ID4gPiAgICAgICAgICAgdm9pZCAq eGVubWFwOwo+ID4gPiAtICAgICAgICBzdHJ1Y3QgdmlydHVhbF9yZWdpb24gcGF0Y2hfcmVnaW9u ID0gewo+ID4gPiAtICAgICAgICAgICAgLmxpc3QgPSBMSVNUX0hFQURfSU5JVChwYXRjaF9yZWdp b24ubGlzdCksCj4gPiA+IC0gICAgICAgIH07Cj4gPiA+ICAgICAgICAgICBCVUdfT04ocGF0Y2hl ZCk7Cj4gPiA+IEBAIC0xNzcsMzEgKzE3OSwxMyBAQCBzdGF0aWMgaW50IF9fYXBwbHlfYWx0ZXJu YXRpdmVzX211bHRpX3N0b3Aodm9pZCAqdW51c2VkKQo+ID4gPiAgICAgICAgICAgLyogUmUtbWFw cGluZyBYZW4gaXMgbm90IGV4cGVjdGVkIHRvIGZhaWwgZHVyaW5nIGJvb3QuICovCj4gPiA+ICAg ICAgICAgICBCVUdfT04oIXhlbm1hcCk7Cj4gPiA+IC0gICAgICAgIC8qCj4gPiA+IC0gICAgICAg ICAqIElmIHdlIGdlbmVyYXRlIGEgbmV3IGJyYW5jaCBpbnN0cnVjdGlvbiwgdGhlIHRhcmdldCB3 aWxsIGJlCj4gPiA+IC0gICAgICAgICAqIGNhbGN1bGF0ZWQgaW4gdGhpcyByZS1tYXBwZWQgWGVu IHJlZ2lvbi4gU28gd2UgaGF2ZSB0byByZWdpc3Rlcgo+ID4gPiAtICAgICAgICAgKiB0aGlzIHJl LW1hcHBlZCBYZW4gcmVnaW9uIGFzIGEgdmlydHVhbCByZWdpb24gdGVtcG9yYXJpbHkuCj4gPiAK PiA+IFdoYXQgYWJvdXQgdGhpcz8KPiA+IAo+ID4gV29uJ3QgdGhpcyBtZWFuIHRoZSB0cmFwcyAo aWYgdGhlcmUgYXJlIGFueSkgd29uJ3QgYmUgcmVjb2duaXplZCBhdCBhbGwKPiA+IGR1cmluZyB0 aGlzIHBhdGNoaW5nPwo+IAo+IFdoYXQgZG8geW91IG1lYW4gYnkgcmVjb2duaXplZD8gVGhpcyBu ZXcgcmVnaW9uIHdpbGwgb25seSBiZSBhY2Nlc3NlZCB0bwo+IHdyaXRlIGluc3RydWN0aW9uLiBU aGUgb25seSBwb3RlbnRpYWwgZmF1bHQgb24gdGhhdCByZWdpb24gaXMgYSBkYXRhIGFib3J0LgoK RXhhY3RseSB0aGUgZGF0YSBhYm9ydC4KCk15IHJlY29sbGVjdGlvbiBpcyB0aGF0IHRoZSBkYXRh IGFib3J0IHdvdWxkIHByaW50IGEgc3RhY2sgdHJhY2UuIEFuZCAKdGhlIHN0YWNrIHRyYWNlIG5l ZWRzIHN5bWJvbCBpbmZvcm1hdGlvbiAtIHdoaWNoIGl0IGdldHMgZnJvbSB2aXJ0dWFsX3JlZ2lv bi4KCkJ1dCBpZiB2aXJ0dWFsX3JlZ2lvbiBpcyBub3QgcmVnaXN0ZXJlZCB0aGVuIHRoZSBzdGFj ayB3b24ndCBjb250YWluIHRoZQpuYW1lIG9mIHRoZSBmdW5jdGlvbiB0aGF0IGhhZCBhbiBkYXRh IGFib3J0IGFzIHRoZSBwYXRjaGluZyBpcyBkb25lLgoKX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVsIG1haWxpbmcgbGlzdApYZW4tZGV2ZWxA bGlzdHMueGVucHJvamVjdC5vcmcKaHR0cHM6Ly9saXN0cy54ZW5wcm9qZWN0Lm9yZy9tYWlsbWFu L2xpc3RpbmZvL3hlbi1kZXZlbA==