From: Christoph Hellwig <hch@lst.de>
To: "jianchao.wang" <jianchao.w.wang@oracle.com>
Cc: Christoph Hellwig <hch@lst.de>,
Keith Busch <keith.busch@intel.com>,
axboe@kernel.dk, martin.petersen@oracle.com,
josef@toxicpanda.com, ulf.hansson@linaro.org,
linux-block@vger.kernel.org, linux-scsi@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/5]stop normal completion path entering a timeout req
Date: Fri, 22 Jun 2018 17:10:43 +0200 [thread overview]
Message-ID: <20180622151043.GA13470@lst.de> (raw)
In-Reply-To: <a68ad043-26a1-d3d8-2009-504ba4230e0f@oracle.com>
On Thu, Jun 21, 2018 at 04:22:22PM +0800, jianchao.wang wrote:
> > Trace, please. With the latest kernel. I'm not saying that there
> > is nothing to fix, but the mode of never completing once timeout
> > requests as currently done is SCSI is clearly broken.
> >
>
> I didn't find the existing method to simulate this.
> So I modified the scsi-debug as following patch as install it as following:
> modprobe scsi-debug delay=-1 ndelay=-1
> Both 4.17-rc1 and 4.18-rc1 with this patch set could survive from the test.
What tree is this against? I can't apply it to either current Linus'
tree or 4.17 for that matter.
Also I'm not sure this blk_abort_request call is representative
of the real world. Drivers do drain their queues before calling
it in general, e.g. take a look at ata_eh_set_pending for the
probably most common user.
next prev parent reply other threads:[~2018-06-22 15:10 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-20 13:22 [PATCH 0/5]stop normal completion path entering a timeout req Jianchao Wang
2018-06-20 13:22 ` [PATCH 1/5] blk-mq: prevent normal completion from entering a timeout request Jianchao Wang
2018-06-20 13:22 ` [PATCH 2/5] nbd: use __blk_mq_complete_request in timeout path Jianchao Wang
2018-06-20 14:13 ` Josef Bacik
2018-06-20 13:22 ` [PATCH 3/5] null_blk: " Jianchao Wang
2018-06-20 13:22 ` [PATCH 4/5] mmc: " Jianchao Wang
2018-06-20 13:22 ` [PATCH 5/5] nvme: " Jianchao Wang
2018-06-20 14:39 ` Christoph Hellwig
2018-06-21 2:09 ` jianchao.wang
2018-06-24 18:07 ` Sagi Grimberg
2018-06-25 1:40 ` jianchao.wang
2018-06-25 18:51 ` Sagi Grimberg
2018-06-20 18:16 ` [PATCH 0/5]stop normal completion path entering a timeout req Keith Busch
2018-06-21 1:43 ` jianchao.wang
2018-06-21 8:19 ` Christoph Hellwig
2018-06-21 8:22 ` jianchao.wang
2018-06-22 15:10 ` Christoph Hellwig [this message]
2018-06-25 1:29 ` jianchao.wang
2018-06-21 13:13 ` jianchao.wang
2018-06-21 15:01 ` Keith Busch
2018-06-21 18:21 ` Bart Van Assche
2018-06-21 18:21 ` Bart Van Assche
2018-06-21 21:15 ` Keith Busch
2018-06-21 21:30 ` Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180622151043.GA13470@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=jianchao.w.wang@oracle.com \
--cc=josef@toxicpanda.com \
--cc=keith.busch@intel.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.